From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86EF2226D1E for ; Fri, 9 Jan 2026 21:38:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767994681; cv=none; b=pwi6+jedyfpTO2eH5X7vXLMpOmnhdX2EycnXPW9xvOAgOuRieWhlBLhkuOhA/8t5E53reGi3megHYwbDNx7z0+XTu+C7T/WML+KzBb79opykJTALh8VInrGoGSlMMHs0alcYrGCguTNAEWvM7g9bvglVVlalyaj9QzZ5Gr7D8QA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767994681; c=relaxed/simple; bh=S5aVh520K3lg8UkCLOBc2MadcpPdNgMqmpTmBKE6754=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=X9S+tSIBMID38iP1402KWm2nbt5Guv3fQmPLBlPqPRKnJxpNcZyUXWHJSVSKzO7No0S2qq/HzLF1rXnUchbzuf1If1LdY8AIQbLWx+4Ee5Tx43cA7cFhgoZOctqp+cQ38aJYMjO4ypCpy5Y7Va4UhO1qhJ40DaUFIovthfnUDG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=Z7ZA/qCz; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="Z7ZA/qCz" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-88a288811a4so45211886d6.3 for ; Fri, 09 Jan 2026 13:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1767994679; x=1768599479; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=fldW0JXC7CiOQzI5zIq0HGur2P2GdtXN8gYrW1+z1ek=; b=Z7ZA/qCzmaRLPwkJyMk6jGAq7IH/dQh/5XJvJfCsJBljn0fDFlyKhawKWrZt/j92zv miZe9l26smYyGsYaLP9Y3MYB2WpGbgGiVzAwuq/itccMAd9stWMM6Ck9m/O7UEjwBB0R vDb8tE4Pa/xGkARaLAjOq9S2Kf+NaBPK3sk5kOk9bvf2VXfDuBwHYFdOFkD8ZU8T7BIk KCVFQRNxUXj21M+mVWdx++w2Ouz2waruSaQueadls1Lld4gTSfjEnshbI5H5iWKEb4Tr O7vYioESDIsiN8SW63Z0axkQ8dIP6mhDnS+kKKh16u+ChJNtqIBkU0UJg1EhKxhHS0Ry foYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767994679; x=1768599479; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fldW0JXC7CiOQzI5zIq0HGur2P2GdtXN8gYrW1+z1ek=; b=FWE5AXgSImEWKVEpdEOwCPej3IzjFYpSLBSrBdJarNEiVjG4hEKHZzf6t0JewdzpjE 65O35pTwMmtbVLSL35LkBur3RLUy5+x4ktYGQXU1+r9s/vURbVingnIAxOVI3Cju1XvK b8ipYVEI4B8ecpNuB3EHBF4Tj9GK5MxtWkcxdpqECAtHbvI+9V7aY9/MFvu4FYnULhF2 pleHac5RVqZJK+ZMcX31J1XYuYcY8ib/Wx+2q6hvcKJoXqhONJodt7bOnvOJfq/MBVmi 5IT2xGkaRpfUsbZhnJ8IXeSFI1kDWiCXpFAnQHRC0KJYXXZzPwXC9MR+HU9VpglE/Fhg UXiw== X-Forwarded-Encrypted: i=1; AJvYcCVO5vfAgh2Hvae65Rn95w+tIPFEn+U7qFmtYDXqL+Ydac6oKptzDrpF6CdrrLqFUm7drJEDpBblL7DU4C8=@vger.kernel.org X-Gm-Message-State: AOJu0YwEjjzABgQUYwQxj1h9VRB0nY+S6hohhvM7e1KSllF0IfAdQbSb LP+zNlrAvzQctPDfwZy23cjH9LHh9ly2IpPQBbm5byIFxd2e9ywqgJFfYDBsGezS/A== X-Gm-Gg: AY/fxX5aWbDVAP0RnQ5XdgaL6l0Sawig3ObabPk7lVgHenOZrz5MYLx5juV/v+F7BZ7 oP03qwfGU44LPg8mTNv40C16Jn1JO1bNPcRm+frT0nkw5lvAlpdCrVQug+XAqr+FuRArF1a73mU zrh8qP6/+8iVF6RtbFoypcg3XM2VJCmeeh98WCC94+GGzh7BvBpetE0hleuDUzjJ3siVDrQK3F4 cx98nMpOZM8ij5Awd22gEhdrEWIc7tOuf4RHOiY0E0KT0u11F+/ftEJEQ2YT2gy0eG66fHC0pB+ Yq+bh+93prBH+UDP+810nHdi/rGasrt61m70Oxdz4YxEtWVD3nRl4szCDM2EZwJCz4ObDk1CUA1 B9r4PCDsI+OpMii1hugu6GuRRelZz4PSfTL25eJ6Jsz9Nbaf0nSA6T/JmoC3F44vdsN3gpgOVuL FQ5gq8z75OQLoiWIC14kgsNeiz+/BpBuWH5xSH3rOPCCniCQhy9usOIKRH X-Google-Smtp-Source: AGHT+IHyxQlUz94Mq/TA/alMr+BodvbzETad/mWJ9ul3qvZjqzarb6iLsc9wEl+Zg2zXqVrO0ZIkcg== X-Received: by 2002:a05:6214:5906:b0:888:8247:698c with SMTP id 6a1803df08f44-890842356famr145099136d6.40.1767994679383; Fri, 09 Jan 2026 13:37:59 -0800 (PST) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f4a9a19sm912522785a.1.2026.01.09.13.37.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jan 2026 13:37:58 -0800 (PST) Date: Fri, 09 Jan 2026 16:37:57 -0500 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260109_1633/pstg-lib:20260109_1633/pstg-pwork:20260109_1633 From: Paul Moore To: Ben Dooks , linux-kernel@vger.kernel.org, audit@vger.kernel.org Cc: eparis@redhat.com, Ben Dooks Subject: Re: [PATCH v2] audit: sort missing compat prototypes References: <20260109133938.404748-1-ben.dooks@codethink.co.uk> In-Reply-To: <20260109133938.404748-1-ben.dooks@codethink.co.uk> On Jan 9, 2026 Ben Dooks wrote: > > The comapt_xxx_class symbols aren't declared in anything that > lib/comapt_audit.c is including (arm64 build) which is causing > the following sparse warnings: > > lib/compat_audit.c:7:10: warning: symbol 'compat_dir_class' was not declared. Should it be static? > lib/compat_audit.c:12:10: warning: symbol 'compat_read_class' was not declared. Should it be static? > lib/compat_audit.c:17:10: warning: symbol 'compat_write_class' was not declared. Should it be static? > lib/compat_audit.c:22:10: warning: symbol 'compat_chattr_class' was not declared. Should it be static? > lib/compat_audit.c:27:10: warning: symbol 'compat_signal_class' was not declared. Should it be static? > > Trying to fix this by chaning compat_audit.c to inclde > does not work on arm64 due to compile errors with the extra includes > that changing this header makes. The simpler thing would be just to > move the definitons of these symbols out of into > which is included. > > Fixes: 4b58841149dca ("audit: Add generic compat syscall support") > Signed-off-by: Ben Dooks > --- > v2: fixed missed commit of include/linux/audit.h > --- > include/linux/audit.h | 6 ------ > include/linux/audit_arch.h | 7 +++++++ > 2 files changed, 7 insertions(+), 6 deletions(-) I merged this into audit/dev, but I rewrote the subject line to "audit: move the compat_xxx_class[] extern declarations to audit_arch.h" properly reflect the change in the patch, and wrapped the compiler output examples so that 'git log' on an 80-char wide terminal is not overly ugly. Please take this into account in future patch submissions, thanks. -- paul-moore.com