From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CF3632939A for ; Tue, 10 Feb 2026 14:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770734377; cv=none; b=lPF/113q/pUxoZZOwM0PzWsYX3u6AgwPcZ4dIcxZ/8HdVoIPF59NsBtz3E/H1gY9KQ5A5feHuNLNnhxEUvfGmljL9pLk5Dh5mOMQKQQDL+hcD3mHgkyp38d2jyK5tlR2Q8zq+QyT1btlW6mMYrKLwqsgUReZ3fzMoPW2PKwph6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770734377; c=relaxed/simple; bh=vQaRXm2+AQXIYLnEQ4jVzPZq4om8wNPyfHiJq2lspn4=; h=From:Message-ID:Date:MIME-Version:Subject:To:Cc:References: In-Reply-To:Content-Type; b=UNrvY9fhsJ2lTF4NDMjyjWbejvJXyhVzEsViz4tteizq42Vnu3HUUhxKh8wNyc9cyoCp5w7MHwVr6OJSgGse5kpx9hLNEunEFIykgxMccOMRv9ZK9nHJHQfVljRcqaZE0A5O9Iu0nYd7THuCfFaeg+tl+Exrrphaa93jTJmEkso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XFfzvWUQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RhFX/Jrh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XFfzvWUQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RhFX/Jrh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770734375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uoguIq7tMxRUKFK+t5O/JiWw37kAXp4tCRjW/Z7hpYg=; b=XFfzvWUQN1urUgunvbyK+E+nNhDmSfPs8SGnlMgqa3cRw9br63KojYjyipc0uCqVY1qd3i 5WARe4Voy2L5ey8NwtwF+4A1eRqqmw9bqce8GR7qsUB8X2ymYlhVr1+453DtC0SQVAz6L9 FZaH14rkCo3b6EF410g3795stg0+tj8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-IZdiuTCgNXCzh3-47IjjPg-1; Tue, 10 Feb 2026 09:39:33 -0500 X-MC-Unique: IZdiuTCgNXCzh3-47IjjPg-1 X-Mimecast-MFC-AGG-ID: IZdiuTCgNXCzh3-47IjjPg_1770734373 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50355952ac2so159009911cf.0 for ; Tue, 10 Feb 2026 06:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770734373; x=1771339173; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:from:to :cc:subject:date:message-id:reply-to; bh=uoguIq7tMxRUKFK+t5O/JiWw37kAXp4tCRjW/Z7hpYg=; b=RhFX/Jrh/uwhlMLD++hGfd4S1ZX8p8ZjVlJQCzf0OOMXdf4pjJVJcrGg13+40vb4Iz H1nSqaR61TyCMFuhqy9BVp20j9sNAMrmwZqA+8Yktyj6c0kkvoGd3ouk942jpTk5M69G jNX15Rm6BxV3aLqOJw5xMBRZUPpIQS4zPT9GEM3IbcyJRa3GxBj9fbT9CC4Yb2OCmkiG A85PjCcbZI2tymZUW1QYvkLSvFxWugzBiyVfn0hNWKh34QBD6MqMp7RAVsZAdoPegOON 9FMkWD9cWGMisgvks181yN3B2R/EZDkUeT1Eitu9VOL7AVWDiWbj17n+Xh9m8gu9lhot Hwew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770734373; x=1771339173; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uoguIq7tMxRUKFK+t5O/JiWw37kAXp4tCRjW/Z7hpYg=; b=QoNsj85q5ZXz7rPBdjNhVOs577bqa8Jtm5sTRw72yk/UQ4etVSHzI7CZauX+4IGkjI CW1iWvNCz9p6+m+wKKV8Ju+y1Vj+KNezRX70URVZgoURLhiJg4Q0Ni9NnNcw29ohUJ4c miI94oRo5HS21t07UPMNnLmYKgdZJ4OPcD2EZP7yW4mcF8axwbgmLpkyQLtk5at+CvnX /aYqZIhiKNbZnD/xFbGPyRzZrCNlcxAdTNsN6guiZU8cZlw7AKj8sLJFGHFkFwZeHkH4 2K24lG+LxLfg5rLuQGjImxM8eNumEldZSRbHw1ILQ636GByxz2GVUBRJb6yDbWUJ9SWh nFdw== X-Forwarded-Encrypted: i=1; AJvYcCVnoy7HdENn5CHEiPrH7qZpL6wkNo+KvD8/pJZRBwdO8ZeLMhYv3asNGjWH7HbdG2LQ+IUYajYaPu69aKE=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ5bdzf/7QgxEXCVcivMJMgzLtWt2hPP8tE3A9uixdpJABoeae Znvts//xr/IuV6iActwgjR4bK+2BNLqOgbroaZ3gizoYoYk/RlDOr92UBCy4Ax5eToQqdg1Es/J zMLO5c9+mX5zc54Bhjb8nAMZVAhByTRfGIEM5Wnwz31Mqh8cqSFNc1brGNQFODdVRXA== X-Gm-Gg: AZuq6aLh9641AMgdRd5lpwmEpoX0UuP3Nfp4R+W2y0Boo8a5cQfh//+2DDIU/Xu/U7u srVhn6zYyybN8HbAmebJZGYccbGDf+6T4mrb46Ta8ZVB7duYBGNjMXH/m24cbkmJzFE3g5amQv8 7FYwho3qaClO8pULyhA2+c/Seosz2FhVDPbASGUNn6EhclFcoqsAQ0DMdGiaQ//ACmJ+jT8s/Q1 vJ1NnGg1ZDZhm4jyManmaB6atyb5DgfrFDEAuAfQKtfI5Jy4MR/vb3tqpyMBlS0KwuGePsL/xsX HLBf2YAR0elbk8tKp1jmUHLxVKQgeDR81DIJLXq8pIhRAfRKbXFeSDngn+Ky5HX66zZYH1W3Pif +pSeegs2yzvO9o65wDhuKDw/6/vusSPaKi7Nj8MDL4PPqyPtW+yTrWOnGmyHXs38a3jJ9 X-Received: by 2002:ac8:5d92:0:b0:501:40b2:453d with SMTP id d75a77b69052e-50672e23c11mr29070621cf.23.1770734372863; Tue, 10 Feb 2026 06:39:32 -0800 (PST) X-Received: by 2002:ac8:5d92:0:b0:501:40b2:453d with SMTP id d75a77b69052e-50672e23c11mr29070231cf.23.1770734372411; Tue, 10 Feb 2026 06:39:32 -0800 (PST) Received: from ?IPV6:2601:188:c102:b180:1f8b:71d0:77b1:1f6e? ([2601:188:c102:b180:1f8b:71d0:77b1:1f6e]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-506392902eesm99012571cf.21.2026.02.10.06.39.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 06:39:31 -0800 (PST) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: Date: Tue, 10 Feb 2026 09:39:30 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH/for-next v4 3/4] cgroup/cpuset: Call housekeeping_update() without holding cpus_read_lock To: Chen Ridong , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Shuah Khan Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260206203712.1989610-1-longman@redhat.com> <20260206203712.1989610-4-longman@redhat.com> <119981d3-1cf9-412b-9b4d-bc4bcb188104@huaweicloud.com> <67f4b01a-7b23-49c2-a8db-059316300d39@redhat.com> <08776cf5-054e-4137-9ce4-f193feeb2599@huaweicloud.com> Content-Language: en-US In-Reply-To: <08776cf5-054e-4137-9ce4-f193feeb2599@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/9/26 8:39 PM, Chen Ridong wrote: > > On 2026/2/10 4:20, Waiman Long wrote: >> On 2/9/26 2:23 AM, Chen Ridong wrote: >>> On 2026/2/7 4:37, Waiman Long wrote: >>>> +static cpumask_var_t    isolated_hk_cpus;    /* T */ >>> Can we get this from isolation.c instead? >>> >>> The name probably shouldn't include 'hk', since it refers to the inverse >>> (housekeeping CPUs) of isolated CPUs, right? >> The housekeeping_update() will create an inverse of the pass-in isolated >> cpumasks. As for the name, I add hk to indicate this cpumask is for passing to >> housekeeping_update() to update housekeeping cpumask. It is not directly related >> to the cpumasks in sched/isolation.c. Please let me know if you have  a >> suggestion for the name. >> > I understand the intent. However, when reading both cpuset.c and > sched/isolation.c, it can be confusing whether isolated_hk_cpus is an inverse > mask, since in sched/isolation.c “hk” consistently refers to the inverse. > > How about isolated_cpus_applied? Applied to what? I did add a comment to describe isolated_hk_cpus as a copy of isolated_cpus to be passed to housekeeping_update(). "hk" in the name refers to its role for being passed to that function. I can't use "isolated_cpus" for now as it may get modified by CPU hotplug concurrently. In the future, if CPU hotplug no longer modify isolated_cpus, I will remove isolated_hk_cpus and pass isolated_cpus directly to housekeeping_update(). I don't think we need to spend extra time bikeshedding what the right name should be. Cheers, Longman