From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91564283680 for ; Fri, 3 Oct 2025 11:26:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759490820; cv=none; b=DrT/QjrHUg4pw6AyPTgsxAyV05uspjNYh6qJHzlYof9XjxfFR+/qly1DlO6tATfKHsg6LStaQIJ+MDAD3xpXpm2AFMinP83j6Bm2Q4ydwv+Ukun2dhqm+uWPrMgNk651C0InWcc/IFRCzLZIBui9/EXXpwblgIBAEbsh9iZPqyU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759490820; c=relaxed/simple; bh=YtdNjVaGBtjpugUu5JZhhW80yJtKKEGYmhthPhLz4Pk=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=kwKtca/eds4byIzaVP/tXWFuzpwtZ+KlBnJhH3q43sUnBRezHAhDFBXZKfwGsb1Aypkz/UUGbtnjwcd8TM13xTgPatBv4z9f82KtfVTGBvf2DaeXVGjT3bQ1mG3C8RMoBk2ujjdj6ovP6IGKWcIX3TkYlFYnre54+9BbE5V1/U0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XLX8BlP+; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XLX8BlP+" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-46e430494ccso12766325e9.1 for ; Fri, 03 Oct 2025 04:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1759490817; x=1760095617; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=FjjyfVbmRhvSAkr2TJodpaTn31PsZR4ycOzkb5aM6Qs=; b=XLX8BlP+W1rEeABWioKiqqUCL0a2PPVzUCqXClwBFhN7rXPi1SJBgApRc1LbcH1wb/ M26QRsc22zTD0uitH4GUWu9Z7jNgVs5ufOTe2R+RHPSn0EyWbatAsPrY9lBrIphsrXv1 OtShsRnEPH3ARP5dAk12ZrbLDZ2DmI2XA03gSSqo/ntkznLXFJmfv1jyQGDXaOByiUkW xldjE1EF1y/wLo4VwWVtZCO4bSt4CiaVbmr0clWsuwWTZlBrlbTIVBQxIMIyxPa/GnyF Xcetn8Oo9OFyfbN3ufgsfyxtGUH7WbkR+QxxU4GT1+lhbGUU6SmRNCEqpGwULaL4BB0h wrvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759490817; x=1760095617; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FjjyfVbmRhvSAkr2TJodpaTn31PsZR4ycOzkb5aM6Qs=; b=jGmdJI7DcxWas71U/PpH2og5cJOTsuJq/3GYAQZLfL5/X0juG6/Renl/uoLYcFkLDW dIM3OUqJvYy+r6LYqIwC9HQLFrDM022CgvqPXpBSsek0y2JTyVZM9HE8gF7aePNDfsPs WQmHN+1xePRkVujTrjUC1QDBTpR8BSCgFm66hDymlxi6d93ElWipjofda9R7Tdmle/8y K+pVDIAKSxhfH/HkJWtLqtilhGUlk4Nvd/2/eqhMa6IRH2ltc4pV0hGjnfGcYCO5qXij NoTlNQEU/au9TYkztMZW2FsSkc545X+eJNzMGF5vxrs2AgR6xg6VCgCbgUWdMntwr0Qj o06Q== X-Forwarded-Encrypted: i=1; AJvYcCXvAwXk6FosH4l7zMCpATLqk/uR11Ae5xW4+qjf1LE7Xaex0MlSgRZ8KlwCYW4Uria5XQz00akXQJpv7nU=@vger.kernel.org X-Gm-Message-State: AOJu0YyLqsS6Y8nctBbPIeVcTbF4cw7VjYpnqHk0Iwjq0AU8B0BAcPOY M1Xx++ePwtH1VyWbqX1RZpUGmE3kRKFvoRxGdHs6JLByBVDpemOJkLU0yOlcTsta5Ow= X-Gm-Gg: ASbGncswmHIpQ4WABJb0jtAalBuUJtaBB58IIe/fIQOA9mJWEq8uNawuV2h+YXSsyYv H1VNuEDTNK9k+P8uSItx89EXFOZYmtS/d9RyBbklMYSV8btwkR9JDrBE7vGzcT/fk6p/+yfB/+0 +yikivgWncGYgDS0PBXXmVKq3O7olh1G5XsZNRKhaSuniqIFODByWgJjSjWWhW6d7qpS6W08jGm uT3JLh3AEM7pR24+sLwHBQp8CEnhjktsxZ4xXP9iAcQxMHCCFp1mE17LSuSQ7BvjtqsIdsVypIU fH3IiPgMehh1kyJbvAfFP9pdI+nlfcl/Ibal1Oqa9RhIJPTtNzZAEPfoVPTzlvXn95aa0EksCbh Qk/qCgXPPnyxRgnjUSSeffpldCP+WmST4FTHjaItWSWEDhNcORXjvKhPF X-Google-Smtp-Source: AGHT+IEa6CUW5LAl08YINRqtUMfMTIv6xNaCHjkSZbWtuYs8CeOLeyg9VUpU299wnFEU8PVFTODVOw== X-Received: by 2002:a05:600c:8b53:b0:46e:4b8b:75f2 with SMTP id 5b1f17b1804b1-46e7110c4d7mr21569915e9.16.1759490816875; Fri, 03 Oct 2025 04:26:56 -0700 (PDT) Received: from [192.168.1.3] ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8e97fbsm7466058f8f.34.2025.10.03.04.26.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Oct 2025 04:26:56 -0700 (PDT) Message-ID: Date: Fri, 3 Oct 2025 12:26:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 00/28] Legacy hardware/cache events as json From: James Clark To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Xu Yang , Thomas Falcon , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Atish Patra , Beeman Strong , Leo Yan , Vince Weaver References: <20250923223312.238185-1-irogers@google.com> <86331395-140b-44ca-8351-8bc5c511e211@linaro.org> Content-Language: en-US In-Reply-To: <86331395-140b-44ca-8351-8bc5c511e211@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/10/2025 10:20 am, James Clark wrote: > > > On 02/10/2025 9:10 pm, Ian Rogers wrote: >> On Thu, Oct 2, 2025 at 10:58 AM Ian Rogers wrote: >>>  From bisecting, this change came from commit 9eac5612da1c ("perf stat: >>> Don't skip failing group events"): >>> https://lore.kernel.org/lkml/20250825211204.2784695-3- >>> irogers@google.com/ >>> Taking a look. >> >> I sent a fix: >> https://lore.kernel.org/linux-perf-users/20251002200604.1792141-2- >> irogers@google.com/ >> that makes it so that only if all events are unsupported that perf >> stat exits - this is addressing a bunch of latent issues and fixes the >> perf-tools-next regression. I don't think there is a difference >> between v3 and v6 wrt this behavior, I think you were probably just >> cherry-picking the v6 patches onto a newer tree. When those 2 patches >> land I can rebase this series on them and drop the first patch of this >> series. >> >> Thanks, >> Ian > > That is true about the cherry picking. I could only apply V3 to perf- > tools and V6 to perf-tools-next, that was just a guess without the hash > in the cover letter. > > I did test both unpatched perf-tools and perf-tools-next to confirm that > the original behavior was the same in those. Once I saw it was the same > I assumed the difference was only in the V3 vs V6. But you're right it > could be because of the base. > > I'll retest with the fix applied Yeah the behavior seems good now after testing with that fix applied and the first patch of this set dropped. Will wait for the rebase and then do more testing.