From: Guenter Roeck <linux@roeck-us.net>
To: aiyengar1990@gmail.com, Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Primoz Fiser <primoz.fiser@norik.com>
Subject: Re: [PATCH RFC] watchdog: core: Ignore userspace keepalives once the system goes down
Date: Thu, 19 Nov 2026 09:10:39 -0800 [thread overview]
Message-ID: <b11f910f-c687-4d11-8a39-879e9db82cc4@roeck-us.net> (raw)
In-Reply-To: <20261119-watchdog-reboot-keepalive-v1-1-c5902d959796@gmail.com>
On 11/19/26 08:53, Arun Iyengar via B4 Relay wrote:
> From: Arun Iyengar <aiyengar1990@gmail.com>
>
> A watchdog left running through a reboot should reset a system whose
> reboot hangs. But a daemon still pinging after reboot(2), such as
> systemd after "systemctl reboot -ff", keeps a hang in device_shutdown()
> from ever being reset.
>
If systemd is still running and able to send watchdog pings, the system
is not really hanging.
> Ignore userspace keepalives once system_state is past SYSTEM_RUNNING,
> as da9062_wdt and da9063_wdt do since commit 2f61b3a74699 ("watchdog:
> da9062: da9063: prevent pings ahead of machine reset").
>
Those drivers have a very specific reason to stop pings during poweroff,
because not doing so could result in failed restart / poweroff sequences
(as the commit message explains).
> Signed-off-by: Arun Iyengar <aiyengar1990@gmail.com>
> ---
> RFC: this changes every driver. A reboot or power-off whose
> device_shutdown() outlasts the timeout now ends in a watchdog reset.
>
Which would be unacceptable.
I don't know what problem you are actually trying to solve, but in
its current form this is a NACK.
Guenter
prev parent reply other threads:[~2026-11-19 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 16:53 Arun Iyengar via B4 Relay
2026-11-19 17:10 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b11f910f-c687-4d11-8a39-879e9db82cc4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=aiyengar1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=primoz.fiser@norik.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®