From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E7FC347FEA for ; Mon, 4 May 2026 08:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777884604; cv=none; b=jlcpLGDac/WESaKX9mYyrLYpMpEMaBQMX1Nu6gq2xNtbc1eUbnrD8EqO1yAqvArAG/pbYTIzFyleoHP1VLYoz0+OwGy9qBMgQ3YCWWaZ+fvr5s4FMYv9sZFu+9iBSOVk0ODNNbfm2ddjs5dTri+5ye575gI8cDk8nT0jGm6q06M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777884604; c=relaxed/simple; bh=CJ3K3N4tQqLee938aGtoxUVu9FgWpp9tTJ22A/NKhkU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=LNi3iHGv9WUpCywp8mYREm3gb2QP+0VHnus9R5gCJLJRE8EUn9mTBcUP4mME5qIkV8KdnOl/oZM2swc07ztgm8tDfxiDbXrgBL+iJzmyWUquCt9u2KV23YjzckFbPvAP1/yq+hEJA6VuiQK06GzvslRxCTagp+sJbhevjIriqhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EIWNcyt8; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Aa3MTutL; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EIWNcyt8"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Aa3MTutL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777884602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CJ3K3N4tQqLee938aGtoxUVu9FgWpp9tTJ22A/NKhkU=; b=EIWNcyt8SmztxiobRaVGMYp2SBfiSkgZhuKZa4Q73ebZvbTBK8G/7Tqg42GUZQQcNAKzRP Z3VO5KiN5TzbkgSW7Z2PyavkH/RBrfcne3buMqqeyCuOal+X4ErXCzxKL8Ll2/qTSLmA4R I51gE7mukfrGMxkrzVpFwg8v//lE4qY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-um8Dwsk6OxK70rzL3kWxoQ-1; Mon, 04 May 2026 04:50:01 -0400 X-MC-Unique: um8Dwsk6OxK70rzL3kWxoQ-1 X-Mimecast-MFC-AGG-ID: um8Dwsk6OxK70rzL3kWxoQ_1777884600 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-488d8deb75fso32387655e9.3 for ; Mon, 04 May 2026 01:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777884600; x=1778489400; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=CJ3K3N4tQqLee938aGtoxUVu9FgWpp9tTJ22A/NKhkU=; b=Aa3MTutLumJwoulAevcYc4fdOxslVHv6pFjasllik9uu45zCARy7ImwJ7ye3yHYwyj xcMaXSFEpVx0eCdLgilpaQSI/80Dk6YK1EIpaJIy/MnrB7kxqO+O09DOLkDllz1ZrONp LNXdAoE1Cm9+10R+bSr6oQmIxlvgJGhubiEYvl1YWsuKUzyDXWf8FNsNsK8tN0J70uem 7dSSFy7i/yzga+vA9ZCsHyL7FrUgOlzaBRfN22T7tFHjfVGEWbPdcmL/B+YMlvSl1ttl AuYBEhl4PdZwounNL7ey9jncxOV062bjS4m1841dbYzV9yd1XgoOSqgqW/c78BCGcsz6 mLQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777884600; x=1778489400; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CJ3K3N4tQqLee938aGtoxUVu9FgWpp9tTJ22A/NKhkU=; b=dRe5xpexhRYjk5fOHtjbCwAU5CfbKZ8UlQh/RXugNXeBZRF2iIdGuH/Ek11PodLpCj DWQcqJKz5DVW8Ei50fBsbZchFL2+EnzvQcS9oT2NehHCCgIkaDGfeVbNb/br8UtEojpi iv09/6AmdG9Lg8Z+LIn8AsFYvqoLS7p8lMrh3PSPdWmp5p1peYYMN1hnF+Gh9LIxUh+G /AqreXpDFQtJSVYQX14wJTDbigC7XC9JbPFoKjVfTRSrVtBxWpscXnRWPv9lljUraBLg JckyW7ZGM4pSK7RnHMJYmn/hUAmtqW9C5IVXwe2EKzrKGewLDlaj9fvu2Y5iLttbflQX uo0Q== X-Forwarded-Encrypted: i=1; AFNElJ+UOsA2isEu5saafJk+aRFbS4degtXpXn1wkgkRPE1W5y6o82kJSZ2eJcLsLrauubqQEYVPKBmbRCRvLlo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxkg3nVXCFNHnIkixrn341KY+FCkybYy2Ay4rmiNwo7wTKLOlSN pXL+wzuzomM41W4N99dxDFPzRmyxRwbYihDV1F5FequIrrbZ6bzsiiHPgQs9Hop2cwp6RIP6FUJ N1mB/L+L6IQJrK4hB5z58HUOQ5Uz5+88YxF/4L7LbMnWHphCVbDPLmFuYiC6WEyK96Q== X-Gm-Gg: AeBDiev1rI+QyEW2KYYZ7WX4AmCZSKlqzjctgXtR0vf9f0pNk/8m637fZHOrGqtwMIo 6xJcEjetVBzLVgnKomu66zeiTjsYqsjrzn3Dj6XHRS94FkiB9QWDPC1mPa++NENrgCJjFEvyD/d XGWVsdgHFO+6SM/9tDmjyPR8LU2k5JaBi8emx3Xg4t1Zry0d/mBNQRMD9LThGNl4+ZzjomTVJVg BPbMvIx80zSJ+z2WbTkD2GuUsnyWtGJwp47TKIM1LyBsauKwwvr3eqmI9BZeL57pL6PlA7q5FI8 SnAbPBS3AMHyYikuqus4b7UKZ0nUq+gemSViwMuPstFJJgOv1UFUUCS5C1VfTEDAIjxyFba5WN8 SY73XiV4np4zzZLhjQu2QeAq4DwVKnsUjoyHjnSqPDOfmVD/zd7VarzVSHBEoSx7yzbeITtM4P/ CWZVtQFjSZTePL8pkvF90wG4Ur4w== X-Received: by 2002:a05:600c:628c:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-48a988be16emr153041145e9.21.1777884600033; Mon, 04 May 2026 01:50:00 -0700 (PDT) X-Received: by 2002:a05:600c:628c:b0:489:1ba8:5bf0 with SMTP id 5b1f17b1804b1-48a988be16emr153040425e9.21.1777884599400; Mon, 04 May 2026 01:49:59 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eb6ffb7sm262523395e9.5.2026.05.04.01.49.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 01:49:58 -0700 (PDT) Message-ID: Subject: Re: [RFC PATCH 07/12] verification/rvgen: Add golden and spec folders for tests From: Gabriele Monaco To: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Steven Rostedt , Thomas Weissschuh , Tomas Glozar , John Kacur , Wen Yang Date: Mon, 04 May 2026 10:49:56 +0200 In-Reply-To: <8734071s43.fsf@yellow.woof> References: <20260427151134.192971-1-gmonaco@redhat.com> <20260427151134.192971-8-gmonaco@redhat.com> <878q9z1up7.fsf@yellow.woof> <8734071s43.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-05-04 at 10:44 +0200, Nam Cao wrote: > Gabriele Monaco writes: > > Do you have any other reason to prefer "state_d" in your example? >=20 > Because "state_d" is what my dot renderer displays, not "state_c". >=20 Right, in that case it gets more confusing.. Then I see no reason to allow a different label, let's just count it as err= or. > > Either way we are opening for confusion (like in your example), so if y= ou > > believe throwing an error makes the grammar simpler, we could also go d= own > > that path. >=20 > I can simply add a check that the node's name matches the label. Yeah, that'd do, keeping in mind the label after a \n can be different (HA invariants). The invariant parsing should then make sure nothing else appea= rs after the \n . Thanks, Gabriele >=20 > > In any case, I would make the label definition mandatory. So my current > > sample > > model is wrong. >=20 > Cool, so no work for me then. >=20 > Nam