From: Dave Hansen <dave.hansen@intel.com>
To: Nadav Amit <namit@vmware.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/kprobes: Fix 1 byte conditional jump target
Date: Tue, 7 Feb 2023 22:56:48 -0800 [thread overview]
Message-ID: <b1300308-8f29-fa73-5542-25d06925ca84@intel.com> (raw)
In-Reply-To: <B790D31A-A0BE-4707-BA01-398B5668C3D8@vmware.com>
On 2/7/23 22:34, Nadav Amit wrote:
> As you said, I guess the change you and Masami proposed can be done on top of
> this patch, which is (and was) only intended to fix the bug, and should
> therefore go into 6.2.
Nadav,
To fix this issue, you proposed:
p->ainsn.rel32 = *(s8 *)&insn->immediate.value;
But, this is, um, rather obfuscated and potentially less correct
compared to:
p->ainsn.rel32 = insn->immediate.value;
I'd appreciate it if you could update your patch to do this simpler
thing and resend, unless there is a strong reason to do what you
originally proposed.
next prev parent reply other threads:[~2023-02-08 6:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 21:08 Nadav Amit
2023-02-05 7:49 ` Nadav Amit
2023-02-06 14:19 ` Masami Hiramatsu
2023-02-06 14:18 ` Masami Hiramatsu
2023-02-06 18:42 ` Dave Hansen
2023-02-06 19:05 ` Nadav Amit
2023-02-06 22:38 ` Dave Hansen
2023-02-07 0:54 ` Masami Hiramatsu
2023-02-07 15:21 ` Masami Hiramatsu
2023-02-07 15:33 ` Dave Hansen
2023-02-08 6:34 ` Nadav Amit
2023-02-08 6:56 ` Dave Hansen [this message]
2023-02-08 6:58 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1300308-8f29-fa73-5542-25d06925ca84@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®