From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC99C3D6683 for ; Tue, 19 May 2026 07:24:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175494; cv=none; b=HVmRpOFDzgfCC4Sp+o1sd8Cynf6ZepXrESzWqp47kcgWuPWIs00t8CVnSqRxEIBrkoQaB1kuGmWoBFrzzHlWfnECG5nwNURaPV1QMEaOLQ7XL8bafK5dbAIyXHpmbj9rQDL+nk3Tw0gwGVruga8RLw6TLrMiMiJzFITlgD5fUII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175494; c=relaxed/simple; bh=HSEDVItpEkjrsn88aVVU0XPcMIIrjcppcj1wjHBxIjA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=rYNHBBwMxVxc3dJnTFvcUN6RqTwXtKGW9gGLSU15okvPiTZ0YFbLbxoz99e24wAuZ7Muz7Cx6Ka4MMgdwqF0xpqPvBowUyPnNEiLlFIpw0Xuhu2s78Ysmvs2MdRqRTzzAf9nmXV5JIpMGGlbe5KD3M0KNNGFaT9zM5mfqjI8o2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EQshz8h2; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EQshz8h2" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso32650165e9.3 for ; Tue, 19 May 2026 00:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779175480; x=1779780280; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=T1JwviSU788ImildKu5V2g5LdkhxoNhqBKf1BksYwwI=; b=EQshz8h25VLrOPFd6Q95O0GVmL53kw/ewPAM7KGC7KfyqinCZZPGwhrYfgQgRJQeZa y1VD2p/lxcFJS7eRzkM8lj0+OhMlixdhGo4fuUMUAwc7dXwzxQRIHDIKJ10BgqoFdmN5 RBIPWqGUcPjKdi82FOjXkbbj2NffHOdzv8KRE4J8+5mW2oRhzRIJOKelymlintNmPz4F D+8eJpBWn6Zsin44Drj20193xSR+eQzHpSlaUXw8hmMK3FjZGJnpSnIp6qxu2aGT63n8 LjhFfZk/5LATHI1mlFNC44PxLX4Di07eBncSEBH99ZvhoF3aThLtZ/fOjRrhKq8MxZ6o TLAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175480; x=1779780280; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T1JwviSU788ImildKu5V2g5LdkhxoNhqBKf1BksYwwI=; b=JWZXWWaLnm9Ybzzchmz7GvXr42byl3Z0Jic/lEW1YXvaW+45GdVXV8gD9AntHLIAd/ 1cPGL5nzqeaiGvJTz3jHWhFOxyLGWm41imNEiwVdtIVQ3bVmS3Hb+BD8t+n7ffSxw6By 89QsGBBOE5xepxasBvdoqm1GnwoCWNoHEIYc78dppXapZcMnZKSW+f+rel3Wg9yTpZlz +wE5FXjzuQLgJJLT0PJ2hbaBg5NBm3TT+lSrr/jDdHCnGOhPiNHVuQX+5ogOU+EOvhSJ 4UsWWvijgFp7EZbs5luZjWhIhnFNVonx+b1Z9RfXwuuRLjzKwSWotiEvRmrs2R+OUHwp 3aSw== X-Forwarded-Encrypted: i=1; AFNElJ9jAp53gkxJrWWMv3RuuroIQduB84pC4LKSveWkSVNqcXp3tkXcnOzfMJAvd4jNCb+sgdDP/SmMklcfho8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywn7W1b3YDZmzdHsa0RUqUQ3nFdagpFUJZo1hSBFBIxBpdN1kmS U6a081eKj3hlwRnXetzhXA0ePgBFWnoHJjJ/Md6CoqALCzi81iLe5qh9nAOTCxE7Q1rRz21AlSK /RD4E X-Gm-Gg: Acq92OGaQFSQsECWXzvdY/bbLti2rxnS0gJlwjAwX4j7WuCzLspLp3tboHUTGt9MlJT PDlfx8/bH3t2OWx8CgobzJbmxjrj9gzBFDUDF8A1SEn493XCrPL2GzqtPXZD9siXVkZX+84zCmr mVKFTC3WqWWbMraW+m0BqK5OrLb6GpHHt6wIgCcPQ+z1B86WwRqzuseuuV35K8XPLSFd1ZaaW9u IX2VZhJphrchE0MCwO5Hn9AXAehJjvKUDGt++yQPnNpF135EmGBOEFxP48DdRHRnrPiXbobIdC1 CmdwXcohU/PbHhSa88TbY82XkorWC6YZPS9KjzV7f80TUpZYl7ZdV66Pnrpnj4n9wIIv3Ze1Nff pNQnSoW3Z6V8rJREaddCnCboDLfRz9X3RdZ9TlP/fddf5ud1GfOfLxIhK8U2h7/Ucm90R+R1DaQ 4CUJGS0vb2eeM7lpurxDXZH4EF/O7F46/dfaNlzPJkIG+dcO/nN+lbE6UrKqdN1E9FydI/xOBPf VBA X-Received: by 2002:a05:600c:c086:b0:48a:563c:c8c5 with SMTP id 5b1f17b1804b1-48fe60eabddmr207018885e9.8.1779175480245; Tue, 19 May 2026 00:24:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1d4b:274c:94d:a69f? ([2a01:e0a:106d:1080:1d4b:274c:94d:a69f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48feaa2c96csm102486505e9.2.2026.05.19.00.24.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 00:24:39 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 09:24:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 03/13] drm/meson: dw-hdmi: Call dw_hdmi_remove() consistently To: Jonas Karlman , Kevin Hilman , Heiko Stuebner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerome Brunet , Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org References: <20260518194744.2483580-1-jonas@kwiboo.se> <20260518194744.2483580-4-jonas@kwiboo.se> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260518194744.2483580-4-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/18/26 21:47, Jonas Karlman wrote: > dw-hdmi export two similar pair of functions to probe()/remove() and > bind()/unbind(), update to use dw_hdmi_remove() for consistency. > > dw_hdmi_probe() will drm_bridge_add() the dw-hdmi bridge, so it is > expected that of_drm_find_and_get_bridge() always return the dw-hdmi > bridge. Regardless, validate that the dw-hdmi can be found for > consistent error handling. > > Also always ensure the IRQ handler and bridge is released before > dw_hdmi_remove() is called. > > Signed-off-by: Jonas Karlman > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index eafe7daf6ff1..9aafdc768f2b 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -775,10 +775,17 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > platform_set_drvdata(pdev, meson_dw_hdmi); > > meson_dw_hdmi->hdmi = dw_hdmi_probe(pdev, &meson_dw_hdmi->dw_plat_data); > - if (IS_ERR(meson_dw_hdmi->hdmi)) > + if (IS_ERR(meson_dw_hdmi->hdmi)) { > + devm_free_irq(dev, irq, meson_dw_hdmi); > return PTR_ERR(meson_dw_hdmi->hdmi); > + } > > meson_dw_hdmi->bridge = of_drm_find_and_get_bridge(pdev->dev.of_node); > + if (!meson_dw_hdmi->bridge) { > + devm_free_irq(dev, irq, meson_dw_hdmi); > + dw_hdmi_remove(meson_dw_hdmi->hdmi); > + return -ENODEV; > + } > > DRM_DEBUG_DRIVER("HDMI controller initialized\n"); > > @@ -793,8 +800,8 @@ static void meson_dw_hdmi_unbind(struct device *dev, struct device *master, > int irq = platform_get_irq(pdev, 0); > > devm_free_irq(dev, irq, meson_dw_hdmi); > - dw_hdmi_unbind(meson_dw_hdmi->hdmi); > drm_bridge_put(meson_dw_hdmi->bridge); > + dw_hdmi_remove(meson_dw_hdmi->hdmi); > } > > static const struct component_ops meson_dw_hdmi_ops = { Reviewed-by: Neil Armstrong Thanks, Neil