From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755501AbYIKDSq (ORCPT ); Wed, 10 Sep 2008 23:18:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753669AbYIKDSO (ORCPT ); Wed, 10 Sep 2008 23:18:14 -0400 Received: from mail.windriver.com ([147.11.1.11]:37661 "EHLO mail.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753490AbYIKDSM (ORCPT ); Wed, 10 Sep 2008 23:18:12 -0400 From: Kevin Hao To: ak@linux.intel.com, astarikovskiy@suse.de, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: [PATCH 2/2] fix acpi ec set GPE storm flag bug Date: Thu, 11 Sep 2008 11:17:45 +0800 Message-Id: X-Mailer: git-send-email 1.5.6.2.220.g44701 In-Reply-To: References: <1221103065-9123-1-git-send-email-kexin.hao@windriver.com> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The intent of the code was clear, however the missing braces meant that EC_FLAGS_GPE_STORM was incorrectly being set all the time Signed-off-by: Kevin Hao --- drivers/acpi/ec.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 0c65e82..d8f273d 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -268,9 +268,10 @@ end: /* it is safe to enable GPE outside of transaction */ acpi_enable_gpe(NULL, ec->gpe, ACPI_NOT_ISR); } else if (test_bit(EC_FLAGS_GPE_MODE, &ec->flags) && - atomic_read(&ec->irq_count) > ACPI_EC_STORM_THRESHOLD) + atomic_read(&ec->irq_count) > ACPI_EC_STORM_THRESHOLD) { pr_debug(PREFIX "GPE storm detected\n"); set_bit(EC_FLAGS_GPE_STORM, &ec->flags); + } return 0; } -- 1.5.6.2.220.g44701