From: Dave Hansen <dave.hansen@intel.com>
To: Jun Miao <jun.miao@intel.com>,
kirill.shutemov@linux.intel.com, dave.hansen@linux.intel.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: x86@kernel.org, linux-coco@lists.linux.dev,
linux-kernel@vger.kernel.org, fan.du.com@web.codeaurora.org,
zhiquan1.li@intel.com
Subject: Re: [V2 PATCH] x86/tdx: add VIRT_CPUID2 virtualization if REDUCE_VE was not successful
Date: Tue, 29 Apr 2025 07:50:13 -0700 [thread overview]
Message-ID: <b138cb84-3a34-40b3-a23d-6ff3708dae6b@intel.com> (raw)
In-Reply-To: <20250429143114.1724280-2-jun.miao@intel.com>
On 4/29/25 07:31, Jun Miao wrote:
> REDUCE_VE can only be enabled if x2APIC_ID has been properly configured
> with unique values for each VCPU. Check if VMM has provided an activated
> topology configuration first as it is the prerequisite of REDUCE_VE and
> ENUM_TOPOLOGY, so move it to reduce_unnecessary_ve(). The function
> enable_cpu_topology_enumeration() was very little and can be
> integrated into reduce_unnecessary_ve().
Isn't this just working around VMM bugs? Shouldn't we just panic as
quickly as possible so the VMM config gets fixed rather than adding kludges?
next prev parent reply other threads:[~2025-04-29 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-29 14:31 [V2 PATCH 0/1][Bug Report] and Fix TDX cpuid0x2 #VE causing segment Jun Miao
2025-04-29 14:31 ` [V2 PATCH] x86/tdx: add VIRT_CPUID2 virtualization if REDUCE_VE was not successful Jun Miao
2025-04-29 14:50 ` Dave Hansen [this message]
2025-04-30 2:15 ` Zhiquan Li
2025-04-30 9:33 ` Kirill A. Shutemov
2025-04-30 11:10 ` Miao, Jun
2025-04-30 13:54 ` Kirill A. Shutemov
2025-04-30 14:39 ` Miao, Jun
2025-04-30 13:44 ` Dave Hansen
2025-04-30 15:09 ` Zhiquan Li
2025-04-30 15:02 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b138cb84-3a34-40b3-a23d-6ff3708dae6b@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fan.du.com@web.codeaurora.org \
--cc=jun.miao@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhiquan1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®