From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbdK1SQc (ORCPT ); Tue, 28 Nov 2017 13:16:32 -0500 Received: from mail-eopbgr10135.outbound.protection.outlook.com ([40.107.1.135]:54688 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752206AbdK1SQa (ORCPT ); Tue, 28 Nov 2017 13:16:30 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tommi.t.rantala@nokia.com; Subject: Re: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv() To: David Miller Cc: jon.maloy@ericsson.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20171128125315.25334-1-tommi.t.rantala@nokia.com> <20171128.095837.899409439582426451.davem@davemloft.net> From: Tommi Rantala Message-ID: Date: Tue, 28 Nov 2017 20:16:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171128.095837.899409439582426451.davem@davemloft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [188.238.177.131] X-ClientProxiedBy: AM5PR0402CA0024.eurprd04.prod.outlook.com (2603:10a6:203:90::34) To DB5PR07MB1320.eurprd07.prod.outlook.com (2a01:111:e400:599b::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c56e668f-154f-471a-09f0-08d5368c23ad X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603258);SRVR:DB5PR07MB1320; X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1320;3:cXdChQZDRig8vU96WC/pGQ52PJZm1oWXT89eKrEvgxsRjpQ0k5iuUk8GbhDGqRyYqRVyNqGv4f5l96laodqKmgnnw0FgLuraWXnmAQo5n3mIzmFFBgYUHfFUnaBFEUTATM1VftXD6lTR5pGUskTR20r2VU1Dio6Avx9qsQWQQ7Eg1qrkVq5AK3kLsn5be8mv9iVt9k1owwCr2SqECC/3xBZ09U3vohc2FrJc9oKOOpMXPbftd3I9qOZyHWJDASjo;25:z/amdYiTRiwSDfirnWqaSYJtPs9lEzlqOusy8kS2czSR9P3J2FBcKocX4QYer2baN3PS+K+LJDvTa25xLytFldVhnft/G0DgsklFBfTkf7ep/vNwQi2jvy1ppt4uNCXKqfsduUAtEXE/k+GBHacplg9mvCn0S7XZicwHJENDzE4VY+N+hMMYsxyNrjqErAuvF6ztaEdGJclxuXPfvgwXGy8O8DOkho7weJ78rnLb159AxFrSbl5hcjARk1V+k9qwiOimyz2OhDRlb3UH4qxTdqmGdHbFamMu9VT61ib2XocInOCUbUCBsq7HLdNtH1jyZf+RXRGEsZ7/9pTlU5sbGQ==;31:GD+AQkQCYUCqomBIkQ8nZVaz0MBGgJRKIh2RzUBrSYmtjHxFRk2d23xdcr5WL938izxAMONMPw4kWG1Xwd/AK22kcDIqMY9r0+2TbIZ6+kw1akHml/SVALvnpJyeYGg+dgfdme40HPJSoAerXxx3oerU36mGP/qhnBadrHuMOhOUAIVG+mobf++QkvxMoWJDRFjJ+4Ll7LLk32Y7KsRsmgnHC6JjOV60+BtslHGGAJc= X-MS-TrafficTypeDiagnostic: DB5PR07MB1320: X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1320;20:1B4wN+JRnjabI6ZwolYlEOiz6wel2FEUih7OvUrGLyIQr3z7H4S69E5TFrs8xoIplPDzvfPEfkMw7ghzMnhggZJLj74iFvogXI5Vakn5F3UUuusg4qJ1Z4LTpWy/hXCkiLWaOHv3Cgc5aDtH4jyyrWlsCLPFCRvEigFlxwzvrZpM5cRWFGaRw7RK8tDvDHOfHahrzhOB1JGnNB3rgrMh/TsOO8HQaI/KXOogAhs7K6LafFizvBMgtnxsH7gpHVI+Qx3ahEJwfe/ZERkoe1XfgWPLZ+dfvfShEeY8ZSe+wXAWXs0jhZz7tqX8GGfBso8fQtW4USruik1D0XyhSFXUHKQgx/Sly/wZLggXgvGWMrZl/zOOVlW3C/yIVWOU10mJCvdiV8NNlWLSPEY65MFdZetAmdQtUJh/uk6ohDhPiikPrlfcPz8gjZxvS85dJG9QOUxqwyZAiRVOpWTz279P2kWTmVOUPnxrabrzDqCmPnLrSM9IIb7U/4jOwSzxpzl4;4:w/TaGZ3hSRf6aWEwQ/9YzLvHRKD1akdc1626a1fAXSMKLCSYj4NmIKR/uh29MZa4fPhqBwK5JLLHStcHKhoaTiCVunclZbarUMwlS3QA5/ehXq5XdZ20qfNewSQ0sy/iYQV7Tm2KP220zsMzQFVz7tK2TUanducI+hl9X4Gu6XSGY/tx7fH3vGi3DUbOcpxe/wYCC6uqrfooIZZT68qhTj0GN76NI2B7kOHH8Mrc6EbIpthKNWH0uQHOuvy3eG32qq9TMmLl21Ywp4szHzXymLIKhnHklvDBxmtzdf5PfCpSNX2rzCckPxyrq4cP7g3C X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(82608151540597); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(3231022)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(6072148)(201708071742011);SRVR:DB5PR07MB1320;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:DB5PR07MB1320; X-Forefront-PRVS: 0505147DDB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(376002)(346002)(39860400002)(366004)(199003)(189002)(51914003)(24454002)(77096006)(6486002)(6116002)(76176999)(101416001)(106356001)(229853002)(6666003)(5660300001)(33646002)(50986999)(66066001)(65956001)(65806001)(189998001)(31686004)(97736004)(54356999)(2950100002)(36756003)(2906002)(3846002)(47776003)(8936002)(230700001)(58126008)(6916009)(105586002)(68736007)(316002)(65826007)(53936002)(7736002)(81166006)(86362001)(25786009)(81156014)(52116002)(53546010)(16526018)(4326008)(478600001)(305945005)(64126003)(2486003)(52146003)(117156002)(8676002)(31696002)(23676004)(83506002)(50466002)(6246003)(67846002)(16576012);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR07MB1320;H:[192.168.8.101];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA3TUIxMzIwOzIzOlVPY3pWOXpRN2s5UXZucVRVL0JrQWs1bXpk?= =?utf-8?B?Vng5WmU2N2pPSVljRUlDWGxWcU1ycjRETEJwU2VhYThMcWhwVGpjelBNYWp5?= =?utf-8?B?MmdhWlIzWS95NDlEZXlFMkszeFV2ek5UWm5GVm5FbUNGZlFYbFVjUERzQXh1?= =?utf-8?B?SHVRaWt4Zkk0NVlab0hzaTJjZk5JQjhhbFZtWFh2cXdJYUtjdmlpbXNPbkNs?= =?utf-8?B?ejBGRFBWRGV2NkFVdTVHNlFaWXpiT1pWYUZPaXF3ZGhzbnNUWGZ0WFBBWTJG?= =?utf-8?B?U005UEZwbU8zZUJhSHhmR2dYcWFHMVlUY2hhaEgzVHpLN3NOdlppZ2dWZUpN?= =?utf-8?B?Q3g1Vm5Ua2xIWW1uYUY1MzM0ZmJrcS9nQVZ1T3ZTV1phNnlHcnM5ZW5kL096?= =?utf-8?B?ZWRNVG94VFVnZWUxZHIybTVYV0U1bHZwWGlUT2Y5QVNyRGpDWUZQZHJTM2pC?= =?utf-8?B?bURrdFpsdityREV6eWE2dWFnRlhkUW9IVFB3cHZLSHlGRDZQQnhlajJwNnNC?= =?utf-8?B?MXV4UmN0SXlrOHFqYUl5aEhFeFFtNlQyY09WcVhKUXJwbk9SdytGZ3lva1Jn?= =?utf-8?B?TVR6RTlJa0g5K3pRSExTKzRlM25Ed0ZGOHVCMTBrQzZiZS9meDIxS0tVYy9R?= =?utf-8?B?dWFoYUtETGUwd0ptNlNqVGdIN1paSTJiSnJ4bnF0VDNOMXdlRHg4NndBQmMz?= =?utf-8?B?Ulo1SWlETkhTeHUxZDVrQ1hYeC9oN2wraTExc2lFOEorbE9oNGNLaEt5TVdI?= =?utf-8?B?eXR1TytJQ1E0R2JQRVlYaDlLcEVDVDdZUUppcjBqaGdPSWF5b3ZzQks1ejRT?= =?utf-8?B?bk1WZzlreHFCVTYzR2xEbTIxN01JR2hiN3dSbzh4b1N2MDBNUmc4U1FGSncv?= =?utf-8?B?RWJzcGluNkhySmFjaUl5SHQ0Mzg4Mzd2OWlXeTJHMi9ZandnQ2ROLzNBN0Z0?= =?utf-8?B?aVVDVmRzZU1JOGRVbjBJRDB5TjltMWxmZ2JaZWFzZjVtdG51RlFhTCtSV3Nk?= =?utf-8?B?QW8waUhZd0Q0Q0dTZlB6UG1QYWE2WC9yQzRUSkhiNUs3UWdDNzIrdG9qY1Ni?= =?utf-8?B?VlNqNElBVW42eGFKNFd5STlCMXdDeGllYkxpd2xBbE42NzFlWlB6K3psUVhm?= =?utf-8?B?Zm1FMnRYUGFnSy9MU1c5MWlINVFvQndPc25nZ2ZkOVpSeEtGVkFsRUtPa1o3?= =?utf-8?B?T3ZnZkR6bDROL2JpYW11RGM5ME1wUUNxai9Xc2xBdDBkVkF1dmJOT0ZlTm1k?= =?utf-8?B?MXJUZDc5QUFPeUkvVnpqazdEcUJ4VVhJNWhmcExsdmhsRTdxV0pKbFNUZVVz?= =?utf-8?B?T3BMSHYydXJ5M3M2YnMyOVFZUEdLb2MxZG5OSGNIOXQzVDVzU05mMm9kV3Jy?= =?utf-8?B?K2gzMnJQYTlzNVdyKy9IZGJjTFREMFd5clp2RUlJN2NpL3FXNlRNdldJYWIx?= =?utf-8?B?QjhXNjJ4UXVhNGNNZGtwL2cyV2RHQXZTcE9uS1FQK2swTnhmUFBZVExJdVp5?= =?utf-8?B?UVAzRHk1MVBncDd5SWpucnNyenBzVTFod0hwd0Rwand6UGxsQ0RXWVlVZGs2?= =?utf-8?B?djgwU2tDbURrczlHc3BGVDMvTGk3VGlzV0pYT1Faa3hqMDlEd1ZqcytRQnZn?= =?utf-8?B?WW9zUi9FbUZnTlBzbCsydm9OczEwNUJGNm94L2VlaGJ6UEJOM3h5NlFieTdW?= =?utf-8?B?Q01DTk04WmlvL1V5bGViazRSeHBsZG9MaTJ0Y01kbnBMTHg3Q2p0VXdnZW1l?= =?utf-8?B?Z0VDYkNTbFlQTlJNQ0t2U3ptN2lUckg1UzNidG1Yb3RPVXU0ZXNGUE1zRzhK?= =?utf-8?B?NERLbXpHdDk1V0VCSUdwWmJUb0pXanAwbHZaaVRNdFpXS1EwNnJDYTdIa3I3?= =?utf-8?B?WTFxTUd1Qmk3Nkw4VWRxV1pzRjEyL1dEbFNTbmR5WmNXcERuMEM2Ujh5a0NX?= =?utf-8?B?U2hrVlJhUW5WU0ZZQlh6OUJySXltMVQvbGRyc1doeWlVVUY1ZlA4cjNYRzcw?= =?utf-8?B?Ni9FL0tXTjQrUk05UURmRzd0cVFuZDdlS2k0QT09?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR07MB1320;6:g+3EtY4dCAyw1wp5ieKV1ae9/S9+bGWpnDFoaPGzm3N1gyp1pm5FLIsYFRJG//+WWz3Y2p06oc2UxTed/dBaRsvAVsW93mGcpCW8VmtS+izB8eUbMYCxUuosch/Q1fyzX/fbyf1Z6nU7KWWYxlJjwETKmVP+sWGAM0Jl+hRe+c8wfoG3T3zwrFqjyc3dJwDkI4oMX5UiBDOeVzLoTM7AWsWueFscbRhtTFu+Q0P+fohZa058Pg6iYz4TUWZsswf2Uz54wxWV/xALinvsarG6WMxguvLfOvnAp7aMU7jcgSVVIghu/duMbjGwWn6T4jgzSpykGgy94Ab71BGoR+Akw2okMpNG3sSJt0lBAd4d+q8=;5:zQ4+RR3LDffTBpA7VmuMewyfQHiKX6rQLAHn6Al18gPaGt3ldVz2+k3d4ezkOLhdjepcg9lRUQwk52nfXa8ZZaQQXqzw03AtCBJ22XAl+5KHbNxiaQ3/oumL1dLAs/rMFQn2qw1y0+uWxF9vLJvJjVMNbLGJ/Coa1WMXLgdLAgM=;24:EU5hzwsxOawOewgkp2V1t/Z/CEQO1JwHr6eG9BConULnxovT2bh9x3YTrICpj6MQhzQKgg2TZEtTDwSBNM8BEQvvFkbGlppVzYNM75mkJ4E=;7:R8VWH+uYrhAGVdQshmk+8btE0Atj3hJ0HucjVyygvEflWpNCGz5PV02bigttwFGuDI4ctGGgMmAIoORflyVR78iFqCVZ/7Cqiu9nRkkQ+6fIitzTEuS/BVDZON9q4Vhr0v53aTRgIt6ITrCNJBOLbJOh9/MpLxVJhgWMK03HDZzjWdI8SZmzO70L8kA3WIuKzRStdJsjf0Co6DwtyD1WPr3ff0ogpBtXkModu2zZ1r4ixEC+gyLH+QXT2R31a7+a SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 18:16:25.6375 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c56e668f-154f-471a-09f0-08d5368c23ad X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR07MB1320 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.11.2017 16:58, David Miller wrote: > From: Tommi Rantala > Date: Tue, 28 Nov 2017 14:53:15 +0200 > >> - >> - if (unlikely(msg_user(hdr) == LINK_CONFIG)) { >> - err = tipc_udp_rcast_disc(b, skb); >> - if (err) >> - goto rcu_out; >> + } else { >> + if (unlikely(b && msg_user(hdr) == LINK_CONFIG)) >> + tipc_udp_rcast_disc(b, skb); >> + kfree_skb(skb); >> } > > Either put the 'err' propagation back or clearly explain in your > commit log message why this part of the change if absolutely essential > for this bug fix. > > Thank you. > Thanks for the feedback. I'll post patch v2 soon. -Tommi