From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1396FC4332F for ; Fri, 18 Nov 2022 15:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242192AbiKRPAp (ORCPT ); Fri, 18 Nov 2022 10:00:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242131AbiKRPA1 (ORCPT ); Fri, 18 Nov 2022 10:00:27 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38D269C7BE for ; Fri, 18 Nov 2022 06:57:39 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id z24so7087441ljn.4 for ; Fri, 18 Nov 2022 06:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ngv5gxBO7Ianat52oueLrPYqURLVbai2GDjDWBWPbzg=; b=EROklCgzykSqhFNVyDi4+gpVhCwfP6B7mI+CUDZF1U/wuFkZa3Cf5/0PPw+YjSLMT4 hsBip0klea3c0Y/uRLReKIQHK2I/YveobyeZMW2Eef00tDR4+FJJ1yfaVx9MnnhCzfjk cCvE8lbIwMNLLJREQo+vrTQRIDwYL4FPJ1AC23pg4kZf3hpwHGTvYjgCi+FwFicVPYVl OUZpEIL5hmWoBdLHZ0v2sg6ctc51ghuX779Q4OPfaeKoeVTOzWghwn2NDM9owNC40pGR gzSD7t+CX0ZNHtB52/AtIDFIqTrbH06XHLHVFXx/jQn82+R43nQ53cmvHx/KnGWr28zv PfEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ngv5gxBO7Ianat52oueLrPYqURLVbai2GDjDWBWPbzg=; b=nVq3MhQGZ9aSXiv+6M7RzgZ4vFz5apj4d3MenNsvHGBUsIRkWeFEdvEPkJl+5yYvTC 7m3UaWZnbqnFIL6mjIlSbGdTtnHyZOfn4sMuE/cg6sr+48rFj0opsd/n0Tein4s34zQK cJbmbcrTpNDk2ET9tpMAe2Myqnwcz3UEfKNL/AKjcWUC0fN4iawoE8FbIAR2cQPm9tLC 3vXISMUiZ6lz2X0puUqjtOrxaZrYyTik8dayIAKiYojx8zAJ1rUYviTJ5GcptKQoHCaA /AfP5o5RVcOGaR3dWLct6dLkIVLJAstqPp5f+ViVKQcRh0YrJ+N1KzzcOSlZNqmdwawu 49Ng== X-Gm-Message-State: ANoB5pki5tMieqfVthqgiTeHOVbYQKfQjGpwRgmcfBGnwxYkqrWpInP0 Nvl5luc+v+n67PqN/VeWidHyGg== X-Google-Smtp-Source: AA0mqf4vIPsBBLJFJHTlqjhJ4CFdPwgqhejw4qFFRvVxAexWCQHYq1Ia/7slA+muOzdbuZsvy/yVog== X-Received: by 2002:a05:651c:12ca:b0:277:a9d:9355 with SMTP id 10-20020a05651c12ca00b002770a9d9355mr2409196lje.102.1668783457528; Fri, 18 Nov 2022 06:57:37 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t23-20020ac243b7000000b004b490427bf2sm691531lfl.66.2022.11.18.06.57.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 06:57:37 -0800 (PST) Message-ID: Date: Fri, 18 Nov 2022 15:57:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 10/12] dt-bindings: mmc: convert amlogic,meson-gx.txt to dt-schema Content-Language: en-US To: Neil Armstrong , Jakub Kicinski , Wim Van Sebroeck , Srinivas Kandagatla , Rob Herring , Andrew Lunn , Alessandro Zummo , Eric Dumazet , Bjorn Helgaas , Kevin Hilman , Ulf Hansson , Heiner Kallweit , Vinod Koul , Russell King , Thomas Gleixner , Kishon Vijay Abraham I , Guenter Roeck , Krzysztof Kozlowski , Martin Blumenstingl , Alexandre Belloni , Daniel Lezcano , Jerome Brunet , Paolo Abeni , Mauro Carvalho Chehab , "David S. Miller" Cc: linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-rtc@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org References: <20221117-b4-amlogic-bindings-convert-v1-0-3f025599b968@linaro.org> <20221117-b4-amlogic-bindings-convert-v1-10-3f025599b968@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221117-b4-amlogic-bindings-convert-v1-10-3f025599b968@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/11/2022 15:33, Neil Armstrong wrote: > Convert the Amlogic SD / eMMC controller for S905/GXBB family SoCs > to dt-schema. > > Signed-off-by: Neil Armstrong > --- > .../bindings/mmc/amlogic,meson-gx-mmc.yaml | 78 ++++++++++++++++++++++ > .../devicetree/bindings/mmc/amlogic,meson-gx.txt | 39 ----------- > 2 files changed, 78 insertions(+), 39 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml > new file mode 100644 > index 000000000000..c9545334fd99 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml > @@ -0,0 +1,78 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mmc/amlogic,meson-gx-mmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic SD / eMMC controller for S905/GXBB family SoCs > + > +description: > + The MMC 5.1 compliant host controller on Amlogic provides the > + interface for SD, eMMC and SDIO devices > + > +maintainers: > + - Neil Armstrong > + > +allOf: > + - $ref: mmc-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - enum: > + - amlogic,meson-gx-mmc > + - amlogic,meson-axg-mmc > + - items: > + - enum: > + - amlogic,meson-gxbb-mmc > + - amlogic,meson-gxl-mmc > + - amlogic,meson-gxm-mmc > + - const: amlogic,meson-gx-mmc Mention changes in commit msg. Anyway this might not match existing usage in DTS. At least amlogic,meson-gxbb-mmc has different order. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 3 > + > + clock-names: > + items: > + - const: core > + - const: clkin0 > + - const: clkin1 > + > + resets: > + maxItems: 1 > + > + amlogic,dram-access-quirk: > + type: boolean > + description: > + set when controller's internal DMA engine cannot access the DRAM memory, > + like on the G12A dedicated SDIO controller. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - resets > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + mmc@70000 { > + compatible = "amlogic,meson-gx-mmc"; > + reg = <0x70000 0x2000>; > + interrupts = ; > + clocks = <&clk_mmc>, <&xtal>, <&clk_div>; > + clock-names = "core", "clkin0", "clkin1"; > + pinctrl-0 = <&emm_pins>; > + resets = <&reset_mmc>; Use 4 spaces for example indentation. Best regards, Krzysztof