From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x2255hRHdu2ATJY2WQtDfu2ZPzF8qGeVivMPZ4QfqdGThIP4/0NpwuZMzvbGdc8wdhrwgTnyd ARC-Seal: i=1; a=rsa-sha256; t=1516847344; cv=none; d=google.com; s=arc-20160816; b=wJoxh41cOn0NTX+OOk4p9LIC+QLdpxlU83gpMANCcguw+3Y2mx4jVXq2Vj/g5MSYJA QPCJp9B34Bp6tEVdZoxoGb1z5vRlytKipJO8hEwcZqnT4+0mjS8kthIx5EYCdMEW6rd5 JfAOXXy90Il78yQx/jxcQgn66sHrnzlqJ02El6Mx23nv8OlFqFdtvnlYswWmeaie0d6D rdUVTB6DgsLV4OSITy0nR9X1/J3AJGsN0H6hfP61PkP2/KdCRLMG7+0w/j/T+/ibqZy4 ZcUH+Ioe5zKlMV5cRkbZLUp7H0mwJWpg4nMMZkZ+z2eUU/XhUOhl0Pir60/GblPL1UGB VojQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=W+h/mGUAIK2HDV6ZaRQaESTh9uj8auB4uuLmYW+JkwM=; b=I4+Iy5cKuWjOr2sCnIqDvdF53+NVeaCol3d8EszLTV5BXFSst+5NePOvbU7Keu6iAz gH0fMfZzeU64q3n8lABBNwCjoJxNcLr0GwzPFaxzb2IaSJZCboLd3OxBsb11X2b6Ji1g 4Vj12LH3Noz/AZ5jMHwejZgH8Mtna0uDtcJGVETTACuUkA0dphD1GQZ0F2MFArFhAOpf zhLAIvGPageIa8Zph4H0QMuMvaVRyiMLGMi3d1UL39lLksN5ZrLoVpp32o/FEIaTFuJE HvZLeiTEyvd+2t65h4d7+ajSS4/bigiApRMazu8qkYsXijfjuWrRawELXXCv2+osE04H qgHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of haiyue.wang@linux.intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=haiyue.wang@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of haiyue.wang@linux.intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=haiyue.wang@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,409,1511856000"; d="scan'208";a="24537126" Subject: Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI To: Greg KH Cc: joel@jms.id.au, arnd@arndb.de, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com References: <1516103552-19601-1-git-send-email-haiyue.wang@linux.intel.com> <20180123084457.GE21463@kroah.com> From: "Wang, Haiyue" Message-ID: Date: Thu, 25 Jan 2018 10:29:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180123084457.GE21463@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589749751524316291?= X-GMAIL-MSGID: =?utf-8?q?1590529721734996496?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-23 16:44, Greg KH wrote: > On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote: >> When PCH works under eSPI mode, the PMC (Power Management Controller) in >> PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in >> dead loop if no SUS_ACK assert. This is the basic requirement for the BMC >> works as eSPI slave. >> >> Also for the host power on / off actions, from BMC side, the following VW >> (Virtual Wire) messages are done in firmware: >> 1. SLAVE_BOOT_LOAD_DONE / SLAVE_BOOT_LOAD_STATUS >> 2. SUS_ACK >> 3. OOB_RESET_ACK >> 4. HOST_RESET_ACK >> >> Signed-off-by: Haiyue Wang >> --- >> .../devicetree/bindings/misc/aspeed-espi-slave.txt | 20 ++ >> Documentation/misc-devices/espi-slave.rst | 114 +++++++++ > DT files need to be split out into a separate patch so that the DT > maintainers can properly review them. > >> --- a/drivers/misc/Kconfig >> +++ b/drivers/misc/Kconfig >> @@ -471,6 +471,17 @@ config VEXPRESS_SYSCFG >> ARM Ltd. Versatile Express uses specialised platform configuration >> bus. System Configuration interface is one of the possible means >> of generating transactions on this bus. >> +config ASPEED_ESPI_SLAVE > You need a blank line above this one please. Fixed. >> + depends on ARCH_ASPEED || COMPILE_TEST >> + select REGMAP_MMIO > Select or depend? Before, I used "depends on". I was told to to change "select". I'm not sure which is more better by practice ? >> + tristate "Aspeed ast2500 eSPI slave device" >> + ---help--- >> + This allows host to access Baseboard Management Controller (BMC) over the >> + Enhanced Serial Peripheral Interface (eSPI) bus, which replaces the Low Pin >> + Count (LPC) bus. >> + >> + Its interface supports peripheral, virtual wire, out-of-band, and flash >> + sharing channels. > What is the module name? You means the --help-- description is not clear and specific ? >> >> config ASPEED_LPC_CTRL >> depends on (ARCH_ASPEED || COMPILE_TEST) && REGMAP && MFD_SYSCON >> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile >> index 5ca5f64..a1081f4 100644 >> --- a/drivers/misc/Makefile >> +++ b/drivers/misc/Makefile >> @@ -52,6 +52,7 @@ obj-$(CONFIG_GENWQE) += genwqe/ >> obj-$(CONFIG_ECHO) += echo/ >> obj-$(CONFIG_VEXPRESS_SYSCFG) += vexpress-syscfg.o >> obj-$(CONFIG_CXL_BASE) += cxl/ >> +obj-$(CONFIG_ASPEED_ESPI_SLAVE) += aspeed-espi-slave.o > Why no tab? Fixed, thanks. > thanks, > > greg k-h