From: Len Brown <lenb@kernel.org>
To: rjw@rjwysocki.net, linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: [PATCH 1/1] suspend: delete sys_sync()
Date: Fri, 8 May 2015 03:08:43 -0400 [thread overview]
Message-ID: <b1587e8b2c664632ecd0d9ad1a3e56733da76490.1431068823.git.len.brown@intel.com> (raw)
From: Len Brown <len.brown@intel.com>
Remove sys_sync() from the kernel's suspend flow.
sys_sync() is extremely expensive in some configurations,
and so the kernel should not force users to pay this cost
on every suspend.
The user-space utilities s2ram and s2disk choose to invoke sync() today.
A user can invoke suspend directly via /sys/power/state to skip that cost.
Signed-off-by: Len Brown <len.brown@intel.com>
---
kernel/power/suspend.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index b7d6b3a..6d237bb 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -473,12 +473,6 @@ static int enter_state(suspend_state_t state)
if (state == PM_SUSPEND_FREEZE)
freeze_begin();
- trace_suspend_resume(TPS("sync_filesystems"), 0, true);
- printk(KERN_INFO "PM: Syncing filesystems ... ");
- sys_sync();
- printk("done.\n");
- trace_suspend_resume(TPS("sync_filesystems"), 0, false);
-
pr_debug("PM: Preparing system for %s sleep\n", pm_states[state]);
error = suspend_prepare(state);
if (error)
--
2.4.0.rc1
next reply other threads:[~2015-05-08 7:08 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 7:08 Len Brown [this message]
2015-05-08 14:34 ` Alan Stern
2015-05-08 16:36 ` Len Brown
2015-05-08 19:13 ` One Thousand Gnomes
2015-05-08 19:32 ` Len Brown
2015-05-08 19:52 ` One Thousand Gnomes
2015-05-08 20:39 ` Rafael J. Wysocki
2015-05-08 20:30 ` Rafael J. Wysocki
2015-05-09 19:59 ` Alan Stern
2015-05-09 20:25 ` Henrique de Moraes Holschuh
2015-05-11 20:34 ` Len Brown
2015-05-12 6:11 ` Oliver Neukum
2015-06-25 17:11 ` Henrique de Moraes Holschuh
2015-06-30 20:04 ` Len Brown
2015-07-01 12:21 ` Henrique de Moraes Holschuh
2015-07-02 3:07 ` Len Brown
2015-07-03 1:42 ` Dave Chinner
2015-07-04 1:03 ` Rafael J. Wysocki
2015-07-04 8:50 ` Geert Uytterhoeven
2015-07-05 23:25 ` Rafael J. Wysocki
2015-07-04 14:19 ` Alan Stern
2015-07-05 23:28 ` Rafael J. Wysocki
2015-07-06 11:06 ` Pavel Machek
2015-07-06 13:59 ` Rafael J. Wysocki
2015-07-07 10:25 ` Pavel Machek
2015-07-07 12:22 ` Rafael J. Wysocki
2015-07-06 0:06 ` Dave Chinner
2015-07-06 11:11 ` Pavel Machek
2015-07-06 13:52 ` Rafael J. Wysocki
2015-07-07 1:17 ` Dave Chinner
2015-07-07 12:14 ` Rafael J. Wysocki
2015-07-07 13:16 ` Oliver Neukum
2015-07-07 14:32 ` Rafael J. Wysocki
2015-07-07 14:38 ` Oliver Neukum
2015-07-07 15:03 ` Alan Stern
2015-07-07 22:20 ` Rafael J. Wysocki
2015-07-08 11:20 ` Pavel Machek
2015-07-08 14:40 ` Alan Stern
2015-07-08 22:04 ` Rafael J. Wysocki
2015-07-07 22:11 ` Rafael J. Wysocki
2015-07-08 7:51 ` Oliver Neukum
2015-07-08 22:03 ` Rafael J. Wysocki
2015-07-09 7:32 ` Oliver Neukum
2015-07-09 23:22 ` Rafael J. Wysocki
2015-08-04 19:54 ` Pavel Machek
2015-07-08 11:17 ` Pavel Machek
2015-07-07 13:42 ` Takashi Iwai
2015-07-06 10:15 ` Ming Lei
2015-07-06 10:03 ` Pavel Machek
2015-05-11 1:44 ` Dave Chinner
2015-05-11 20:22 ` Len Brown
2015-05-12 22:34 ` Dave Chinner
2015-05-13 23:22 ` NeilBrown
2015-05-14 23:54 ` Dave Chinner
2015-05-15 0:34 ` Rafael J. Wysocki
2015-05-15 0:40 ` Ming Lei
2015-05-15 0:59 ` Rafael J. Wysocki
2015-05-15 5:13 ` Ming Lei
2015-05-15 10:35 ` One Thousand Gnomes
2015-05-18 1:57 ` NeilBrown
[not found] ` <CAJvTdKn_0EZ0ZuqO2e4+ExD8kFWcy78fse4zHr3uFZODOroXEg@mail.gmail.com>
2015-06-19 1:09 ` Dave Chinner
2015-06-19 2:35 ` Len Brown
2015-06-19 4:31 ` Dave Chinner
2015-06-19 6:34 ` Len Brown
2015-06-19 23:07 ` Dave Chinner
2015-06-20 5:26 ` Len Brown
2015-05-15 1:04 ` NeilBrown
2015-05-15 14:20 ` Alan Stern
2015-05-15 14:32 ` Alan Stern
2015-05-15 14:19 ` Alan Stern
2015-07-06 10:07 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1587e8b2c664632ecd0d9ad1a3e56733da76490.1431068823.git.len.brown@intel.com \
--to=lenb@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®