From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E20C77B7E for ; Tue, 18 Apr 2023 17:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232052AbjDRRKf (ORCPT ); Tue, 18 Apr 2023 13:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232163AbjDRRKN (ORCPT ); Tue, 18 Apr 2023 13:10:13 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 518F54486 for ; Tue, 18 Apr 2023 10:10:11 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id kt6so36875227ejb.0 for ; Tue, 18 Apr 2023 10:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681837810; x=1684429810; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+WHlqIBM+MCUF6hZ83TONgjkCjEOxfdRoRjzJHTAirE=; b=IiitgDIk9VE8JzLsktssHGI0FW2etCrF6Wg7u2A2flpDQCDbDQyzY8jZGt3Zp3asGC O6/94VNsfP9I1oUzxU4STP2R+/WnlEErhhpbJpvt9MqQf/4wq2F9swlKk2R84FmVBbhg DCtFjngcc8O4/vht+yYOSceeC0YZBGAHVTq8pm2pqwlxEdOMoPdKIpgTwmz9EC1hw27/ +0hcCRfeb3XW+sz+aon1fjKDaTsUvNZYrXhkJElu4Rt8NMvLPtfNI3EldH5XJ0lzfC19 P4wwd5uyZrxa8qJ9TfiqdRuy6vsDmf+U4Ju6OwzKwJXdGAdeND1My9Qg/A0dCpklbUB/ oalQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681837810; x=1684429810; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+WHlqIBM+MCUF6hZ83TONgjkCjEOxfdRoRjzJHTAirE=; b=NlKJ3RUIk5scLsNaeNAd7myBHjlN69QBfr2VSV+tR8l0fY4THuwGDyAZKZZS2QmsuB p1NXu4srUNT3IQ/4SyOpcc8Va1kdeDUt+ksCptdyMO1w97nbVp2cUTKllSFyt09BV4XG VlOva50zNPaitxfiRsDCvcqXHURm2bj0ap4OJ1i4O13ZzP1j4s17fhfJKRxCoIop8QSK 9prMHo5C5Lxq1dYXS8Pr+pGkpYNoQIKFQYRHo3kJa95MFyNh9muc67nnx2/T/jkItiE7 fyVDE0NZlFZKJcfLVogCmFlr55qhpMMRY67i7+GOVgbKn+BTWrtTN1KYMiavD/WqPInf ZiEQ== X-Gm-Message-State: AAQBX9c6a8CKTPD3qzoJHVdAKrIsLkvt4nMCRROovKKzhAiY5aMoGE5R HxAa/xSxbN9shPTOcHmP2he3DQ== X-Google-Smtp-Source: AKy350Z+V33GqZk1LMN4KjbXN+KpaCPlxtuNlAz3iwywFv/cQjcLqJa8BsHzHSvDzhIEVubog9OKjw== X-Received: by 2002:a17:906:80d4:b0:94f:247d:44d2 with SMTP id a20-20020a17090680d400b0094f247d44d2mr10380121ejx.5.1681837809689; Tue, 18 Apr 2023 10:10:09 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id fy1-20020a170906b7c100b0094e4b8816e0sm8207409ejb.217.2023.04.18.10.10.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 10:10:09 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 19:10:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v1 6/9] dt-bindings: hwmon: Add HPE GXP PSU Support Content-Language: en-US To: nick.hawkins@hpe.com, verdun@hpe.com, linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, jdelvare@suse.com, linux@roeck-us.net, linux@armlinux.org.uk, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230418152824.110823-1-nick.hawkins@hpe.com> <20230418152824.110823-7-nick.hawkins@hpe.com> From: Krzysztof Kozlowski In-Reply-To: <20230418152824.110823-7-nick.hawkins@hpe.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/04/2023 17:28, nick.hawkins@hpe.com wrote: > From: Nick Hawkins > > Provide i2c register information and CPLD register information to the > driver. > > Signed-off-by: Nick Hawkins > --- > .../bindings/hwmon/hpe,gxp-psu.yaml | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > new file mode 100644 > index 000000000000..60ca0f6ace46 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-psu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-psu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP psu controller > + > +maintainers: > + - Nicholas Hawkins > + > +properties: > + compatible: > + const: hpe,gxp-psu Missing blank line. > + interrupts: > + maxItems: 1 > + > + reg: > + maxItems: 1 All your bindings are written with different style... reg is second in your previous patchset, so what order did you choose here? > + > + hpe,sysreg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to the global status registers shared between each psu > + controller instance. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + Drop blank line. > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + psu@48 { > + compatible = "hpe,gxp-psu"; > + reg = <0x48>; Add also interrupts. Best regards, Krzysztof