From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA88C433DF for ; Wed, 8 Jul 2020 11:04:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51A1E2067D for ; Wed, 8 Jul 2020 11:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728753AbgGHLE5 (ORCPT ); Wed, 8 Jul 2020 07:04:57 -0400 Received: from smtprelay0058.hostedemail.com ([216.40.44.58]:52554 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728385AbgGHLEy (ORCPT ); Wed, 8 Jul 2020 07:04:54 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 69D20100E7B42; Wed, 8 Jul 2020 11:04:53 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: water41_2400efa26ebc X-Filterd-Recvd-Size: 3704 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA; Wed, 8 Jul 2020 11:04:51 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2] CodingStyle: Inclusive Terminology From: Joe Perches To: Dan Williams , Jonathan Corbet Cc: Randy Dunlap , Dave Airlie , Kees Cook , SeongJae Park , Olof Johansson , Chris Mason , Greg Kroah-Hartman , torvalds@linux-foundation.org, tech-board-discuss@lists.linuxfoundation.org, ksummit-discuss@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Date: Wed, 08 Jul 2020 04:04:50 -0700 In-Reply-To: <159419296487.2464622.863943877093636532.stgit@dwillia2-desk3.amr.corp.intel.com> References: <159419296487.2464622.863943877093636532.stgit@dwillia2-desk3.amr.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-07-08 at 00:23 -0700, Dan Williams wrote: > Linux maintains a coding-style and its own idiomatic set of terminology. > Update the style guidelines to recommend replacements for the terms > master/slave and blacklist/whitelist. > > Link: http://lore.kernel.org/r/159389297140.2210796.13590142254668787525.stgit@dwillia2-desk3.amr.corp.intel.com > Cc: Jonathan Corbet > Acked-by: Randy Dunlap > Acked-by: Dave Airlie > Acked-by: Kees Cook > Acked-by: SeongJae Park > Signed-off-by: Olof Johansson > Signed-off-by: Chris Mason > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Dan Williams > --- > Changes since v1 [1] > - Drop inclusive-terminology.rst, it is in the lore archives if the > arguments are needed for future debates, but otherwise no pressing > need to carry it in the tree (Linus, James) Where did Linus publicly state this was unnecessary? > diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst [] > @@ -319,6 +319,19 @@ If you are afraid to mix up your local variable names, you have another > problem, which is called the function-growth-hormone-imbalance syndrome. > See chapter 6 (Functions). > > +For symbol names, avoid introducing new usage of 'master/slave' (or > +'slave' independent of 'master') and 'blacklist/whitelist'. Recommended > +replacements for 'master/slave' are: 'main/{secondary,subordinate}', > +'primary/replica', '{initiator,requester}/{target,responder}', > +'host/{device,proxy}', or 'leader/{performer,follower}'. Recommended > +replacements for 'blacklist/whitelist' are: 'denylist/allowlist' or > +'blocklist/passlist'. Adding a reference to SeongJae Park's introduction of scripts/deprecated_terms.txt or the like might help make this list unnecessary if more terms are added. > +Exceptions for introducing new usage is to maintain a userspace ABI/API, > +or when updating code for an existing (as of 2020) hardware or protocol > +specification that mandates those terms. For new specifications > +translate specification usage of the terminology to the kernel coding > +standard where possible. I believe any existing code should not be changed, not just code that is required to be maintained for userspace.