From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 376A244C8C for ; Fri, 7 Jun 2024 21:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717797350; cv=none; b=lTfoJ/0zLrrD6Pg6p9Rs+msOjKb3T/vqrVq6UjYfprzv5MukdJfDR1lW+dP2aRaK6+4JpXHkrM+YE7utjPhc1WT8T/k6gkBXXQobe0QfruXncJTh0ZOlJKVrfSjycCi2HGu/KAjHG9h3RHPZY3Q+EA+++1uuudZ/XpT+u/XCEgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717797350; c=relaxed/simple; bh=fu3qda++pXB4FfaZskPLyTx3TuNkpVV3W3fBsFZGP60=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LkNvjhbCijM5KqV6r8tm8ZvNlUGHEi0iZvpRq6QW1lMtKzazMJVq3mOv330Y+e72TX7k9kNbmwYp+PBnL0kDfqESQzGrQrlkxHaPBvrq5tZMibVGJR0ey6/oQVtBZ0ODEmJ311Z5TCujQqQFHxKDGIn9Jhu9eCxU8bcI4qa3Zb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=h4xZNx/l; arc=none smtp.client-ip=209.85.166.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="h4xZNx/l" Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-374a69879b8so1621595ab.2 for ; Fri, 07 Jun 2024 14:55:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1717797348; x=1718402148; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4HcFR2Leo9TIWpo1ugxAr6wH2ocfu6VBXw5aRgto4uo=; b=h4xZNx/lGHpqYcAZl3+OO36re2sObjSy4EOP+tnDRu12o8IZ3VFFpMhRoQogP6lTPJ uz8OgY7YahuU8x8ze/AJevGbs6oX0bIRDn5ZfRuO5ckvMHvKDaURIMmRQja1uKU183K9 XYcQQCKdNoCfbr3ytR5L0Z3t19c7A81bpVO3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717797348; x=1718402148; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4HcFR2Leo9TIWpo1ugxAr6wH2ocfu6VBXw5aRgto4uo=; b=HkRhKaOWYImqY+9cNoAmIwmiSD08lIPj5ERbG0d2xlfUhfho1yRYEtyLc8/HNV9NCz rVgyQLpZZjpZDaR6e7u5A97HoLfJAbBc9pqbNl/0Zm+betQdCZi31+fXCoN200z+huUB X9AyRK+lwAB+bzsDm7vDXULLvEwUL6GFXmfsUAGOOhQrEENKgWO4MUwEGmz6jfECjylP Gjm857vXkc0JIcmv7o0Y7Qb6uEBSfWOMq2d0Vj94O5xOde8FRg/kM8XJxDcbP5YvmQdX +e8y5YJ7Iksu2CJDDa4LNDiXK1L2SpMzjYJsS5EHOlYWU0hLNiaTmvZLpQCzUHbAqwTl GeuA== X-Forwarded-Encrypted: i=1; AJvYcCXzbcKzk8mVHE33CE7XRzUGg7lRRjm5LxLOjy56BGZTceQVSJ/zgKnoacS+NMTmLvPvr/4HBMFlte6SCnEtW9L4xWDLfBedUFCI5eMD X-Gm-Message-State: AOJu0YzX1bi5zC2HprjMnaY+GZhL6FN5vslEElXCX02iGqLvmK/Vj10a 8liNtvg0Nf4US5my8sarH4ufGA2q+6/yWbHivsUuGjlTXzbAl7LgiWQvCGueDm8= X-Google-Smtp-Source: AGHT+IFsffHGIHPI2MTbTGp5eYP39jIX5DtbY1T1sgAo9afSQWM2t/LWskYhjGnvmeoAOmw6Wnp/dQ== X-Received: by 2002:a05:6602:2094:b0:7eb:3aa3:8b02 with SMTP id ca18e2360f4ac-7eb5724ac8fmr367981439f.2.1717797348146; Fri, 07 Jun 2024 14:55:48 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b7a2386dc6sm1048276173.85.2024.06.07.14.55.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 14:55:47 -0700 (PDT) Message-ID: Date: Fri, 7 Jun 2024 15:55:46 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] selftests/pidfd: Fix wrong expectation To: =?UTF-8?B?T2thbiBUw7xtw7xrbMO8?= , brauner@kernel.org Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Kees Cook , Shuah Khan References: <20240606180223.5527-1-okantumukluu@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240606180223.5527-1-okantumukluu@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/6/24 12:02, Okan Tümüklü wrote: > From: Mickaël Salaün > > Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), > which will be actually tested on the parent and child sides with a > following commit. > > Cc: Shuah Khan > Reviewed-by: Kees Cook > Reviewed-by: Christian Brauner > Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net > Signed-off-by: Mickaël Salaün FYI - This patch is already in the mainline. commit 821bc4a8fd2454ff6d719aae7cac93f60567fe65 Author: Mickaël Salaün Date: Sat May 11 19:14:42 2024 +0200 selftests/pidfd: Fix wrong expectation Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(), which will be actually tested on the parent and child sides with a following commit. Cc: Shuah Khan Reviewed-by: Kees Cook Reviewed-by: Christian Brauner Link: https://lore.kernel.org/r/20240511171445.904356-8-mic@digikod.net Signed-off-by: Mickaël Salaün thanks, -- Shuah