From: Hao Xu <haoxu@linux.alibaba.com>
To: Jens Axboe <axboe@kernel.dk>, Eric Dumazet <edumazet@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] About "io_uring: add more uring info to fdinfo for debug"
Date: Sat, 30 Oct 2021 01:58:53 +0800 [thread overview]
Message-ID: <b169a5b5-aa71-690a-f658-47dfe7a21785@linux.alibaba.com> (raw)
In-Reply-To: <7c6ec470-0985-2ee8-4cbd-1f9649c7b69c@kernel.dk>
在 2021/10/30 上午1:56, Jens Axboe 写道:
> On 10/29/21 11:54 AM, Hao Xu wrote:
>> Hi Jens,
>> I was thinking that print all the entries including the unused ones
>> would make the list very long(real product use hundreds or thousands
>> while there may be just several useful sqes). And that may be confused,
>> a example is: sq_array[0-999] = 0, we have only one sqe sqes[0] in use.
>> then we'll print sqe[0] 1000 times, though we can get to know the real
>> useful one by sq_head and tail info after calculation.
>> And if only print the useful ones, exposing the original counters will
>> make the loop condition a bit simpler than exposing the ring index(since
>> the original counters depend on natural overflow) though we cannot do
>> that now since realizing issues like what Eric reports.
>
> We can revisit in the merge window, I wrote up the pull requests for
> this branch (among others) already. The most important part was fixing
> the looping to appropriately cap it.
>
Gotcha
prev parent reply other threads:[~2021-10-29 17:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 21:24 Eric Dumazet
2021-10-28 21:40 ` Jens Axboe
2021-10-29 0:13 ` Jens Axboe
2021-10-29 0:43 ` Eric Dumazet
2021-10-29 12:40 ` Jens Axboe
2021-10-29 17:54 ` Hao Xu
2021-10-29 17:56 ` Jens Axboe
2021-10-29 17:58 ` Hao Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b169a5b5-aa71-690a-f658-47dfe7a21785@linux.alibaba.com \
--to=haoxu@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®