From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1CFC3612FB for ; Wed, 14 Jan 2026 07:28:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375714; cv=none; b=hmBn8PpKW67mAyCwPwBD6FCwSd3BKQcJufcdRckT4mPMsjNV7XdrlKdJhp3jqZB6YosC6zmew9TRoq2hy/6/x0LSSR5kyZjgGzL8OJpus54xbQF6egi/UVt+K6YVz98I6j0Y9ejpercUtoZtB3RfLNun35yft3H/Q50Dn0P5uZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768375714; c=relaxed/simple; bh=aDxtKzNEsVHqByOidgY/CPR7Hh79+kO4ibmjZJQIYxk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eCwjsJvXSu6RObUEF88L9B0CCWSmleO6eahTBe27+/k3D+/KozBUUjmv8+RwicPvj5EKrZXQhN+QDJe6T0Udyd7mrwqOjIZu+yOuQujMmfKT18RirXC0R5hnRKlk1h/HmGCHxw6vZdocJFcq/axZIwV2mItW65m6qFFASpIAFgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hFw7N+yR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HTat/mun; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hFw7N+yR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HTat/mun" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E66buw2140386 for ; Wed, 14 Jan 2026 07:28:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KdMG9WA+kJ7VqYbxQxfdg6qolJCk+4/maOFlurAClgg=; b=hFw7N+yRkHjxu+g/ 3URn+CzxOvP3v0Q+MBUanCZVI9eKOBF1UazHmnnOtSQAaJODueuzlsnpmi8d1iT/ 3klzaZ1vYYM/DbS48JYPjxIbZfJfbt12JQuj0WCMS0+I1/CNEe/GEqR4StfcU02E 2BKoe9eoLlKYP5GzxDGSmowClBun+5ASjJX9ZbD8Q5xZccC+LRo57cNG9SK2gubr zYwgaMeBvfmHxNpi5eWfDCTJVe0YKAqRiOX4tQT+C7HWjzpFpaYzKJ/bmO7rPrK9 4TQnamMPUyqUd7ep+cqp+dnWTrwviAIz6XAma9XhKLSjk+q8OP3pCNfPbsMKCNIL 3qdAog== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnm0duw9h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:28:27 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34c21341f56so16764548a91.2 for ; Tue, 13 Jan 2026 23:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768375706; x=1768980506; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KdMG9WA+kJ7VqYbxQxfdg6qolJCk+4/maOFlurAClgg=; b=HTat/munJNYRrkmd5jDHTkbzRF+YVzcJh2VJNwjAcqOQK233YyimXNnLnR//sBkyYk taL2swAumaJyspFaBwHhF4ecPU/mcU0cyFQk9vOMrXcHTHyAbEq0qvs6dcFmDE3TGMES FogEGNIIqvEu4SNSR1NO1PEVvT9gtlY+CyqjVOpW5mnO1aaO0+O9QoYJxtLuo2Av6fwh W2qsOL3DJdUrw40erC2/fUlL1QgnFlA7DMJOeCpYOzfqUIm6dd90K3zuZu4VuoxgigyB 6WIKmJHcFyk7U2L5WG0x2XxdqzxtVE4khcVMztEinRA2yLLIH2UIEdPVXZPn7VRYZ+KW DsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768375706; x=1768980506; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KdMG9WA+kJ7VqYbxQxfdg6qolJCk+4/maOFlurAClgg=; b=i1HebJ6ZROmPnuZZEEPLsXXVnFMYuLdWCsl+q9QFJM+ENpTGy8aRKhSl32LMjfzdQx r+2vQIczGjY1CNIj9+vlAAeji+g56lSkvOFzqM8ZHD7JofmxvTrM8+bd6H/0fVX5ELZ1 PDaTZjNCWIJE/FWrRqbe6okVuOa4GI8TW0T3XisVNW4T55elkj1mSXMTVwShWctxMH1B 0Cc+oC/uHy0UXvNAHrDUVashS2J3Wd6fE4QdSU1cLuSJSHeOKAYEEpWHmZeo7UiHgLLC QKCf4WuM+4oRPOuamPLMx/bz2uIEmrCNfyZJUmNVwRQ+SqDsCMhPy6yH8KBzZXBgSsvO /6Xw== X-Forwarded-Encrypted: i=1; AJvYcCUFL1Bsbd0W1vetJLY+DmfN1kIq/K/ogKvXprwQFRXW6s62oe8cHzj/22ZGh0C3UcbhvyEnpH2PJeT4mYo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8Sv6LVSREe2ERJOkWmRVZrojWTF5EiBjsqFooMgZ+z6RTQrB5 y/XF+qjfjiLOTrAItAFmTZyiOMxvDRUdbhBJvX9Fpn/vpHFUWF6VMFQGo5wRX2JKvUs5SMUi//3 3usnznP2vCAaQsk29zuSTFLNLxxXovQqrsL7AIN5+b9lOC5aCHWirfPfesh8dbL4m0bQ= X-Gm-Gg: AY/fxX7Albd0a2vH9lwQhneE2UiupyvI9Bk07Qe1LCjmeAbUT1pRRDnDyp9fxZqmKIG +sz6C4r3pAXvd7qbG55ai8euNjBWaZx93N8paox1uP6r9aKM9+jlAun2Hdi0Xdtcl96owVTJsKF +YkfmWVPsfBtBWtqdpqkKHLh0kz0WVE6RQL3OQuoFAn7pBSvuoZoVwnEswmmSoOrBserW7gs0qh KM2HO0ZxQxkDH0tB7BL2AJxlrQihCz0YHFDL+y6IEhS/4NSGKU/1Q41tOgKVQb1vf5SxQVCPWNl HAbA+4rbZheKMvARfSm6t0wW8ETltGAXXu8krLJDt2xieesaaV+fpLpJDfFFIklW5kYKH3xhov0 bxmWYoF9YXk7b+ts7uRzposWhLEl2JE4RmGyHEkv0Ensq X-Received: by 2002:a17:902:d4c5:b0:2a0:b02b:210c with SMTP id d9443c01a7336-2a599da501fmr16776695ad.1.1768375706086; Tue, 13 Jan 2026 23:28:26 -0800 (PST) X-Received: by 2002:a17:902:d4c5:b0:2a0:b02b:210c with SMTP id d9443c01a7336-2a599da501fmr16776485ad.1.1768375705647; Tue, 13 Jan 2026 23:28:25 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c3a560sm216788535ad.21.2026.01.13.23.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:28:25 -0800 (PST) Message-ID: Date: Wed, 14 Jan 2026 12:58:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 07/11] media: iris: don't specify bank_spreading in the source code Content-Language: en-US To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-7-4346a6ef07a9@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-7-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BYXVE7t2 c=1 sm=1 tr=0 ts=6967459b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=yL4243FK61EKG2Nsi2QA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 9U4rnX6Rdpv-8hQ4GfYSbBzfBJKn2FdY X-Proofpoint-GUID: 9U4rnX6Rdpv-8hQ4GfYSbBzfBJKn2FdY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NyBTYWx0ZWRfX79Xa6lmio50p p8NgDzkbp0sdroS4piGtIWvquyq8VXJUM6APcxjLqa78iij77GVxlHC01zpyCFKhHXCbDX/Ug4S Mc/eXMX/xJ1/hHtxmeHQNPuNGtgxa/n6mcxSBteUIvVpbLjB4q1u53197O6wxmAlA+Um8quGu97 HImBt0rCMxXYR3khRgXb4JqCyN/lb3ztMwLK7AA9dUhr7f0JrFJPKnjYkg+teMyMLv54xMX7P7E heay33wDlr66LzDxRXe/NiYGVmK1t+rK1K+MB014iKD4bQ0vddDKhClPumOIe+WveoRDeQ5OO2k wE8q8pJCx1Rh8YyxIu8bGl0CSBlNpgPRefdPZz2yLzNAC+k96d4yMjVgnyi6pbMwATH8HEU6zzV u2i3aOXwFTchyDvjbmcZBym4ovIp2jn7tPMYNwbu2P32D7YtKjQz2LkWTH7MhDbl1suRr8uLs+C uECHVdzdiNWyjOdeh7Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140057 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > The UBWC bank spreading is specified both in the Iris driver and in the > platform UBWC config. Use the platform UBWC configuration instead of > specifying it directly in the source. > > Reviewed-by: Konrad Dybcio > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 2 +- > drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - > drivers/media/platform/qcom/iris/iris_platform_gen2.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > index a880751107c7..9945c939cd29 100644 > --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c > @@ -199,7 +199,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade > &payload, > sizeof(u32)); > > - payload = core->iris_platform_data->ubwc_config->bank_spreading; > + payload = ubwc->ubwc_bank_spread; > iris_hfi_gen2_create_packet(hdr, > HFI_PROP_UBWC_BANK_SPREADING, > HFI_HOST_FLAGS_NONE, > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index 9f9ee67e4732..f99fcbb8fced 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -73,7 +73,6 @@ struct tz_cp_config { > > struct ubwc_config_data { > u32 max_channels; > - u32 bank_spreading; > }; > > struct platform_inst_caps { > diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > index 0f06066d814a..c967db452dec 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c > +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c > @@ -633,7 +633,6 @@ static const struct platform_clk_data sm8550_clk_table[] = { > > static struct ubwc_config_data ubwc_config_sm8550 = { > .max_channels = 8, > - .bank_spreading = 1, > }; > > static struct tz_cp_config tz_cp_config_sm8550 = { > Reviewed-by: Dikshita Agarwal Thanks, Dikshita