mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrei.Simion@microchip.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, Nicolas.Ferre@microchip.com,
	alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] ARM: dts: microchip: at91-sama5d34ek: Align the eeprom nodename
Date: Fri, 5 Jul 2024 11:45:20 +0200	[thread overview]
Message-ID: <b16d1ace-b113-47e2-9c48-7c89d122e2a9@kernel.org> (raw)
In-Reply-To: <aecc9240-8a19-47bf-b42a-e74690d8315f@microchip.com>

On 05/07/2024 11:31, Andrei.Simion@microchip.com wrote:
> On 05.07.2024 09:43, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 04/07/2024 17:14, Andrei Simion wrote:
>>> Align the eeprom nodename according to device tree specification
>>> and at24.yaml.
>>>
>>> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
>>
>> Squash.
>>
> 
> I will squash.
> 
>>> ---
>>>  arch/arm/boot/dts/microchip/sama5d34ek.dts | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/microchip/sama5d34ek.dts b/arch/arm/boot/dts/microchip/sama5d34ek.dts
>>> index bffd61397cb5..18943b873fff 100644
>>> --- a/arch/arm/boot/dts/microchip/sama5d34ek.dts
>>> +++ b/arch/arm/boot/dts/microchip/sama5d34ek.dts
>>> @@ -36,7 +36,7 @@ i2c0: i2c@f0014000 {
>>>                       i2c1: i2c@f0018000 {
>>>                               status = "okay";
>>>
>>> -                             24c256@50 {
>>> +                             eeprom@50 {
>>
>> What about other names? Why not fixing everything at once?
>>
> 
> There are 149 dts+dtsi files. I would like to fix them step by step. (lots to check)

I meant, if doing cosmetic changes like this to these files, why not
fixing other names? Some of the work is automatic.

Best regards,
Krzysztof


  reply	other threads:[~2024-07-05  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 15:14 [PATCH 0/7] Update the eeprom nodename following device tree specification Andrei Simion
2024-07-04 15:14 ` [PATCH 1/7] ARM: dts: microchip: at91-sama5d2_xplained: Align the eeprom nodename Andrei Simion
2024-07-04 15:14 ` [PATCH 2/7] ARM: dts: microchip: at91-sama5d2_ptc_ek: " Andrei Simion
2024-07-05  6:42   ` Krzysztof Kozlowski
2024-07-04 15:14 ` [PATCH 3/7] ARM: dts: microchip: at91-sama5d34ek: " Andrei Simion
2024-07-05  6:43   ` Krzysztof Kozlowski
2024-07-05  9:31     ` Andrei.Simion
2024-07-05  9:45       ` Krzysztof Kozlowski [this message]
2024-07-04 15:14 ` [PATCH 4/7] ARM: dts: microchip: at91-sama5d27_som1: " Andrei Simion
2024-07-04 15:14 ` [PATCH 5/7] ARM: dts: microchip: at91sam9g20ek_common: " Andrei Simion
2024-07-04 15:14 ` [PATCH 6/7] ARM: dts: microchip: at91sam9260ek: " Andrei Simion
2024-07-04 15:14 ` [PATCH 7/7] ARM: dts: microchip: at91sam9263ek: " Andrei Simion

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b16d1ace-b113-47e2-9c48-7c89d122e2a9@kernel.org \
    --to=krzk@kernel.org \
    --cc=Andrei.Simion@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®