From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98789C433F5 for ; Fri, 29 Apr 2022 10:59:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358020AbiD2LCg (ORCPT ); Fri, 29 Apr 2022 07:02:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236220AbiD2LCe (ORCPT ); Fri, 29 Apr 2022 07:02:34 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 020CAB6443; Fri, 29 Apr 2022 03:59:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=kmc13/9QXKmxSe5KTNtIvDaUnhBa/LBzSHNpr/JlHjc=; t=1651229956; x=1652439556; b=MGtZqaTln8kneYOUmUxxOjG+sy20jct3Y/eWQcRcjBh3FiL QlwkhrNgiB6MmwZXhX3z5THBWW0cKvIFXUuDJc5z5+xkpiZM7QvFLMkqasks90X/AX5W1SFKwbSuV JXyUrzAqORX5+vGDjeFIwLdsB5pcQfwFKAcjMul5YDI3r2opzJ89z/RMVc2eT5woYXhiKD5gRaukU GtQbOvjNO/OAYmdfdzP4u8FluaG7pZa6+0g2s3fAa+ek72d7d3Yh/KuxR6BaHAFCYQuWRh4MHVW6V Pv2KwZAqluynPHkY8KR/Td/rUcdBgTzF63MLN/snXRi/2zgpPhgQe279zc2cOYxw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1nkOL3-00GukB-L5; Fri, 29 Apr 2022 12:59:05 +0200 Message-ID: Subject: Re: [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval From: Johannes Berg To: Srinivasan Raju Cc: Kalle Valo , "David S. Miller" , "edumazet@google.com" , Jakub Kicinski , "pabeni@redhat.com" , "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:NETWORKING DRIVERS" , open list Date: Fri, 29 Apr 2022 12:59:04 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-04-29 at 10:44 +0000, Srinivasan Raju wrote: > Fix the following sparse warnings: > > drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval > drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype] > > Reported-by: kernel test robot > Signed-off-by: Srinivasan Raju > --- > drivers/net/wireless/purelifi/plfxlc/chip.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c > index a5ec10b66ed5..79d187cf3715 100644 > --- a/drivers/net/wireless/purelifi/plfxlc/chip.c > +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c > @@ -29,11 +29,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval, > u8 dtim_period, int type) > { > if (!interval || > - (chip->beacon_set && > - le16_to_cpu(chip->beacon_interval) == interval)) > + (chip->beacon_set && chip->beacon_interval) == interval) > I think you got the parentheses wrong. johannes