From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0049AC433E6 for ; Mon, 4 Jan 2021 12:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8A75221E5 for ; Mon, 4 Jan 2021 12:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726469AbhADMHJ (ORCPT ); Mon, 4 Jan 2021 07:07:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:52962 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbhADMHI (ORCPT ); Mon, 4 Jan 2021 07:07:08 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 05641AD1E; Mon, 4 Jan 2021 12:06:27 +0000 (UTC) Subject: Re: [PATCH] drm/hisilicon: Use simple encoder To: Tian Tao , airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, alexander.deucher@amd.com, tglx@linutronix.de, dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org, linux-kernel@vger.kernel.org References: <1609140936-57002-1-git-send-email-tiantao6@hisilicon.com> From: Thomas Zimmermann Message-ID: Date: Mon, 4 Jan 2021 13:06:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1609140936-57002-1-git-send-email-tiantao6@hisilicon.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RcKsmR2MQPtOUTxZ5J5DRotL5LML8QcO4" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RcKsmR2MQPtOUTxZ5J5DRotL5LML8QcO4 Content-Type: multipart/mixed; boundary="ZU0tHU16DKjjR6xEEjtT14n4ZpFECqYz0"; protected-headers="v1" From: Thomas Zimmermann To: Tian Tao , airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, alexander.deucher@amd.com, tglx@linutronix.de, dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] drm/hisilicon: Use simple encoder References: <1609140936-57002-1-git-send-email-tiantao6@hisilicon.com> In-Reply-To: <1609140936-57002-1-git-send-email-tiantao6@hisilicon.com> --ZU0tHU16DKjjR6xEEjtT14n4ZpFECqYz0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Am 28.12.20 um 08:35 schrieb Tian Tao: > The hibmc driver uses empty implementations for its encoders. Replace > the code with the generic simple encoder. >=20 > Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann Thanks for the patch. > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers= /gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > index d35548d..c76f996 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > =20 > #include "hibmc_drm_drv.h" > #include "hibmc_drm_regs.h" > @@ -90,10 +91,6 @@ static const struct drm_encoder_helper_funcs hibmc_e= ncoder_helper_funcs =3D { > .mode_set =3D hibmc_encoder_mode_set, > }; > =20 > -static const struct drm_encoder_funcs hibmc_encoder_funcs =3D { > - .destroy =3D drm_encoder_cleanup, > -}; > - > int hibmc_vdac_init(struct hibmc_drm_private *priv) > { > struct drm_device *dev =3D &priv->dev; > @@ -109,8 +106,7 @@ int hibmc_vdac_init(struct hibmc_drm_private *priv)= > } > =20 > encoder->possible_crtcs =3D 0x1; > - ret =3D drm_encoder_init(dev, encoder, &hibmc_encoder_funcs, > - DRM_MODE_ENCODER_DAC, NULL); > + ret =3D drm_simple_encoder_init(dev, encoder, DRM_MODE_ENCODER_DAC); > if (ret) { > drm_err(dev, "failed to init encoder: %d\n", ret); > return ret; >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --ZU0tHU16DKjjR6xEEjtT14n4ZpFECqYz0-- --RcKsmR2MQPtOUTxZ5J5DRotL5LML8QcO4 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/zBMEFAwAAAAAACgkQlh/E3EQov+BM 8Q//cEaWhEx6bGrzmsVKIYruBlRbIrGdvVXOQtREZ085r7ayn8EOL0pqiMMKAopGuEpv0jnYYoFG PKqq2z3acJ1+fC/ws21CpS4mz79r7g/LVW58cK4uoZ30uSTTXGHSz5MNI00aqBcO442DeiqFa4SE wJ40qJ/q6s//ZsNq0VnsT9qMHGJoUeUhRwH4HzjfoPn138U5lJWSO9CO31JxcDpNk5dUEKFq3Gsy 3VoGo2AphKfVNp5ZRF0NDhmMzpsJ4AYnDUdUDLaL/KLUnmycrjLcBQcYF8AbI16Vr2y4GA5E7FzO ++aHDsi0Sam0FxSKdrTPTMbQ4f4CcBM04R+FZ1iZXO4gt5I/Tf7D0lqgFAsvMvZsbjgdESt1GnnH bE7Gx6KgsmHcJge8JICzBXV9okUvUDh8soWYrMjBxFWSaquMoTlQs4/4BTV+9Ixx+Fo/SUXG5WmJ A+uliMKNtFh0misYsPqJd2eVAECNN2KOxZ3WmJzmbxN0IZU/z5lXOhyBT7zdezyWh2Wqd4ZsRsdm AOgt6zfTkiEgUDLKlayCiiEIvXRELRPDyotwS70+FEGGT0/V80J71hIF2MgsWux7t7kT2eCUAbch mfbTXHYROGRGSZhpnaKMOvzb0OIIurosvYOXA1IClOyqIttbP0VyDLRpLtfpOlLbLzTzZ81JMFLO iZA= =v8Wn -----END PGP SIGNATURE----- --RcKsmR2MQPtOUTxZ5J5DRotL5LML8QcO4--