From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbdBJHLj (ORCPT ); Fri, 10 Feb 2017 02:11:39 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:12715 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbdBJHLh (ORCPT ); Fri, 10 Feb 2017 02:11:37 -0500 X-AuditID: cbfec7ef-f79d26d00000420c-72-589d67a8906e Subject: Re: [PATCH] media: s5p_mfc - remove unneeded io_modes initialzation in s5p_mfc_open() To: Shuah Khan , kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, mchehab@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Andrzej Hajda Message-id: Date: Fri, 10 Feb 2017 08:11:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-version: 1.0 In-reply-to: <20170209221117.26381-1-shuahkh@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djPc7or0udGGMz6rWNxZO1VJouZJ9pZ Lc42vWG32PT4GqvF5V1z2Cx6NmxltVi26Q+TxdQvH1gcODw2repk89i8pN5jS/9ddo++LasY PT5vkvO4cqSRPYAtissmJTUnsyy1SN8ugStjytEetoJF7BWPvq5ia2DsYOti5OSQEDCRWPj7 LwuELSZx4d56oDgXh5DAMkaJp0sXs0A4nxkl7v75wQjT0XRoNVgHWNWtlf4Q9jNGiSNrRUFs YYEEib+dNxhBmkUEGhglHrYeZwZJMAukSjx5uwhsNZuApsTfzTfBbF4BO4kZLXNZQWwWAVWJ PZOawJaJCkRI7LjRA1UjKPFj8j2wxZwCthLPp3xmhJhpIDFjymEmCFteYvOat8wQh25jlzjR pNXFyAFky0psOgAVdpF4dnQxK4QtLPHq+BZ2CFtGorPjIBPIzRIC3YwSn/pPsEM4Uxgl/n2Y AdVtLXH4+EVWiGV8EpO2TWeGWMAr0dEmBFHiIfH2eSs0SB0lvm/pY4KE4gRGiSW3p7NMYJSf heSfWUh+mIXkhwWMzKsYRVJLi3PTU4sN9YoTc4tL89L1kvNzNzECU8zpf8ff72B82hxyiFGA g1GJh3dC1ZwIIdbEsuLK3EOMEhzMSiK861PmRgjxpiRWVqUW5ccXleakFh9ilOZgURLn3bvg SriQQHpiSWp2ampBahFMlomDU6qBUdPkjtmyurrG5MQjv1fbfH1hNTNApXzB1m/THzImt82K mnv94mPzudrLfrj5d3z/PVdc5LDmyz3r937wmNoYvvmBgEGC3MaLkpvnfzP2bpWf3/tE/c3c zWxBtfOl2FJ3RAtqacknR7j27EzI/MO24Xx0cZ2b0LOc29OFNqcr176WNf244F1hvhJLcUai oRZzUXEiAJv8VfItAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsVy+t/xK7of0+dGGDTvkLU4svYqk8XME+2s Fmeb3rBbbHp8jdXi8q45bBY9G7ayWizb9IfJYuqXDywOHB6bVnWyeWxeUu+xpf8uu0ffllWM Hp83yXlcOdLIHsAW5WaTkZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaY UwrkGRmgAQfnAPdgJX27BLeMKUd72AoWsVc8+rqKrYGxg62LkZNDQsBEounQahYIW0ziwr31 QHEuDiGBJYwSRw69YYRwnjFKXP/eBpTh4BAWSJB4dNIHJC4i0MAoceH5AnaIokmMErff/QMb yyyQKjHj42N2EJtNQFPi7+abYHFeATuJGS1zWUFsFgFViT2TmhhBbFGBCIn5T1cxQdQISvyY fA/sJE4BW4nnUz4zgixmFtCTuH9RC2K8vMTmNW+ZJzAKzELSMQuhahaSqgWMzKsYRVJLi3PT c4sN9YoTc4tL89L1kvNzNzECo23bsZ+bdzBe2hh8iFGAg1GJh3dC1ZwIIdbEsuLK3EOMEhzM SiK861PmRgjxpiRWVqUW5ccXleakFh9iNAV6YSKzlGhyPjAR5JXEG5oYmlsaGhlbWJgbGSmJ 85Z8uBIuJJCeWJKanZpakFoE08fEwSnVwDj/mHuxj35Fnq3zFrZD30M0bqxbnJcf9UnTrU65 fp/alEVVcjGtcgmRbMv7Lt1K79GUPjfzs6VUyZWzbEV5E5039p/5+HL3u8XBJ2UeO/46/MK9 88/Eqp+JawK3KElIis7hFVk0XaX2VXnT34cWy9asNCnvm7el2vlV3qTHTc6qFhIRv+NvsSqx FGckGmoxFxUnAgCZqG5+zAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170210071133eucas1p2b189c119ddbfc207cd44ea8d12c338dd X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170209221122epcas4p138d5e06079a506356e8ba9dae37825c2 X-RootMTR: 20170209221122epcas4p138d5e06079a506356e8ba9dae37825c2 References: <20170209221117.26381-1-shuahkh@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09.02.2017 23:11, Shuah Khan wrote: > Remove unneeded io_modes initialzation in s5p_mfc_open(). It gets done > right below in vdev == dev->vfd_dec conditional. > > Signed-off-by: Shuah Khan Acked-by: Andrzej Hajda -- Regards Andrzej > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c > index bb0a588..20beaa2 100644 > --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c > +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c > @@ -866,7 +866,6 @@ static int s5p_mfc_open(struct file *file) > /* Init videobuf2 queue for OUTPUT */ > q = &ctx->vq_src; > q->type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE; > - q->io_modes = VB2_MMAP; > q->drv_priv = &ctx->fh; > q->lock = &dev->mfc_mutex; > if (vdev == dev->vfd_dec) {