From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C50024BBEE for ; Tue, 2 Dec 2025 15:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764688527; cv=none; b=ipZWz33ldJiAlXSPh5zTWLe84hmyLk2g+UcgQ6xuOj1RSe05lV7GQh8cmb39irdjj948HoWkzjaOLRt6qz/wXOcysgrFkZpA5xzmqzLnwbEuAbdWWBlBEEGw/i1DaF2PWLG6lg2aEzI3gUEqwr0OohH/7sbQLPRTMs+hjADhOqo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764688527; c=relaxed/simple; bh=mGU0P0Nsy7cRZBHB3IqZ3VM/AZWSLy5zNKhSVRTPp0g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jCyxP27F5Pm9RVu+KF5oJfqo8HIel5D8jgtEgzu38f9KtaA03WnnmrMjVA6ffW3Wxv0JgoibqK5bZH6cBmqwWF3zaRvxAf8+/sxTaZqXJMcrf2FXf3mFDNeSU1gyvwo8SOFR6zHX6XcxSvvg2OUIP4LkQpooIZTy0m4TJnQhME4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FPNMFAXC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T6xKrh32; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FPNMFAXC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T6xKrh32" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B29ZC261358399 for ; Tue, 2 Dec 2025 15:15:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8yAlxqtLJ3wQnUHwPJgBmoZqI7/nkyvP/IJINqHTj+Y=; b=FPNMFAXCE8oDEgNW rdHreC7p+vUlIEkgj95fpurVePgH0A6MFFKh1ebc5LAFE8iZ+lyXcInGeSrJ1D8l shbtwdgm4xeAODBhVItTMozGmO0gMsxdCX5nlgKV423Z0uiFiplAZvrokOc5cT9R 9ZkWa2Cn4xJJlbyhYOKHc6jpdPrGc5wvQzE7DHLiw2acWgVaDvXWCDPaJ/RrxHTl 0r0WcSoDCX0APxvjUY5MB+LB2Ol13QR7AKxoo7+5z4DlF5ENgE5OzqzZY1Ge9ryU UoBWuRWrQOkvDfCxawBcPxhA8jsrM5qKfW5xDf/uOy0y8RGJR1K384aBlmYNO01j HRqL9g== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4asp63jd2c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Dec 2025 15:15:25 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-5dfb3407d2aso521862137.3 for ; Tue, 02 Dec 2025 07:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764688524; x=1765293324; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8yAlxqtLJ3wQnUHwPJgBmoZqI7/nkyvP/IJINqHTj+Y=; b=T6xKrh32WlazcKN926x4pXEjgdPwFzVjQztsiRL5tGD8knYQovfBOTU/hem2715Yn6 VqHhZCFx6CWCpJY+rX6GcDbXNaX2Qe+1Cz3lGcV7RTs1v2TFeBBrBlC8GZZ7e3g6esE9 0gECTfWr9r+LFdVg4uEPDnkiXMkuejVl/wjGThs4XJiGX7R600AEo+bXvCJJjcpTGHHC qo4CCW4I1SR43ILozgsmldVbE0epvVYXcXtM7vO+g1Nift2el2n01izKZaxVWsN7xgBp 4JGBtZ175+QfE/481gstBSzkBQfH9bof15SQa3Mv7EhAvY7UYpxJDFDtrCrWp+aaa0dy 4hnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764688524; x=1765293324; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8yAlxqtLJ3wQnUHwPJgBmoZqI7/nkyvP/IJINqHTj+Y=; b=GCbmqDZitl3nP6FXN93UKktXncT3sxObu2OR0oPbJnEsLVpwLl72aP0SVVHYrjSFn1 meHdUbB2TXDiLy1o53flMYCgQmCrfQbCJy/VjL7jKyS9QLzcbs6fhtFr0vhPOqqnHBgk LdjZmWPRifGhsD1YTjVBz8dTATY16/mw0cLB0en5nj5o4nfQi4MbVKss2ec5oCAuMYqv Fqgq0hg2/Crc9ll7F+n9C5A6YrQk6MIqO2urhNzR3E12FDKaBbavJqc6nsjBK2p0amfK 8BTu3AlEY7BD/AuXOKtzrDPQWHp447Bq+HgnUAgkV5r+JAvvef95PnLzjEpieFADWVp1 z9Vg== X-Forwarded-Encrypted: i=1; AJvYcCWhVVi/Rh1CUUhxUNYwtd6wQFUtqutDJvaiu3cKxCB0Vxv5RlP5qdzhbKGRZkMtR8qfkyVX6aLQ4UDkcQY=@vger.kernel.org X-Gm-Message-State: AOJu0YxQjyR6MfzvuZZTTn72loLySYXZSdxkvK7NSR7rHPOu6ttIWcHa K6LacaC84q5/NMH1g99CNntDaxrojj7p2O+c7T683XxXZjL2i71GCz944Iyt6/8v4WrS8afQV8q w2dzLLFnsHjEI16Z8x9Ql7lpwXM2L0/j29QyZMQ5M0Nw+tqaP8+kL73U0esnziXpDAKo= X-Gm-Gg: ASbGncvyrj2M/4ZiL/y/KZg3BSyu/pRrLExOKM4Z7whBtb7a7HYoi3g51pFw2grlsH1 0bODhdyqwiPlniqd46kfOgbBxFCTHbArnnuPZEHVYq1PwhSyugC3mwPCYmkxQJWcuKHJD42Fcuz faRaWN3NgnCTuBosqeN5pjr12+rLdzbdflciXd2nT8pcd9oFpTcXa7mDNXIGGnHCKjxeyoWVFyJ Enlax6OfQsmvoZ4DesRMWS4VCtTmvpZnNp8N3vR1Fd7kp8vjdITjIxbPDV7L/f4Nap5vn2BQMRh zye8qNINHCe6Of9lSHOYzj+Iek2DC3C85ax6tIJXMNm0OshooboBf0e5piH3eLqMNQXkJqT7KIy hgREeZO0h3yGIVBAixp/2ya4eNzZPuce3SW7DvbzUjU2+l0LErufBozrpjBGyheSeog== X-Received: by 2002:a05:6102:291f:b0:5de:31a4:8702 with SMTP id ada2fe7eead31-5e1de121d6bmr10164746137.2.1764688523663; Tue, 02 Dec 2025 07:15:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IEST8ZLfQ7IQ4y4gZZBC2oUywwREAPPojaVrxOyuZtrigcP/fGYB6QBsnTg1QYZhBSfGmIEOw== X-Received: by 2002:a05:6102:291f:b0:5de:31a4:8702 with SMTP id ada2fe7eead31-5e1de121d6bmr10164685137.2.1764688522664; Tue, 02 Dec 2025 07:15:22 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a5f979sm1515119966b.69.2025.12.02.07.15.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Dec 2025 07:15:22 -0800 (PST) Message-ID: Date: Tue, 2 Dec 2025 16:15:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Add dts for Medion SPRCHRGD 14 S1 To: Georg Gottleuber , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ettore Chimenti , Srinivas Kandagatla , stefan.schmidt@linaro.org, stephan.gerhold@linaro.org, wse@tuxedocomputers.com, cs@tuxedo.de References: <20251202143757.69817-1-ggo@tuxedocomputers.com> <20251202143757.69817-4-ggo@tuxedocomputers.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251202143757.69817-4-ggo@tuxedocomputers.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: PO-lAfTgYDWj4uhbxbNQD0NqvAzHx0Gb X-Proofpoint-ORIG-GUID: PO-lAfTgYDWj4uhbxbNQD0NqvAzHx0Gb X-Authority-Analysis: v=2.4 cv=XM49iAhE c=1 sm=1 tr=0 ts=692f028d cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=N2CewTqjCUGRCYXJoYIA:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAyMDEyMiBTYWx0ZWRfXy9EwQeTWorGJ CNAM9fwKtGX89+AvIi9ULaku3NrXIJUdvsMsI97kn68F6dFoozXI24cuvwz4cMZQgXgr/MCiYlR WHxexwpTT0wPZKp1vmRiok+u3gYj1m4Pq/kTyQtvjobS+DK41bVEzhoOoWO6aISt5PhhpoHHn7A HWzaJHTkzAvNEKi0gjOUP5+repsAD+S9q/Q1DUmVLZPG4SXlTMIgQU2b+98Lf1pitw/+hPKNmcP /CkYyq1qLp4yBzEvgTVaiVv9+FFz4ou0TDjAa3YwjZ9mCOs8qmZehg9wwD2DHI7niQcYMIsp0rn 8Qhkd0RAUnsUWW0bdL51wRNlSitJPjBhT2P1OKcpDMHoc9e3cqXCngCdQD0QBecRUPjQyoI6aOP wyZk5tA3q+gPUffqqLXzbRL8w0AFrA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-01_01,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512020122 On 12/2/25 3:37 PM, Georg Gottleuber wrote: > Initial support for the Medion SPRCHRGD 14 S1, which is based on the > Qualcomm Snapdragon X Elite SoC (X1E78100). [...] > +&iris { > + firmware-name = "qcom/x1e80100/medion/qcvss8380.mbn"; > + status = "okay"; Please add an \n above status > +}; > + > +&lpass_tlmm { > + spkr_01_sd_n_active: spkr-01-sd-n-active-state { > + pins = "gpio12"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + output-low; Let's drop output-low from these two, the driver controls that over GPIO APIs > + }; > + > + spkr_23_sd_n_active: spkr-23-sd-n-active-state { > + pins = "gpio13"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + output-low; > + }; [...] > + eusb3_reset_n: eusb3-reset-n-state { > + pins = "gpio124"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + output-low; Similarly, for all three eUSBn, the regulator driver will assert the pin as necessary [...] > + perst-n-pins { > + pins = "gpio146"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-down; PERST# is active-low, switch to bias-disable [...] > + perst-n-pins { > + pins = "gpio152"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; just like you did here [...] > + wcd_default: wcd-reset-n-active-state { > + pins = "gpio191"; > + function = "gpio"; > + drive-strength = <16>; > + bias-disable; > + output-low; ditto Konrad