From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752303AbdEPMHe (ORCPT ); Tue, 16 May 2017 08:07:34 -0400 Received: from mout.web.de ([217.72.192.78]:51371 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbdEPMH2 (ORCPT ); Tue, 16 May 2017 08:07:28 -0400 Subject: [PATCH 1/2] regulator: fixed: Delete error messages for failed memory allocations in reg_fixed_voltage_probe() From: SF Markus Elfring To: Liam Girdwood , Mark Brown , kernel-janitors@vger.kernel.org Cc: LKML , Wolfram Sang References: <83b84f24-503b-4b45-3e4d-9c88c6b0252b@users.sourceforge.net> Message-ID: Date: Tue, 16 May 2017 14:07:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <83b84f24-503b-4b45-3e4d-9c88c6b0252b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:v8TA/fbkxSZZATIC6CQawSsSLfAEZl+OleRGtRzvJgafU5WLXYZ ePTtxlLXc1DGeYCus50bTAk4RdskgTvpadM/y18Z3DDj33ojZrcN38RUg++on0N6Oj1jOgv jvjMos/fzsfQdRt6msRiLoGSmvvRKeMFmk49hhHY6rv8eUCu0R/qDzSi2PwnDAU+KM+TABI VH8m6FiLaHTePtNlgtsWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:RAOASc8qAZg=:YL20buGPvB5xtqyVlEOHvC MVbTKx0x8Rw9Kl2EJd3E6GeopDTMGbFqpb25Uq+71Fr1C0s8Q9HTk6DWubtfFSd5jsbO+q1cy Os6xJsQrSydtLZNgkckcTAFluhvsMLrd/ALa5yBtZ+AmQ0sW0YT3/1jC8WOi3YdZDgjMCT6aC ZMLKiK6B4qiWshkskD0G0zjFjaHTUrJPN1Fr1k8ffclnuyqy1X0ZEvEGUiOcrhDHK9biqwR5Y O93h0f+JsuMK7CG0olgG+/B+e2Irw+JaHkrlBHJRCqXHt//S8U2q8/X5Ookop1w9HvVNY/rqO ehIB2mAPfT4setwFiN917SnHyjHn3FvRhX8SZtEaZhcYxvMd0sLmJb7fXTI+yE9zjpTS7cRSb TDC20AO6EAMHKjC4AmjWkJhW0aW0rXVDiFd/Etzcbug/Wbal9Y6bFDkeIux+g20YlRpJZu+se PlLXLS0+Y7LvRb7VXATVTbN+BHm436bNHlWGaYJ282VCAgYaHJ/1BRuY6qP/hcoNPkDyT35jD IZAmjKiCFpkgsCQaPobmnQVoqJEtx/EPtMTwKZO1/YWerRm3+WpAJc20gsS5N6PT2EDklCMD8 X7z4npauDjNlhJU2LaV5IIWKDPQfN1uCp97W2qkaro39WDCz610enVtadHRPonRusl8k/+z7p HlVZkJZWYGgmEDFEW+JYW5G0FrAMtOfnjPtDwH4vEbRSk45IX4whWDmQ29E/zzOjtMOueV4pK 3l63Ctz1YutOY+XSyRSw0z0W0mURC7vXIRR3RlkuRmLavBpkVUqwodnbfaqHXNtg7ldhAvGN/ mL7RQzv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 16 May 2017 13:31:20 +0200 Omit two extra messages for memory allocation failures in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/regulator/fixed.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c index 988a7472c2ab..a947f357d0f8 100644 --- a/drivers/regulator/fixed.c +++ b/drivers/regulator/fixed.c @@ -124,10 +124,9 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) drvdata->desc.name = devm_kstrdup(&pdev->dev, config->supply_name, GFP_KERNEL); - if (drvdata->desc.name == NULL) { - dev_err(&pdev->dev, "Failed to allocate supply name\n"); + if (!drvdata->desc.name) return -ENOMEM; - } + drvdata->desc.type = REGULATOR_VOLTAGE; drvdata->desc.owner = THIS_MODULE; drvdata->desc.ops = &fixed_voltage_ops; @@ -138,11 +137,8 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev) drvdata->desc.supply_name = devm_kstrdup(&pdev->dev, config->input_supply, GFP_KERNEL); - if (!drvdata->desc.supply_name) { - dev_err(&pdev->dev, - "Failed to allocate input supply\n"); + if (!drvdata->desc.supply_name) return -ENOMEM; - } } if (config->microvolts) -- 2.13.0