From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D1FC433FE for ; Tue, 25 Jan 2022 16:44:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1583978AbiAYQoq (ORCPT ); Tue, 25 Jan 2022 11:44:46 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:39604 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1584756AbiAYQkU (ORCPT ); Tue, 25 Jan 2022 11:40:20 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 05CB21F38A; Tue, 25 Jan 2022 16:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643128819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qaT5yS0WIOg+/sXBG6KxbDZck9FEnOBGOKxMbfVHD7A=; b=BwMmViNljIgkYsxMmwoUUOHvsw70vBp1Dat2vAEUCJzUAgvs7G+CJi+6Wh6SCVifZXfuH4 nq5ycw0Qgyb5y3OUqOzDKqES+ESdGiKmtmo1DpRTEouqk8ajB+WSpSf68yHrkxTnvmPFGt y2OBa6iNyFJ6dUuJctbvLitjFs1I/NQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643128819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qaT5yS0WIOg+/sXBG6KxbDZck9FEnOBGOKxMbfVHD7A=; b=5qugXxX3c+kIqj3wrE4G5dEDqiFLrXFYploVMId5Vnw5acH329Vu/kKRcTzg9p2oW1qn+N YdYoWxkKLCGO2mCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D29EC13E4B; Tue, 25 Jan 2022 16:40:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fWkkMvIn8GF6OgAAMHmgww (envelope-from ); Tue, 25 Jan 2022 16:40:18 +0000 Message-ID: Date: Tue, 25 Jan 2022 17:40:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Chen Wandun , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, guillaume.tucker@collabora.com References: <20220117142712.3967624-1-chenwandun@huawei.com> From: Vlastimil Babka Cc: regressions@lists.linux.dev, Oscar Salvador Subject: Re: [PATCH] Revert "mm/page_isolation: unset migratetype directly for non Buddy page" In-Reply-To: <20220117142712.3967624-1-chenwandun@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/22 15:27, Chen Wandun wrote: > This reverts commit 075782149abff45ee22f27315eced44d02b96779. > > commit 075782149abf ("mm/page_isolation: unset migratetype directly for That's an old -next commit id, it went to mainline as 721fb891ad0b ("mm/page_isolation: unset migratetype directly for non Buddy page") > non Buddy page") will result memory that should in buddy disappear by > mistake. move_freepages_block move all pages in pageblock instead of > pages indicated by input parameter, so if input pages is not in buddy > but other pages in pageblock is in buddy, it will result in page out of > control. > > Reported-by: "kernelci.org bot" > Signed-off-by: Chen Wandun Acked-by: Vlastimil Babka #regzbot ^introduced: 721fb891ad0b There should better be also: Fixes: 721fb891ad0b ("mm/page_isolation: unset migratetype directly for non Buddy page") Especially as that commit had a (inadequate, IMHO, for an optimization) Fixes: tag and could end up being backported somewhere without the followup fix/revert. > --- > mm/page_isolation.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 6a0ddda6b3c5..f67c4c70f17f 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -115,7 +115,7 @@ static void unset_migratetype_isolate(struct page *page, unsigned migratetype) > * onlining - just onlined memory won't immediately be considered for > * allocation. > */ > - if (!isolated_page && PageBuddy(page)) { > + if (!isolated_page) { > nr_pages = move_freepages_block(zone, page, migratetype, NULL); > __mod_zone_freepage_state(zone, nr_pages, migratetype); > }