From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89F8BC433EF for ; Sat, 25 Dec 2021 05:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbhLYFVM (ORCPT ); Sat, 25 Dec 2021 00:21:12 -0500 Received: from regular1.263xmail.com ([211.150.70.197]:43094 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbhLYFVL (ORCPT ); Sat, 25 Dec 2021 00:21:11 -0500 Received: from localhost (unknown [192.168.167.13]) by regular1.263xmail.com (Postfix) with ESMTP id 61F3F1B85; Sat, 25 Dec 2021 13:21:09 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [192.168.1.10] (unknown [111.30.214.151]) by smtp.263.net (postfix) whith ESMTP id P14038T140177747977984S1640409669296931_; Sat, 25 Dec 2021 13:21:09 +0800 (CST) X-IP-DOMAINF: 1 X-RL-SENDER: chengang@emindsoft.com.cn X-SENDER: chengang@emindsoft.com.cn X-LOGIN-NAME: chengang@emindsoft.com.cn X-FST-TO: linux-kernel@vger.kernel.org X-RCPT-COUNT: 2 X-LOCAL-RCPT-COUNT: 0 X-MUTI-DOMAIN-COUNT: 0 X-SENDER-IP: 111.30.214.151 X-ATTACHMENT-NUM: 0 X-UNIQUE-TAG: X-System-Flag: 0 Subject: Re: [PATCH] kernel: time: Return ENXIO instead of ENODEV when call smp_call_function_single fail in clockevents_unbind To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org References: <20211219152929.479876-1-gchen@itskywalker.com> From: Chen Gang Message-ID: Date: Sat, 25 Dec 2021 13:21:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20211219152929.479876-1-gchen@itskywalker.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: The original mail was not sent successfully, so I send it again with another mailbox. Thanks. On 12/19/21 11:29 PM, gchen@itskywalker.com wrote: > From: Chen Gang > > smp_call_function_single will return -ENXIO for failure, so ENXIO needs > to be as the default value of cu.res for return instead of ENODEV. > > Signed-off-by: Chen Gang > --- > kernel/time/clockevents.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c > index 003ccf338d20..59b83bee03e6 100644 > --- a/kernel/time/clockevents.c > +++ b/kernel/time/clockevents.c > @@ -416,7 +416,7 @@ static void __clockevents_unbind(void *arg) > */ > static int clockevents_unbind(struct clock_event_device *ced, int cpu) > { > - struct ce_unbind cu = { .ce = ced, .res = -ENODEV }; > + struct ce_unbind cu = { .ce = ced, .res = -ENXIO }; > > smp_call_function_single(cpu, __clockevents_unbind, &cu, 1); > return cu.res; >