From: "Nemanov, Michael" <michael.nemanov@ti.com>
To: <akemnade@kernel.org>, <kvalo@kernel.org>,
<rmk+kernel@armlinux.org.uk>, <johannes.berg@intel.com>,
<miriam.rachel.korenblit@intel.com>, <leitao@debian.org>,
<andreas@kemnade.info>, <emmanuel.grumbach@intel.com>,
<tony@atomide.com>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] wifi: wlcore: fix unbalanced pm_runtime calls
Date: Mon, 6 Jan 2025 08:22:14 +0200 [thread overview]
Message-ID: <b198db94-1857-4c2a-94d9-69dc13d7c67d@ti.com> (raw)
In-Reply-To: <20250104195507.402673-1-akemnade@kernel.org>
On 1/4/2025 9:55 PM, akemnade@kernel.org wrote:
> From: Andreas Kemnade <andreas@kemnade.info>
>
> If firmware boot failes, runtime pm is put too often:
> [12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
> [12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
> Fix that by redirecting all error gotos before runtime_get so that runtime is
> not put.
>
> Fixes: c40aad28a3cf ("wlcore: Make sure firmware is initialized in wl1271_op_add_interface()")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reviewed-by: Michael Nemanov <michael.nemanov@ti.com>
Best regards,
Michael.
next prev parent reply other threads:[~2025-01-06 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 19:55 akemnade
2025-01-06 6:22 ` Nemanov, Michael [this message]
2025-01-10 12:51 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b198db94-1857-4c2a-94d9-69dc13d7c67d@ti.com \
--to=michael.nemanov@ti.com \
--cc=akemnade@kernel.org \
--cc=andreas@kemnade.info \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®