From: Jeremy Clifton <deaner92@yahoo.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Viresh Kumar <vireshk@kernel.org>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
outreachy@lists.linux.dev, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: greybus: Remove unused header declaration to_fw_mgmt_connection
Date: Wed, 14 Oct 2026 20:10:49 -0600 [thread overview]
Message-ID: <b19b8058-bfe9-4800-95c8-d2db889b43e6@yahoo.com> (raw)
In-Reply-To: <2d2106c-a2d2-2bec-b368-c03850cba9a7@inria.fr>
On 10/14/26 7:46 PM, Julia Lawall wrote:
>
>
> On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:
>
>> Previous commit removing a function definition did not remove the
>> function prototype.
>
> Please use proper English.
>
> The commit 3228900f80c2 ("staging: greybus: Remove unused function
> 'to_fw_mgmt_connection'") removing a function definition did not remove
> the function prototype.
>
>>
>> commit 3228900f80c2 ("staging: greybus: Remove unused function
>> 'to_fw_mgmt_connection'")
>>
>> Function header declaration needs to be removed after definition
>> removal.
>
> This is saying what you did. It should be in the imperative:
>
> Remove the prototype.
>
"Remove the prototype." in the imperative has been changed.
>> There is no definition of this function nor is there any place where it
>> is called.
>
> Not sure this is needed, since the definition was removed previously.
It's been removed.
The next revision is sent.
Jeremy
next prev parent reply other threads:[~2026-10-15 2:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261014174248.97561-1-deaner92.ref@yahoo.com>
2026-10-14 17:42 ` Jeremy Dean Clifton
2026-10-15 1:46 ` Julia Lawall
2026-10-15 2:10 ` Jeremy Clifton [this message]
2026-10-15 2:22 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b19b8058-bfe9-4800-95c8-d2db889b43e6@yahoo.com \
--to=deaner92@yahoo.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®