From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762187AbdAKHnq (ORCPT ); Wed, 11 Jan 2017 02:43:46 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:29261 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757883AbdAKHnn (ORCPT ); Wed, 11 Jan 2017 02:43:43 -0500 X-AuditID: cbfec7f5-f79d06d000004445-1a-5875e22a6c78 Subject: Re: [PATCH v8 1/3] dt-bindings: Add support for samsung s6e3ha2 panel binding To: Hoegeun Kwon , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, inki.dae@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Donghwa Lee , Hyungwon Hwang From: Andrzej Hajda Message-id: Date: Wed, 11 Jan 2017 08:43:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <1484116439-7275-2-git-send-email-hoegeun.kwon@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHe885OzuKs9e58sksYdQHhcwg66XECgoOfeqTDSty5UFFp2tz UkIkXaw0ndRQWxftg2miKZtmM9OawzUK5yW6eakULVLR7Gp223Ym+O338Pz/7//5w8vRcock nEvPyhF0WepMJRvI3Oued2+IHjWoYu+aNpDiHhdFWh0TEvLy6wcJqXT0eMidQJ5/m2HJTE0h S6orSiTk8ttShrz6VSAhxrFJmrjdTVIy0HadJRXuDor8a78vJfNtN5mdmLeZh6W8pe4iy7d+ fyfh3xY5Kb6kuQ7xXyxr97FJgfEpQmZ6rqDbmJAcmOYyTku1t5Yfv/2giM1H9qBCFMAB3gzD Dhsr8kroHWn0cCAnx9UI6sfHaXH4gmDh9IR00WGrqpeKi9sITIVTftUEAqfrpcSrCsUq+D3c S3kXCmxE8GHK4rPQ2ErBn4YGXyKLo+CP9bWPZTgBml888TDHMXg9zNb4DlzhecjePUiLkhD4 eWWE8XIA5qH4rMsXRuNYqDB1USJHgrV+2ncR4M9SKBs8x3jfBLwGLI9oscJuaPjY4q8TCp+c zX6OgIsXHlOitwjBnPGJVBxMCP7OVvjd26HL2edPDobL98ppMUAGFwrkooSH0ZJORuRd8Kzn qS9Ajl8jGFvgS1GkeUkf85IO5iUdqhBdhxSCQa9JFfRxMXq1Rm/ISo05mq2xIM/fevrX+e0+ qu7eZkeYQ8ogGZnMUckl6lz9CY0dAUcrFbLzQwaVXJaiPpEn6LIP6wyZgt6OVnOMMkzWXvV8 vxynqnOEDEHQCrrFLcUFhOej3ceCRm2xhyvntMtP9lqTon7MZJ5S9zfm9b3b4ph+0/jJkpT1 /uiN/rjCbcntkd3FtodNZZuDK4eSD5ZnWA90judGlOcfCpvLrk1cG77nMVk3d3U9Ni4L0bou Je4NWtCsOtvfsuNQpKpgICzlzJGtitBrWsVsmEIeURvfkfPqTpl5WMno09SbommdXv0fA2AK DlcDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t/xy7pxj0ojDLasZrHoPXeSyWL7kWes Fte/PGe1mH/kHJB13s7iytf3bBbvl3exWSyd0cdqMen+BBaLG7/aWC36H79mtjh/fgO7xeVd c9gsZpzfx2Txf88Odoufu+axOAh47Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxR bjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W 0rdLcMs42f+WvWAhf8Wy3d1sDYyHeLoYOTkkBEwkdi5Yww5hi0lcuLeerYuRi0NIYAmjxM/F txghnGeMEpsefmfqYuTgEBaIkHi+PwwkLiLQC1R0rZ0Jougmo0TnpPNgDrPAZiaJvqVX2EDm sgloSvzdfBPM5hWwk9hy7QQbyCQWAVWJD8t5QExRoKENh9MhKgQlfky+xwJicwp4SPS2nGQF KWEW0JO4f1ELJMwsIC+xec1b5gmMArOQdMxCqJqFpGoBI/MqRpHU0uLc9NxiQ73ixNzi0rx0 veT83E2MwNjdduzn5h2MlzYGH2IU4GBU4uF98KIkQog1say4MvcQowQHs5IIb/ud0ggh3pTE yqrUovz4otKc1OJDjKZAD0xklhJNzgemlbySeEMTQ3NLQyNjCwtzIyMlcd6SD1fChQTSE0tS s1NTC1KLYPqYODilGhhFTPPfqzu82ymhu6vhxLyix1Vnee4eT9674NtZo2O6PMen7emqUe97 bCS7/3jhR9mJCgWTqk4WF1eo7i04ffy8xr+r0wVN51ZaiWx3sFCf6auUdUnZo+jVoixnN4lb J887139Zt+zLwlLJya2xO2ee1znxzeJ4ssjefZcdgsLupi+SlEy/9UtLiaU4I9FQi7moOBEA C20A0vMCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111074338eucas1p1ed74cf1f0239a7a8e00a91bf777a744f X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170111063407epcas1p46379fc5062afe1268b186514969e225e X-RootMTR: 20170111063407epcas1p46379fc5062afe1268b186514969e225e References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-2-git-send-email-hoegeun.kwon@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.01.2017 07:33, Hoegeun Kwon wrote: > The Samsung s6e3ha2 is a 5.7" 1440x2560 AMOLED panel connected > using MIPI-DSI interfaces. > > Signed-off-by: Donghwa Lee > Signed-off-by: Hyungwon Hwang > Signed-off-by: Hoegeun Kwon > Tested-by: Chanwoo Choi > Reviewed-by: Andrzej Hajda > --- > .../bindings/display/panel/samsung,s6e3ha2.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > new file mode 100644 > index 0000000..3e7892c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3ha2.txt > @@ -0,0 +1,26 @@ > +Samsung S6E3HA2 5.7" 1440x2560 AMOLED panel > + > +Required properties: > + - compatible: "samsung,s6e3ha2" > + - reg: the virtual channel number of a DSI peripheral > + - vdd3-supply: I/O voltage supply > + - vci-supply: voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin (active low) > + - enable-gpios: a GPIO spec for the panel enable pin (active high) > + - te-gpios: a GPIO spec for the tearing effect synchronization signal > + gpio pin (active high) One more thing I didn't catch earlier, te-gpios property should be optional - in case of hw-trigger we do not need it. Regards Andrzej > + > +Example: > +&dsi { > + ... > + > + panel@0 { > + compatible = "samsung,s6e3ha2"; > + reg = <0>; > + vdd3-supply = <&ldo27_reg>; > + vci-supply = <&ldo28_reg>; > + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; > + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; > + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; > + }; > +};