From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbdKGI6f (ORCPT ); Tue, 7 Nov 2017 03:58:35 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43556 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753099AbdKGI6d (ORCPT ); Tue, 7 Nov 2017 03:58:33 -0500 Subject: Re: [PATCH v2] cpupower : Fix cpupower working when cpu0 is offline To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171107072005.48034-1-huntbag@linux.vnet.ibm.com> Cc: Shuah Khan , Shuah Khan , Thomas Renninger From: Abhishek Date: Tue, 7 Nov 2017 14:28:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171107072005.48034-1-huntbag@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 17110708-0008-0000-0000-000004A86884 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17110708-0009-0000-0000-00001E3AFF1A Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-07_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1711070127 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Can you have a look at it? Thanks and Regards, Abhishek Goel System Engineer IBM India Pvt. Ltd. On 11/07/2017 12:50 PM, Abhishek Goel wrote: > cpuidle_monitor used to assume that cpu0 is always online which is not > a valid assumption on POWER machines. This patch fixes this by searching > for the first online cpu and uses it, instead of always using cpu0 for > monitoring which may not be online. > > Signed-off-by: Abhishek Goel > --- > v2: Commit message updated. > --- > tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c b/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c > index 1b5da00..adacf99 100644 > --- a/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c > +++ b/tools/power/cpupower/utils/idle_monitor/cpuidle_sysfs.c > @@ -130,15 +130,23 @@ static struct cpuidle_monitor *cpuidle_register(void) > { > int num; > char *tmp; > + int first_online_cpu; > + > + for (num = 0; num < cpu_count; num++) { > + if (cpupower_is_cpu_online(num)) > + break; > + }; > + first_online_cpu = num; > > /* Assume idle state count is the same for all CPUs */ > - cpuidle_sysfs_monitor.hw_states_num = cpuidle_state_count(0); > + cpuidle_sysfs_monitor.hw_states_num = > + cpuidle_state_count(first_online_cpu); > > if (cpuidle_sysfs_monitor.hw_states_num <= 0) > return NULL; > > for (num = 0; num < cpuidle_sysfs_monitor.hw_states_num; num++) { > - tmp = cpuidle_state_name(0, num); > + tmp = cpuidle_state_name(first_online_cpu, num); > if (tmp == NULL) > continue; > > @@ -146,7 +154,7 @@ static struct cpuidle_monitor *cpuidle_register(void) > strncpy(cpuidle_cstates[num].name, tmp, CSTATE_NAME_LEN - 1); > free(tmp); > > - tmp = cpuidle_state_desc(0, num); > + tmp = cpuidle_state_desc(first_online_cpu, num); > if (tmp == NULL) > continue; > strncpy(cpuidle_cstates[num].desc, tmp, CSTATE_DESC_LEN - 1);