From: David Hildenbrand <david@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v4 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same
Date: Mon, 19 Dec 2016 15:57:16 +0100 [thread overview]
Message-ID: <b1b2fcc5-5676-206f-af0a-7484fdcc69db@redhat.com> (raw)
In-Reply-To: <20161216170710.GB3637@potion>
Am 16.12.2016 um 18:07 schrieb Radim Krčmář:
> 2016-12-16 17:53+0100, Paolo Bonzini:
>> On 16/12/2016 17:41, David Hildenbrand wrote:
>>>
>>> Just to verify:
>>>
>>> The GET_APIC_DEST_FIELD(mda) == APIC_BROADCAST is still correct in
>>> kvm_apic_broadcast() ?
>>
>> No, it seems wrong.
>
> Definitely, sending v4 of this patch.
> I'll also add broadcast address check into kvm-unit-tests ...
> ---8<---
> Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
> to xAPIC VCPUs and vice-versa. Make slow path behave like fast path,
> which never distinguished that.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> v4: fix xAPIC broadcast address detection [David]
> ---
> arch/x86/kvm/lapic.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
Looks good to me.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
David
next prev parent reply other threads:[~2016-12-19 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 17:06 [PATCH v3 0/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff Radim Krčmář
2016-12-15 17:06 ` [PATCH v3 1/4] KVM: x86: use delivery to self in hyperv synic Radim Krčmář
2016-12-15 17:06 ` [PATCH v3 2/4] KVM: x86: replace kvm_apic_id with kvm_{x,x2}apic_id Radim Krčmář
2016-12-16 15:41 ` David Hildenbrand
2016-12-15 17:06 ` [PATCH v3 3/4] KVM: x86: make interrupt delivery fast and slow path behave the same Radim Krčmář
2016-12-16 16:41 ` David Hildenbrand
2016-12-16 16:53 ` Paolo Bonzini
2016-12-16 17:07 ` [PATCH v4 " Radim Krčmář
2016-12-19 14:57 ` David Hildenbrand [this message]
2016-12-15 17:06 ` [PATCH v3 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff Radim Krčmář
2016-12-16 16:48 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1b2fcc5-5676-206f-af0a-7484fdcc69db@redhat.com \
--to=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®