From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbdFILcN (ORCPT ); Fri, 9 Jun 2017 07:32:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38123 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbdFILcM (ORCPT ); Fri, 9 Jun 2017 07:32:12 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 96034627C8 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=pbonzini@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 96034627C8 Subject: Re: [PATCH RFC] KVM: async_pf: fix async_pf exception injection To: Wanpeng Li Cc: "linux-kernel@vger.kernel.org" , kvm , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Wanpeng Li References: <1496914224-87730-1-git-send-email-wanpeng.li@hotmail.com> <6458c7e1-c404-43e5-800b-6e02f236c902@redhat.com> From: Paolo Bonzini Message-ID: Date: Fri, 9 Jun 2017 13:32:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 09 Jun 2017 11:32:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2017 07:30, Wanpeng Li wrote: > 2017-06-08 19:52 GMT+08:00 Paolo Bonzini : >> >> 3) add an async_page_fault member to vcpu->arch.exception > > Do you think we should also add an async_page_fault field to > x86_exception, then pass down to kvm_inject_page_fault() through > x86_exception? Maybe we should modify > kvm_queue_exception_e/kvm_multiple_exception etc to add an function > parameter for async_page_fault. I don't know. :) I cannot say without looking closer or basically doing all the work. Do whatever looks best to you! Paolo