From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D32039183C for ; Sun, 12 Jul 2026 08:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783845955; cv=none; b=lygzL6/uBmzMs1L6VKr2AZBDrWbDj4I02XWkmUcEUmrosVW4R7oIaXK2Uts4KRfCjXCzSfCkVCtBKgPxrMmSP241zljXEWsj1wbps8qRl3ynbO7zTe7azZRT4tCg38k5/mxYGLxF6hqP/diF/uYjDhXc8FQ5/pW/2gD/k/W/dhs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783845955; c=relaxed/simple; bh=zWHY5hZ/8Ox8s31q8zApgayyvinHfRJ82OuShKdkkZA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MTF88piycW6aUA0R0TxszoZpCGr+xRKnvkguDlBZN4PtwAc1TYgh0hbEouzGXYXVEFj8Fl6+UqTmS12klYjYhXmnHjRezgPSuEI6Kd+lTZq3t+qPmESVK7RLxB/qu1lgkdKZz+IdtAit092FYr4QG3brK/3NIJKa3g8Aflt3Gzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZJWBwY/2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OIJoz/2+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZJWBwY/2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OIJoz/2+" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66C7S8N31984211 for ; Sun, 12 Jul 2026 08:45:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Xf+qvVGz/Rsik4m6OuGXL2+Wevl0zm2bIBnoam/yT74=; b=ZJWBwY/2zF1me725 90VJ/QBNnyioXyxDHWnp7KXHE8WW2sN1f62N6wjE+8iPYpJi4NO+L28xvXpJ3IkD fYeds8VnVfdRTrVpSCVONzu0tNLvCYajb/+Me6YLuZzicbZWIujftU7ik+iwHg2U /AOJl/tge6f8XQOdpVv+4AYQ4ziVgyScAWfgww6anajW0gl4D4F9kw42QfsFWCd9 +h+xdO747XHVL7jnvtCxdciMKGSn9kd9f4j27SHtjRoM35E9+Yb//rpph7dRV4GD 2x6aQK30vBaTegOiSp24/PWHTRQDbLypejsefj5XywdOmaB0rNf++rZUIPcJ9O6j DshVsA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbebr2d47-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 12 Jul 2026 08:45:53 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88fc985a65so940542a12.2 for ; Sun, 12 Jul 2026 01:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783845951; x=1784450751; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Xf+qvVGz/Rsik4m6OuGXL2+Wevl0zm2bIBnoam/yT74=; b=OIJoz/2+beqqY/lzFzg4rZRGDu0HIMzI92paoE8+n8+SAdFaVl0ckoKVJM+p973kjQ KiqTbS4AV70Uz5o2i4Wwr/Tyo5jRoeX5/EZI3rd/4o494fzK66sFniakqrlY/jUd8CFd N1vkfzP2cJfO47LSEMml+WSUqugzxU3CcuH1cIGJWafUYS6Jg0sMv/8/ZwCLX5NgM9zO D55OWP+HlqqDUs56VWMAauo28tFsn4A1TQWVHZzdTKtARyTBRDvXR0l3MPRfGjzgccwL gKgZ8XSFkSAGKFMb9kbvT5txwozMKkdgyGGe9iL0feCTJvpV44y+edLR5qRN4LzaVsNz OXwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783845951; x=1784450751; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Xf+qvVGz/Rsik4m6OuGXL2+Wevl0zm2bIBnoam/yT74=; b=B7SgJgN/T6d7Ig6pdeaf8OlK/imI5wRh1Ry7R69QD3LKPNt34enDaREmEeweEFZ5Z8 xxJqsY3yJ+CWlI/DIwt0SWhZWpFkISi0EU2ECDlsxz+fOy54YlAcoVAQ0NV/otILb09d R83TOgbVFJYtq+VEUM267k+aXRbQwaXg4lnona/Dwd6v0fii05RFgHRWMZ05C2u9F1Y7 vx0b5q9z9tyj4WBAAu+IhLTwv9NwQFf/rlmNEjYqtS1BYbylM0a7laAtaYR3l3x76qvg DnBJ+wnc/h1hIlltKw9fOpdyElkmi1JmJNR1bcqKHnxYv7unOva7IZIDO9xRbXx5Y5IG MPDg== X-Forwarded-Encrypted: i=1; AHgh+RpDLF+0JyfWyi9lkruBMuBKN/s2KlRXdpghip4PS6M4iaeH5QFkDBVudyg8zx7kGApmK1z1r4o7hR8DoZU=@vger.kernel.org X-Gm-Message-State: AOJu0YxfksYIyPlwfXlUO7OisqqB2XvAo0b2vCqkcBkG51mJKRTxhc8K 9x+31QDLrhjmx9jHX9tAmgb8okkULOWyh642ppki/qhiEyC4WxTDXlWW7RPQcx0CL6hj+PHOHRe 4mqr3Xkd26RebtTZvud/HsOlnwEMwNkjEusvsxNob+bB6IF8pFzaAmihdR47N8GiJj50= X-Gm-Gg: AfdE7clYs+k5zpk17ZzTn0rLeuHNBISq80U7619apZVNfAtqQ5Gc8/AZf4ZoquSKcsg Rmwv6fjQulMmK3M7PbUWJLRTGh3F+uoe1D0ylB2mMt17cNj2nDFCUPA3qIClBYoqESHp4Bfgncd bkMyc5c24PKIqohsYmTtihtbUrfDD1hNADXGnaOYp9XX3tLZrmEj10QkY0kFa+v71nhh0gKM8V+ vXTvYHAqfkv2zUa3ezo01V9YkldJyjT+8+lf1WrMcZQ/0LNsJnEfTjQIhitKEZwoOFt37RAce+7 N9Ic/Rkok4g6kVU8a4ClKtCFxRATd/I13euz2+dVqvYhje6a83Vrln1AoW3G/SK/BTl6Y2BHrQp lrDqgntVxhEmJSk3rK4aDk3caZnfqMADdKy0dAKOCFzq2fH/LDw== X-Received: by 2002:a05:6a21:e083:b0:3bf:7fa5:8922 with SMTP id adf61e73a8af0-3c1100092dfmr5538571637.2.1783845950583; Sun, 12 Jul 2026 01:45:50 -0700 (PDT) X-Received: by 2002:a05:6a21:e083:b0:3bf:7fa5:8922 with SMTP id adf61e73a8af0-3c1100092dfmr5538544637.2.1783845950089; Sun, 12 Jul 2026 01:45:50 -0700 (PDT) Received: from [192.168.1.5] ([122.164.92.133]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659d7c8bsm62094370c88.12.2026.07.12.01.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jul 2026 01:45:49 -0700 (PDT) Message-ID: Date: Sun, 12 Jul 2026 14:15:43 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla , Krzysztof Kozlowski , Neil Armstrong References: <20260711125740.3083236-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260711125740.3083236-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260711-mauve-skunk-of-contentment-f51be0@quoll> <6438237f-ccb4-4143-9ac7-43f5dcca955b@oss.qualcomm.com> <2b4448d0-81f8-410f-b849-0d957a2d2a17@kernel.org> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <2b4448d0-81f8-410f-b849-0d957a2d2a17@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEyMDA4OSBTYWx0ZWRfX82AaPQk0Pfvy rGRpA0gRGDbYb/ThoiVhEeaSPW9vCFADLw389iTbqIgND87+1036Qj/PSot4OTrHhJlV1ZvHJmo cymQCPfe3MzUeB2dLnkC9bOzYPhc274= X-Authority-Analysis: v=2.4 cv=OK8XGyaB c=1 sm=1 tr=0 ts=6a535441 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=tlK9sNgGSfv7srgBb5RqhA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=XwPME6NCRsOL8v_XlRkA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: RlODulNiY8w6XEVnQYtlrZDJdZLrfdXf X-Proofpoint-ORIG-GUID: RlODulNiY8w6XEVnQYtlrZDJdZLrfdXf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEyMDA4OSBTYWx0ZWRfX2fhKfv/A2k9n O9rvLpRg7a9zFKroa2RTLPWPWVVNTw2ZMPhI+Jis1GNFZDMdxoz8HdIwORnOXSZNdN52deiOD+i nV+WdwAezYEAPzKC8F9OEIVCI0SR2aNDaVBYU3ve/f0hN0lecdOJ3DCtFSOdBn062GCkR5cUINQ 4TQVgqcQvqUYa0Usz/BNm0vmjP/SgKlf/flqD83oaT95a2TDj+Ye0DJ2iox+js2oUlTDyS9wZAR EVcfmL99lTihtOTVug9DUGYmIKhzcsfaMZVOtlYq0a0A6QPjXBQAHbxzQdaEOvUcXTGZ/rIqBhI sTpjKHVt0PtdNyIVlIjUM3FnNwjtmfGA1msz58fqLTwrduv6SPX5G4sLLzI0zZtI6ZzKFgNjNZM DEFErDlR6GXsZJ1/y01kBeRFI0chIkH5ahshZxzXgVLN9mTrpKzQggIuZYALa/hlK0rES79N1Mg QeEvClZdWS0jenJrAQw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-12_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607120089 On 7/12/2026 1:41 PM, Krzysztof Kozlowski wrote: > On 12/07/2026 08:44, Mohammad Rafi Shaik wrote: >> >> >> On 7/11/2026 8:41 PM, Krzysztof Kozlowski wrote: >>> On Sat, Jul 11, 2026 at 06:27:38PM +0530, Mohammad Rafi Shaik wrote: >>>> Extend the qcom,q6apm-lpass-dais device tree binding to explicitly >>>> describe Digital Audio Interface (DAI) child nodes. >>>> >>>> Add #address-cells and #size-cells to allow representation of multiple >>>> DAI instances as child nodes, and define a dai@ pattern to document >>>> per-DAI properties such as the interface ID and associated clocks. >>>> >>>> On platforms such as Monaco and Lemans, third-party codecs are hardware >>>> wired to the SoC and do not always have an in-tree codec driver to manage >>>> their clocks. For these designs, clock line enablement must be driven >>>> from the platform side, and this series provides the necessary support >>>> for that. >>>> >>>> On QAIF-based platforms such as Shikra and Hawi, responsibility for voting >>>> I2S MCLK and BCLK has moved from the DSP to the kernel. This series >>>> introduces the required device tree binding support to represent and >>>> vote for these clocks from the kernel. >>>> >>>> Co-developed-by: Srinivas Kandagatla >>>> Signed-off-by: Srinivas Kandagatla >>>> Reviewed-by: Krzysztof Kozlowski >>> >>> Drop my tag, you made a important change to ABI. >>> >> >> Ack >> >>>> Tested-by: Neil Armstrong >>> >>> Drop, you cannot test a binding (in the meaning of Tested-by tag). >> >> Ack, will drop Tested-by tag. >> >>> >>>> Signed-off-by: Mohammad Rafi Shaik >>>> --- >>>> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 58 +++++++++++++++++++ >>>> 1 file changed, 58 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>>> index 2fb95544db8b..f3a8b12d7fc8 100644 >>>> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml >>>> @@ -21,6 +21,49 @@ properties: >>>> '#sound-dai-cells': >>>> const: 1 >>>> >>>> + '#address-cells': >>>> + const: 1 >>>> + >>>> + '#size-cells': >>>> + const: 0 >>>> + >>>> +# Digital Audio Interfaces >>>> +patternProperties: >>>> + '^dai@[0-9a-f]+$': >>>> + type: object >>>> + description: >>>> + Q6DSP Digital Audio Interfaces. >>>> + >>>> + properties: >>>> + reg: >>>> + maxItems: 1 >>>> + description: >>>> + Digital Audio Interface ID >>>> + >>>> + clocks: >>>> + minItems: 1 >>>> + items: >>>> + - description: MI2S master clock >>>> + - description: MI2S bit clock >>>> + - description: MI2S external bit clock >>>> + >>>> + clock-names: >>>> + minItems: 1 >>>> + maxItems: 3 >>>> + items: >>>> + enum: >>> >>> That wasn't here and that's also not correct, usually. Especially that >>> it does not fit your clocks property. >>> >> >> The reason for changing this to enum was that some hardware may expose >> only a single clock, which can be bclk or eclk instead of mclk. With the >> previous positional const definition, such configurations fail schema >> validation because the first entry is always expected to be mclk. >> > > master clock feels like something should be present there always, but if > that is the case, then you need: > minItems: 1 > items: > - enum: [ bclk, eclk ] > - const: eclk > - const: mclk > Thanks for the example. I will follow the same approach and update the binding accordingly. Thanks & Regards, Rafi > Best regards, > Krzysztof