From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DC312230A; Thu, 4 Jan 2024 13:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IIIPJc9Q" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=em8656SBmFHuCoSI6Hw7pHiwOvfMbL7DUtlbPOdcosg=; b=IIIPJc9QzwaijPod1f+lYfIUlU AYiygKn9dmrcgfr6FR8efPlyPxk7oGMaN60icGgMu2P2bEcU69iCW1SSbkdk/5b7dVh1BiBOujbRP WUxVzR6jyKZ7V5NdAC/HyYy+R13rrQ3o4w8K3QiHH7J3Wk3BZ+QN0meADrxgLU1N2zq0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rLNKd-004LX7-Ub; Thu, 04 Jan 2024 14:00:19 +0100 Date: Thu, 4 Jan 2024 14:00:19 +0100 From: Andrew Lunn To: "Gan, Yi Fang" Cc: Greg Kroah-Hartman , Andrew Halaney , Javier Martinez Canillas , John Stultz , "Rafael J . Wysocki" , Jens Axboe , Russell King , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?iso-8859-1?Q?Beh=FAn?= , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Looi, Hong Aun" , "Voon, Weifeng" , "Song, Yoong Siang" , "Lai, Peter Jun Ann" , "Choong, Yong Liang" Subject: Re: [PATCH net v2 2/2] net: phylink: Add module_exit_stub() Message-ID: References: <20231221085109.2830794-1-yi.fang.gan@intel.com> <20231221085109.2830794-3-yi.fang.gan@intel.com> <0f85171e-cb9c-47dd-bb7d-f58537e24a54@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 04, 2024 at 09:45:47AM +0000, Gan, Yi Fang wrote: > Hi Andrew, > > The function phylink_init() is introduced by others. > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-6.6.y&id=eca68a3c7d05b38b4e728cead0c49718f2bc1d5a > The module_exit() is added by referring to > https://elixir.bootlin.com/linux/latest/source/kernel/module/main.c#L738. > Since the macro function is rejected, I will send a V3. > Let's see if Rusell King has any comment. Thanks. Please don't top post when using linux kernel mailing lists. > > You are missing justification it is actually safe to remove phylink. Maybe Russell > > King deliberately did not implement > > module_exit() because it can explode in interesting ways if it was? You still need to explain why it is safe to implement it. Andrew