From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DECA2E54A2 for ; Fri, 20 Mar 2026 17:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.10 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774028990; cv=fail; b=ThfaDOQACkbpvpohdKqJBORSRlfhcEtB1M6ysM/R+jxCE5YO8nOcaFGH0b80dufV17yGJCo8bwB0gHvXTvSZ/pFhIGWsayEYce1t6Wp/clfETe6A0MyVH1152s0GNtAO7GdhvIl2RBBWRhtUrW/c0rbL6+QcWL+6yZVMi/FsAbA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774028990; c=relaxed/simple; bh=cmzMZBm3QPTZ48Cbo9XpTolEE7bM4BKFf5UuvCfzS/Q=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=QXElHDP2gX+AWVyeDj0EU4esAKqe5j0Ol77gOXxJMduihIzfzwsJDnZtbL4uKsE4/d49qIWuiozr5su7BwPQaUzqRTtAxJsAXYq3km3LoAqquaf8+sXagMYK7yP+xe4DavSScEgXRzDvGmNc0pmkOaUwMe1nJ66YvYaqD20UAIo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PI3JrlPM; arc=fail smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PI3JrlPM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774028989; x=1805564989; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=cmzMZBm3QPTZ48Cbo9XpTolEE7bM4BKFf5UuvCfzS/Q=; b=PI3JrlPMd/LCt2EFtYn6QTeg/tMsMhWs1DdS2xFEEBt7ALHrlPM8PfOV qIWZCmYQTeMlvnqt2veld0YvBMSjB+SaqXVK2xHt2fNMzkFuF5+N9xYhX /HfyzZKeZwODynpKpVSAYwEkTJLMj9KEAConXnnUqCMaxAwENrmD4BA9Y MczYJd1Z51yFSVlJtBsVchEkF7wd2AQUVx+Ewn1O6I9qwIjjHwx9FY3Kd WfmmKwJLD7aqNVBGHx+boJVB7hWgDOC53c7sN0xpSOoat1kxJSul5bM/c 7eXOWIR138AvkDv+1t+djqjYERkKGTY8AEwd8slZsh/xNuTM+G8F6TYcW g==; X-CSE-ConnectionGUID: ml3Ie/muTk2ZXZNV3iJY5A== X-CSE-MsgGUID: Md8ay9y3QWyx9eIwinIfIw== X-IronPort-AV: E=McAfee;i="6800,10657,11735"; a="86483823" X-IronPort-AV: E=Sophos;i="6.23,130,1770624000"; d="scan'208";a="86483823" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 10:49:48 -0700 X-CSE-ConnectionGUID: EiW3MkLpR+u8y/jeHr7u9g== X-CSE-MsgGUID: qhsx8mylQMWvnrll0nEqhw== X-ExtLoop1: 1 Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2026 10:49:48 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 20 Mar 2026 10:49:47 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 20 Mar 2026 10:49:47 -0700 Received: from DM5PR21CU001.outbound.protection.outlook.com (52.101.62.62) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 20 Mar 2026 10:49:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZiMbiDMQFuwhX5imQyGUO1aAMHaQLi36A/cIMv7YueITqr6TC1FWrVU3VVLmBCoal7deBEg8SMZvAs/DTFseDrT9/BzbvE4mTrSmiRQae2V9j69s9nJSl+Yk4NtMS6M4yQNFB0Ii9Rjp9Glr5m25wBbgm5vnpClo8tTbHdiT+4dixQHt9SCNZeXKBl7mV5olNu67vdROrp0/AYkQR+FrJqgrM65QSyjgRVQZpB9AMEF3fYALPj1BLIbrmQONYpMLme/TFmDIA49WkPJTqnnidXC2WmP5psHuLeos2eo+b/FyL1MQ+BOQfwlb2C6rpTPhuQ9rYITgkPUZOFQugkcJ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s7Y+hv5caRpX9xMN9e4j6pX51VjWPrMr21nipqNOYL8=; b=Min46zusoPJqGyI5+PGIdEGzVZe1HHbKp7kXPtAb1lPSqKfQuXsUUGZJ/d7G2zE6AHytdXmR0olPRH7BBRPydzN8BgMGTpH51SZPE4oZZwafVHZ6gj/bQIxznzgGLvo3xzwGzKZdIUUbAcPi1CvxDxijF8kp2UGP1mOkTj1JGG+OoritbFGgEhzyl8HnLPO/DNQMvFkMZFrALg3MH677kJMwO4b/K8U27mM7aCCIekio07QjgR1RKGk9ySLNnxy5+DCYTp1uhFx7oIiYhY9OP+yNPzYQWChmFsHPmQzuPTmymfVz2sJ6C2xGQBvTtVQo6sUTwg9UCKo+CZcCuJ3qww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) by PH7PR11MB6953.namprd11.prod.outlook.com (2603:10b6:510:204::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.9; Fri, 20 Mar 2026 17:49:44 +0000 Received: from DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246]) by DS0PR11MB7997.namprd11.prod.outlook.com ([fe80::24fa:827f:6c5b:6246%4]) with mapi id 15.20.9745.007; Fri, 20 Mar 2026 17:49:43 +0000 Message-ID: Date: Fri, 20 Mar 2026 10:49:41 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] x86/cpu: Remove X86_CR4_FRED from the CR4 pinned bits mask Content-Language: en-US To: Borislav Petkov , X86 ML CC: Nikunj A Dadhania , LKML , "Borislav Petkov (AMD)" , Dave Hansen , Peter Zijlstra , References: <20260320115417.4156-1-bp@kernel.org> <20260320115417.4156-3-bp@kernel.org> From: Sohil Mehta In-Reply-To: <20260320115417.4156-3-bp@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0PR05CA0155.namprd05.prod.outlook.com (2603:10b6:a03:339::10) To DS0PR11MB7997.namprd11.prod.outlook.com (2603:10b6:8:125::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7997:EE_|PH7PR11MB6953:EE_ X-MS-Office365-Filtering-Correlation-Id: c6635183-8fa6-4e35-6c71-08de86a91156 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: 9HTpjg16sjjFbzWcTZrbPw2WI98Li++k/AOJhVkyHrQBrR/RatOwyCtO69Al8rUHvYy8kQVhQs1xPTDsqNb2GCMJKENUzahj8BE7hw9i4g3s/w8h65PBrrZslmcyJYaThO3MW7iL3ShiNfEWEU7BOAepEBxlzDHCU4pRK0lErYfM9sc6onjhdR3polEjX/3gpeJiK2xrHlqhQn4Y2YK2ZN6Geza/rZ3wD0Qd2oFZlRdEn4KCcYltx+PNatS9kg+YSrpEf7R/rAUg/OAEWTVQMddONhitTiH/LaZgFc8gx64kcAjjZxjs9CfjlOet90eMj45CD/BVDfj2CrOYU/MMAis8+pTbz06R2TpavUnrY4yEUzd+kbuEOrVNrcWC0Ug4Jb7nmMeFPKp2r6B+DP5fJ8/t0h2OjK4b1Yx+ItIa0Hq3aPCJy9HeVoYXp/JE4+qjMZYW7OG+gWT380MufcVTppGtvRelmEX46WLQRN2lCCPjTI0CrJ5SJIXx7MGicEE/r+kWmZm2+L0PaKrKDI6zlr/Bzs/VmdgKqVcSYHwd7DSll8bYeaPq4yDKYM6RIHJ2lyVSRkpO+tHjaU5mb2I/UStGxm7ZC4htVDqC/g7M1C0OUGjaA7lcucH29LRrgfSOQfvPsT9Hmq6Yj9RKglD9cpqAhI2CdTBmSO/5HhMnBKRaiurX7/H0ii5DTdJ7/L8JlxFgVq/8MPRnXC/QOoi3JNAhzOaTXRl86P0c1ZaYNJcoQGAlx4nxQmLr83DkXOkq X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7997.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHQ5WGVyTWR6djVESllVSVorMnRjaVZKQXl4OGUzSlBldTM1eEVMRmQ0cEsx?= =?utf-8?B?VUdXNUpyNDdzakJ5eUgvM1ZRQktSVHcxOXRQNy9Xdk10d1hZUHc4dmlaVDV0?= =?utf-8?B?SHMyMlRZTHI4c2t4cy94SSsxbCtZN1JLN3NhZnh0ZENiWWs2U05iK2REWDhO?= =?utf-8?B?Uyt5YkowOTAwTmFNYjQwajlKbjFoVFVJeVhZUncwUzBPVlhKUUNRTG5aUEZ6?= =?utf-8?B?N2FGUVpqdTdJd3o0MlZoU1E1aWRhVGRFOEZsd1RBT3B1V28xQ1ZPaTZ1N1Rp?= =?utf-8?B?amp4V0hMdTN2SEcwck1IdkhIZ3h3SXZWc3lock4xY0xWZTBocldRMkc1TFM5?= =?utf-8?B?UXJZTFUzSUNjMkczbGpyZEVjS0xrWEVQYVpPTCs3dkN2NTc1TFhrekE1UDl2?= =?utf-8?B?V3Z2bTJEdWhpNS91Tjk5QmFMRWVLaENMNldJblVNZFNTZExDeFhrMDFwaVRH?= =?utf-8?B?SXNDMFV4OEd6eDk4WjNCanJsa2xPVm1NaGNqaU1BejFlUEdyOW1QZVlZMUhU?= =?utf-8?B?V1Fvb05ET04wOC83Sjl1ZEtEcmlHbENTN3FZWVdZZ09YTnRNK3dLL01GekdO?= =?utf-8?B?WktOT3lraTNmSU40OUlNZkx0VWtyRk9LZU1qVnhDMUxLMWhGaThiZFBmTjRV?= =?utf-8?B?OURZVEY5Z0VSc25FWS85NzRkYkQyS1g3ZDRCclp6TmVKelNXWDNyeFM4bFF2?= =?utf-8?B?bjJLWHE3RVFuMlY5NDhDMGw2by9KWG8yclMzZERlUC9BZEZ2d0did1Y2OFVq?= =?utf-8?B?dmI3NUN0dnV0dERzMlpCNFA1Y09mT3dqcTZMOXpQNGQ5dlNZSVdXT3BRZGhU?= =?utf-8?B?NllCUmNyTDhqVnI4bmQwanE4SFdXYXpRdDRSd21lME53T1Mvd2dkamEvY2hs?= =?utf-8?B?VWg2OGMxaXBEdVoxbmIvbWVpQTBoeTUyUzlUaDJjU0xQalpDWFJWQ3Jac1h0?= =?utf-8?B?SENteEFJd2J2ZGVJTzVNR0hMUGd4ZzVhK0NYOTdKTHo2T3JIMk13WE1Vd3Va?= =?utf-8?B?alJmaDVLNzVzRHluQjZVWXZLZjU2d3lXK3lUVUtaa2dJR3o1WEtob0k5L005?= =?utf-8?B?OS9JSDA1a2VJWE9TZjdNblZPd0xOcGtWRDhHQXdVcjBPY0x2M2dFZVljU3NP?= =?utf-8?B?cFFIZVdTbGdNcTdOZWFRKzdlOXRxdDU0UEh5azZ3UWY0OGlqRzB2amM0a1ZW?= =?utf-8?B?RVBZaFU5L2FJU3VUQzdHYjJRelJUWjA2c1F1dUJxa3JLMndobzBZaFhaMXl3?= =?utf-8?B?dHVFZFlIeVgzbGdJTHJONDlKM3o2VDVjTEhTcjh5dzgzNTNsOXEvSFMvYUJk?= =?utf-8?B?d0R3Q0Q1bkFVT0dOUFBtRnhSM2pCS2p5OWVyVnB1TG1TSWd6Q3Y3YXFyRmly?= =?utf-8?B?c2taZ0J5aTg0enFHUERDT0N4QjRtdVN4VE5wOGJDMnhXVGlUbGZZMzg2cllt?= =?utf-8?B?b1VaWDFmVXFKYkxDWWN0Q2tDbE8vOTd0L0RGUDZ5TExzZ0pJT29mdDRmR2tL?= =?utf-8?B?anJ4TmhsbFRuNjdSN0lYWFI0aFcwdCt5c0J2dTFucDhpb1duQzNvTm5WODdE?= =?utf-8?B?emNCQytnZmNlcXl6UWVQR3NmMFVCRjZZVGhockdPL0kzOUo1Sk1PMnF5Q3ZS?= =?utf-8?B?NzV2QXIvc2ZMczZuOGdEM3B3dHRQU1BraXp3ZGpINUxrUWIySjZxODBma1lm?= =?utf-8?B?bXcrSXN2UDh1b1cwWnB4ZmpuU0pGbVhXRmd5WStaL0RqOXBmZ0JrWXVrOERR?= =?utf-8?B?R3ZuZlpESXh0OXlKeVJmSUFZTXlvME5NaTVNZm9vdDgxcEdORXVFSW5uMmRy?= =?utf-8?B?Z0dOOUp6NHR3RFQxOGlVK1B1YTJnY21WKzltb0xybVkzcncxNm5lbSsyd1JH?= =?utf-8?B?YlNUbWFxcWJNYnBxZjlzZWJSYUxuNFVBUTd5RkQ4VGpuRnJwRVc4elQ0Qmk5?= =?utf-8?B?a3VxMWowQjh5RHAzenlZQVE4aVh4NjBJQ0pDWmRuYTdlRFVCQW1XQWtFQ0M0?= =?utf-8?B?MVBIaDFUS0xuNCtWdFdLMTJoZE5uTUFaYXNYUmZoRlhJc1ZEYlJRUURKTHdL?= =?utf-8?B?WlhwQVFnQTlsVFBYSStkekJlZG16T0Ftd1VqL3hwdVRFcUtFb0I1a21IdFNx?= =?utf-8?B?ZUgwYVRuRHJncTVSNjB6UHpXdzRoZnNla1RjZ1FPcnI3dk1Yd0M0YjBsMVlp?= =?utf-8?B?QjE3MWI3MmNCSGVVSWpLMEhMMHlGWEM1bHNPdFdyQUE2NW9jK2RaMFQxOUtL?= =?utf-8?B?eTlrMVd6czZkTnllMm8xU0FtMkdITHpTVVZFUlZJcHVMVnQ1V0hrQmNHY0Ju?= =?utf-8?B?UzM2MGVqV1BoTVBDaXpYbGdVUnpKVnMvUTdGRlY3Uk5JQ0sxMzBnUT09?= X-Exchange-RoutingPolicyChecked: KSF32a84WsYrj+pN5di7r5KZZF2zSHuCEvJgmcXJ9uh07w9kM0kMYaKvgJneN4q9QWH6LzHN4rnsoL5N4G8Ch97qD41zD2oOCPlpMNfYdQGEdaO2fJgAV/w8BEJoAk1+FMh1FxXWOiPMzEtSUEbNN9wHOTBD3kxx/jH9UIqhiEVygE5rcOe9RFHASNwH20y1PUMRO74MC4t1gGYulyuz4by8rPL4aca30tYtPCPM1zLvBEoP1F6P4jJ15B4lRo+rQM63i8wMFjsC6S6zNi0SPTjnvJt03P9TUjnaR7vHpya1dKYPtYy+mDspZAaHGytvzoaYJlQzAf9uKS95irQIAg== X-MS-Exchange-CrossTenant-Network-Message-Id: c6635183-8fa6-4e35-6c71-08de86a91156 X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7997.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2026 17:49:43.3535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: utIJVcsHL7/DAfTqgu3ZvFrz9/aso8l38OectlLuibRsn0/+h9JSfzZDrLVKXmKVBrLDuXJhkYF/jXGyb3rB+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6953 X-OriginatorOrg: intel.com On 3/20/2026 4:54 AM, Borislav Petkov wrote: > So, instead, remove the FRED bit from the CR4 pinning mask, thus > obviating the need to temporarily disable CR4 pinning. > > If someone manages to disable FRED when poking at CR4, then > idt_invalidate() would make sure the system would crash'n'burn on the > first exception triggered, which is a much better outcome security-wise. > > Fixes: ff45746fbf00 ("x86/cpu: Add X86_CR4_FRED macro") > Suggested-by: Dave Hansen > Suggested-by: Peter Zijlstra > Signed-off-by: Borislav Petkov (AMD) > Cc: # 6.12+ > Link: https://lore.kernel.org/r/177385987098.1647592.3381141860481415647.tip-bot2@tip-bot2 > --- > arch/x86/kernel/cpu/common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sohil Mehta