From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C7CC433E5 for ; Fri, 24 Jul 2020 09:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B21420674 for ; Fri, 24 Jul 2020 09:20:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728092AbgGXJU1 (ORCPT ); Fri, 24 Jul 2020 05:20:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbgGXJU0 (ORCPT ); Fri, 24 Jul 2020 05:20:26 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7CE4C0619D3 for ; Fri, 24 Jul 2020 02:20:26 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1jytsP-00047h-Im; Fri, 24 Jul 2020 11:20:25 +0200 Subject: Re: [PATCH v4 2/3] dt-bindings: arm: stm32: document Odyssey compatible To: Marcin Sloniewski , linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, mani@kernel.org, sam@ravnborg.org, linus.walleij@linaro.org, heiko.stuebner@theobroma-systems.com, stephan@gerhold.net, lkundrak@v3.sk, broonie@kernel.org, allen.chen@ite.com.tw, robh@kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org References: <20200723193737.190291-1-marcin.sloniewski@gmail.com> <20200723193737.190291-2-marcin.sloniewski@gmail.com> From: Ahmad Fatoum Message-ID: Date: Fri, 24 Jul 2020 11:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200723193737.190291-2-marcin.sloniewski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/23/20 9:37 PM, Marcin Sloniewski wrote: > Document device tree bindings of Seeed SoM and carrier board. > > Signed-off-by: Marcin Sloniewski > Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > index 790e6dd48e34..22b9aaa75eee 100644 > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > @@ -39,6 +39,8 @@ properties: > - enum: > - arrow,stm32mp157a-avenger96 # Avenger96 > - lxa,stm32mp157c-mc1 > + - seeed,stm32mp157c-odyssey > + - seeed,stm32mp157c-odyssey-som Did you run dtbs_check over it? I think this should fail. You want something like: # Odyssey SoM boards - items: - enum: - seeed,stm32mp157c-odyssey - const: seeed,stm32mp157c-odyssey-som - const: st,stm32mp157 (Note 3 items vs 2 in yours) > - shiratech,stm32mp157a-iot-box # IoT Box > - shiratech,stm32mp157a-stinger96 # Stinger96 > - st,stm32mp157c-ed1 > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |