Re: [PATCH] arm64: dts: rockchip: Add RTC support for RK3588

[Christopher Obbard <chris.obbard@collabora.com>]

Hi Shreeya,

On Tue, 2023-04-04 at 17:28 +0530, Shreeya Patel wrote:
> Add DT node to enable RTC support on RK3588 board.
> 
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>

nit: It'd be great to make the subject something more descriptive about the supported hardware, since this patch doesn't enable the RTC for _all_ RK3588 boards your subject could be a bit misleading.
Something like "arm64: dts: rockchip: Enable RTC support for Rock 5B" could be better.

Reviewed-by: Christopher Obbard <chris.obbard@collabora.com>

> ---
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 95805cb0adfa..a32bfa8d914a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>         };
>  };
>  
> +&i2c6 {
> +       status = "okay";
> +
> +       hym8563: hym8563@51 {
> +               compatible = "haoyu,hym8563";
> +               reg = <0x51>;
> +               #clock-cells = <0>;
> +               clock-frequency = <32768>;
> +               clock-output-names = "hym8563";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&hym8563_int>;
> +               interrupt-parent = <&gpio0>;
> +               interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
> +               wakeup-source;
> +       };
> +};
> +
> +&pinctrl {
> +       hym8563 {
> +               hym8563_int: hym8563-int {
> +                       rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> +               };
> +       };
> +};
> +
>  &sdhci {
>         bus-width = <8>;
>         no-sdio;
> @@ -42,3 +67,5 @@ &uart2 {
>         pinctrl-0 = <&uart2m0_xfer>;
>         status = "okay";
>  };
> +
> +
> -- 
> 2.30.2