From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D906211475 for ; Mon, 3 Feb 2025 22:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738622384; cv=none; b=YkIaA/c881kmpZ8n2CeUDZFynnEpd2rKF6n1hkFbd723ENsHYFtyLl/h3R1Q+o8pEV554G5htSpNJX6aUS6kAVt0y5VCvuGwhqb4B7ZkwRnDlkRpbVUABnUUjrl0sln66dORgaUkgrBR5uKZjYAAkLAh+W+6Hat5e5IJ9RjUl3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738622384; c=relaxed/simple; bh=1Q81xARcDqJnn1HJ52uZiPtHrThD/Lg7LAxKl0LKqW4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EFvdBslBKOa6zznQxp+f+TfQJ3BoeQLkASHyi7B1DP1PzFZYGBLCYHiCj2dUlYVd2BcznB89DZwRe/hlyZDb4Wg0b5BptbKTOAmktdni3k1GeziNxZR4wgXV64dABYoYa1t5YNtPJFI9RK3J6X44SaLfOTm6c8zyghVRZmIewRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=aPQPmJ15; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="aPQPmJ15" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-29fe83208a4so2486459fac.0 for ; Mon, 03 Feb 2025 14:39:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1738622381; x=1739227181; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7FuOTM/5uq/stUm6NdRcMUJvmEyi2R5GtNjpDeIV2Ho=; b=aPQPmJ15Elz6EyybHgCejqIswr6xI/YwwhsV8o9hsaPsktE38IzMJsNBUtTxo0lHVJ d5/bzL9Ol2TeAbPw4QQ+erQ9PXa4CCrjw0qexljVFSd6gW90iQ2ila46nIgpMRPkoTZB pnczcpTCKki/Ohld+kjX4wDf7uVrNEY2kueUCJ7hSO/ig3iiyr3VUnU1LryALo2uOuFH 2lfdmn0wq1uG4fOasqrbW3QP9Fc5MbVxPu8iE8/OFd6/tTh2jjNviByNj91xjtMl3ypm +r8dceFYWeC0RZhEsSs4hnqv/7Wn/9qivtGIHpVtMBlnW0bAoGhvCtMFN1oPY9ihyOmc 07DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738622381; x=1739227181; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7FuOTM/5uq/stUm6NdRcMUJvmEyi2R5GtNjpDeIV2Ho=; b=V2Oece32QlpQ6b26eGtqcB60wX3Ha9RTHaGs+W1OzVkONhoNaAVAHRGA2wLLTR8bYm mkJkj3TehEl6z9S5EmHfTZR8rNvvhBCcGv6kZNjJztxJZol0ieZrXCyF/D2YwDprVzHn vR+NrcBv/mcLLvP9/TfJgufLJS7Q/SFee6xejrR4pP0/4tXIeYMH906ibRSI4JLuLKo3 G3MoCvsGz+DbD2y0OtWk41GEWISJ6YohDw2phSvB2VewV90z/LkXyxziQBlv42gulFQ2 5B5sR8rYQTnYZux7jfczrGxBfd+Jm6XmFLSHWHacxrdN2CuhNHBImwphKGB7ct1dQtSM fSGg== X-Forwarded-Encrypted: i=1; AJvYcCU6C9Q+lOo3JJ95+RPtmHjfVoxelots+6lieVyuWM2uI3MNJTb9/OUGRV/cvoKh2IaLfY9YNyIBl48N0i4=@vger.kernel.org X-Gm-Message-State: AOJu0YzFvJ1azmgN+tXqG69uDA31Ocgtlmtkihsj7Ot75odGyFrJ1iPW dQyylpwSfUQmc5ernH0nDbI/kcEv1faKPXrtiJSpFQxZN105h4PsuMge8eLZRpo= X-Gm-Gg: ASbGncsHTit6wOUSXmu+9ET7t374oNuO+0FbHfG2/8gYJfR/P6BkMtrHfqQvFM04Yal AuKnRjybNsk5t5T6j5Kj6vYL8DmoH0CWzbrfyNl3kN2wJFZhK62sMlGqcnrx3ip4EibfTd2MVIX NREtOwWqu+bG0FZgIK3A+O89eBZnc/bA1yOpW++owVyyjfxn9ZUv16NjEGaN+ohC/vfEikJif6F C2Kpo7ORf8VvgXPvtmpTF2bUMK8+ZfoKLyIKBDNG5F8Zr2ZxtRw7UncWXrKUJtaREsOndMq8P9N SHXU5avBnVqSZCo2HdA0/e0k+hQaBJgb6fpeiwlJ7vrflvUnQQOO X-Google-Smtp-Source: AGHT+IGaQH53OWXI018UHR+o3pOTGmyURoCZWzCbG0RQLmUMPYxUrDO3psb2lp4Kuy+CvmoE1eZtzw== X-Received: by 2002:a05:6870:1b14:b0:29d:efe8:5a49 with SMTP id 586e51a60fabf-2b3e7450705mr688192fac.3.1738622381243; Mon, 03 Feb 2025 14:39:41 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2b35619ec30sm3589105fac.14.2025.02.03.14.39.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2025 14:39:40 -0800 (PST) Message-ID: Date: Mon, 3 Feb 2025 16:39:38 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/13] gpiolib: add gpiods_set_array_value_cansleep To: Andy Shevchenko , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org, Linus Walleij , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?UTF-8?Q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai References: <20250131-gpio-set-array-helper-v1-0-991c8ccb4d6e@baylibre.com> <9931433b-5cde-4819-ac96-eea4f1f0f1f2@baylibre.com> <072be5a9-e0fb-4073-85b3-4a8efcafae09@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/1/25 1:47 PM, Andy Shevchenko wrote: > On Sat, Feb 1, 2025 at 6:22 PM Bartosz Golaszewski wrote: >> On Sat, Feb 1, 2025 at 5:17 PM David Lechner wrote: >>> On 2/1/25 10:14 AM, Bartosz Golaszewski wrote: >>>> On Sat, Feb 1, 2025 at 5:09 PM David Lechner wrote: >>>>> On 2/1/25 4:36 AM, Bartosz Golaszewski wrote: > > ... > >>>>>> This looks good to me except for one thing: the function prefix. I would >>>>>> really appreciate it if we could stay within the existing gpiod_ namespace and >>>>>> not add a new one in the form of gpiods_. >>>>>> >>>>>> Maybe: gpiod_multiple_set_ or gpiod_collected_set...? >>>>> >>>>> I was waiting for someone to complain about the naming. ;-) >>>>> >>>>> I was going for as short as possible, but OK, the most obvious prefix to me >>>>> would be `gpio_descs_...` (to match the first parameter). Any objections to >>>>> that? >>>> >>>> Yes, objection! As far as any exported interfaces go: in my book >>>> "gpio_" is the prefix for legacy symbols we want to go away and >>>> "gpiod_" is the prefix for current, descriptor-based API. Anything >>>> else is a no-go. I prefer a longer name that starts with gpiod_ over >>>> anything that's shorter but doesn't. >>> >>> Oops, that was a typo. I meant to write gpiod_descs_. >> >> Eh... the D in gpioD already stands for "GPIO Descriptor" but if >> there's no better option in your opinion than I guess I can live with >> that. > > gpiod_set_many_value_cansleep() ? > OK, taking all these suggestions into consideration along with having recently come across regmap_multi_reg_write(), I think I'll go with: gpiod_multi_set_value_cansleep()