From: Joe Perches <joe@perches.com>
To: kernel test robot <lkp@intel.com>,
Jeff Layton <jlayton@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>
Cc: kbuild-all@lists.01.org, ceph-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ceph: Use generic debugging facility
Date: Sun, 16 Aug 2020 16:45:13 -0700 [thread overview]
Message-ID: <b1c625528af035cc74a8f17b903e17e5f15f4a23.camel@perches.com> (raw)
In-Reply-To: <202008170710.BoRBUoeo%lkp@intel.com>
On Mon, 2020-08-17 at 07:03 +0800, kernel test robot wrote:
> I love your patch! Yet something to improve:
[]
> All errors (new ones prefixed by >>):
>
> net/ceph/ceph_common.c: In function 'parse_fsid':
> > > net/ceph/ceph_common.c:227:2: error: implicit declaration of function 'dout'; did you mean 'dput'? [-Werror=implicit-function-declaration]
> 227 | dout("parse_fsid '%s'\n", str);
> | ^~~~
> | dput
Right, thanks, I didn't update net/.
next prev parent reply other threads:[~2020-08-16 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 22:04 [PATCH 0/2] ceph: Neaten debugging Joe Perches
2020-08-16 22:04 ` [PATCH 1/2] ceph: Use generic debugging facility Joe Perches
2020-08-16 23:03 ` kernel test robot
2020-08-16 23:45 ` Joe Perches [this message]
2020-08-16 23:50 ` kernel test robot
2020-08-17 0:13 ` kernel test robot
2020-08-16 22:04 ` [PATCH 2/2] ceph: Remove embedded function names from pr_debug uses Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c625528af035cc74a8f17b903e17e5f15f4a23.camel@perches.com \
--to=joe@perches.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®