From: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Bard Liao <bard.liao@intel.com>,
sound-open-firmware@alsa-project.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SOF: Intel: Remove duplicate include of shim.h
Date: Thu, 03 Jun 2021 08:32:22 -0700 [thread overview]
Message-ID: <b1c971fd42af39d93de71568b3015520e8d1808a.camel@linux.intel.com> (raw)
In-Reply-To: <1622689193-29884-1-git-send-email-wanjiabing@vivo.com>
On Thu, 2021-06-03 at 10:59 +0800, Wan Jiabing wrote:
> shim.h is included twice.
> As shim.h is not related to later header file,
> keep one which has comment and remove the former one.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> sound/soc/sof/intel/pci-tng.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sof/intel/pci-tng.c b/sound/soc/sof/intel/pci-
> tng.c
> index 4ee1da3..4bded66 100644
> --- a/sound/soc/sof/intel/pci-tng.c
> +++ b/sound/soc/sof/intel/pci-tng.c
> @@ -15,7 +15,6 @@
> #include <sound/sof.h>
> #include "../ops.h"
> #include "atom.h"
> -#include "shim.h"
> #include "../sof-pci-dev.h"
> #include "../sof-audio.h"
>
Thanks for the patch.
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
prev parent reply other threads:[~2021-06-03 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 2:59 Wan Jiabing
2021-06-03 15:32 ` Ranjani Sridharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1c971fd42af39d93de71568b3015520e8d1808a.camel@linux.intel.com \
--to=ranjani.sridharan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®