From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751768AbcFAWb4 (ORCPT ); Wed, 1 Jun 2016 18:31:56 -0400 Received: from ausc60ps301.us.dell.com ([143.166.148.206]:4293 "EHLO ausc60ps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbcFAWby convert rfc822-to-8bit (ORCPT ); Wed, 1 Jun 2016 18:31:54 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=Usw9GLdcl3pIAdnIj7i756JmqOkUzTMb19ATA12DiRG6H784Js6Z/J/k bynsAEaiWTosR242FXBlRiixE0XERnGyB5bzHtoeuALcY3Ull3Sd0H7Is hXubXhX4ujAvXrBEJC3ykYDKi5YgoGUA3zApyGIPHAxtO9Bcx/MUvcbvD Q=; X-LoopCount0: from 10.175.216.250 X-IronPort-AV: E=Sophos;i="5.26,403,1459832400"; d="scan'208";a="829554126" From: To: CC: , , , , , Subject: RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Topic: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address Thread-Index: AQHRvE+xMb9mMEf0UUOJaXsVnbGJUp/VhKOA//+sjgA= Date: Wed, 1 Jun 2016 22:31:52 +0000 Message-ID: References: <1464817844-27206-1-git-send-email-mario_limonciello@dell.com> <20160601222703.GJ31982@lunn.ch> In-Reply-To: <20160601222703.GJ31982@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.208.89.195] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Wednesday, June 1, 2016 5:27 PM > To: Limonciello, Mario > Cc: hayeswang@realtek.com; LKML ; Netdev > ; Linux USB ; > pali.rohar@gmail.com; anthony.wong@canonical.com > Subject: Re: [PATCH] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > On Wed, Jun 01, 2016 at 04:50:44PM -0500, Mario Limonciello wrote: > > Dell systems with Type-C ports have support for a persistent system > > specific MAC address when used with Dell Type-C docks and dongles. > > This means a dock plugged into two different systems will show > > different (but persistent) MAC addresses. Dell Type-C docks and > > dongles use the > > r8152 driver. > > > > This information for the system's persistent MAC address is burned in > > when the HW is built and avilable under _SB\AMAC in the DSDT at runtime. > > > > More information about the technology is available here: > > http://www.dell.com/support/article/us/en/04/SLN301147 > > > > Signed-off-by: Mario Limonciello > > --- > > drivers/net/usb/Kconfig | 1 + > > drivers/net/usb/r8152.c | 37 > +++++++++++++++++++++++++++++++++++++ > > 2 files changed, 38 insertions(+) > > > > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index > > cdde590..c320930 100644 > > --- a/drivers/net/usb/Kconfig > > +++ b/drivers/net/usb/Kconfig > > @@ -98,6 +98,7 @@ config USB_RTL8150 > > config USB_RTL8152 > > tristate "Realtek RTL8152/RTL8153 Based USB Ethernet Adapters" > > select MII > > + depends on ACPI > > Hi Mario > > That seems a bit heavy handed. What about ARM or MIPS machines which > don't use ACPI but do have USB ports where i could plug in a USB dongle with > this chipset. > > I think it would be better to make use of ACPI if it is available, but don't > require it in order the build the driver. > > Andrew Hi Andrew, Thanks for that feedback. I'll adjust that to look for CONFIG_ACPI in the code instead in V2 after I get some additional comments for the implementation. Thanks,