From: Hari Kalavakunta <kalavakunta.hari.prasad@gmail.com>
To: Paul Fertser <fercerpav@gmail.com>
Cc: Sam Mendoza-Jonas <sam@mendozajonas.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, npeacock@meta.com,
akozlov@meta.com
Subject: Re: [PATCH net-next 0/2] GCPS Spec Compliance Patch Set
Date: Tue, 8 Apr 2025 15:02:14 -0700 [thread overview]
Message-ID: <b1d373d7-77e5-4341-a685-07a617935db5@gmail.com> (raw)
In-Reply-To: <Z/V2pCKe8N6Uxa0O@home.paul.comp>
On 4/8/2025 12:19 PM, Paul Fertser wrote:
> In other words, you're testing your code only with simulated data so
> there's no way to guarantee it's going to work on any real life
> hardware (as we know hardware doesn't always exactly match the specs)?
> That's unsettling. Please do mention it in the commit log, it's an
> essential point. Better yet, consider going a bit off-centre after the
> regular verification and do a control run on real hardware.
>
> After all, that's what the code is for so if it all possible it's
> better to know if it does the actual job before merging (to avoid
> noise from follow-up patches like yours which fix something that never
> worked because it was never tested).
I would like to request a week's time to integrate a real hardware
interface, which will enable me to test and demonstrate end-to-end
results. This will also allow me to identify and address any additional
issues that may arise during the testing process. Thank you for the
feedback.
next prev parent reply other threads:[~2025-04-08 22:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 18:19 kalavakunta.hari.prasad
2025-04-07 18:19 ` [PATCH net-next 1/2] net: ncsi: Format structure for longer names kalavakunta.hari.prasad
2025-04-07 18:19 ` [PATCH net-next 2/2] net: ncsi: Fix GCPS 64-bit member variables kalavakunta.hari.prasad
2025-04-07 22:23 ` Paul Fertser
2025-04-07 21:44 ` [PATCH net-next 0/2] GCPS Spec Compliance Patch Set Sam Mendoza-Jonas
2025-04-08 17:01 ` Hari Kalavakunta
2025-04-08 18:26 ` Paul Fertser
2025-04-08 18:53 ` Hari Kalavakunta
2025-04-08 19:19 ` Paul Fertser
2025-04-08 22:02 ` Hari Kalavakunta [this message]
2025-04-08 22:35 ` Paul Fertser
2025-04-08 23:23 ` Hari Kalavakunta
2025-04-09 3:27 ` Hari Kalavakunta
2025-04-09 9:08 ` Paul Fertser
2025-04-09 16:39 ` Hari Kalavakunta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d373d7-77e5-4341-a685-07a617935db5@gmail.com \
--to=kalavakunta.hari.prasad@gmail.com \
--cc=akozlov@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=npeacock@meta.com \
--cc=pabeni@redhat.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®