From: Dmitry Osipenko <digetx@gmail.com>
To: Mikko Perttunen <mperttunen@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com
Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] gpu: host1x: Fix incorrect comment for channel_request
Date: Tue, 5 Sep 2017 16:05:11 +0300 [thread overview]
Message-ID: <b1d577a4-687a-31d9-a6b6-3d9d3827aba1@gmail.com> (raw)
In-Reply-To: <20170905081029.19769-6-mperttunen@nvidia.com>
On 05.09.2017 11:10, Mikko Perttunen wrote:
> This function actually doesn't sleep in the version that was merged.
>
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
> drivers/gpu/host1x/channel.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c
> index db9b91d1384c..2fb93c27c1d9 100644
> --- a/drivers/gpu/host1x/channel.c
> +++ b/drivers/gpu/host1x/channel.c
> @@ -128,8 +128,7 @@ static struct host1x_channel *acquire_unused_channel(struct host1x *host)
> * host1x_channel_request() - Allocate a channel
> * @device: Host1x unit this channel will be used to send commands to
> *
> - * Allocates a new host1x channel for @device. If there are no free channels,
> - * this will sleep until one becomes available. May return NULL if CDMA
> + * Allocates a new host1x channel for @device. May return NULL if CDMA
> * initialization fails.
> */
> struct host1x_channel *host1x_channel_request(struct device *dev)
>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
--
Dmitry
next prev parent reply other threads:[~2017-09-05 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 8:10 [PATCH v2 0/6] Miscellaneous improvements to Host1x and TegraDRM Mikko Perttunen
2017-09-05 8:10 ` [PATCH v2 1/6] gpu: host1x: Enable Tegra186 syncpoint protection Mikko Perttunen
2017-09-05 13:33 ` Dmitry Osipenko
2017-09-22 14:02 ` Mikko Perttunen
2017-09-22 23:17 ` Dmitry Osipenko
2017-09-05 8:10 ` [PATCH v2 2/6] gpu: host1x: Enable gather filter Mikko Perttunen
2017-09-05 8:10 ` [PATCH v2 3/6] gpu: host1x: Improve debug disassembly formatting Mikko Perttunen
2017-09-05 8:10 ` [PATCH v2 4/6] gpu: host1x: Disassemble more instructions Mikko Perttunen
2017-09-05 13:02 ` Dmitry Osipenko
2017-09-05 8:10 ` [PATCH v2 5/6] gpu: host1x: Fix incorrect comment for channel_request Mikko Perttunen
2017-09-05 13:05 ` Dmitry Osipenko [this message]
2017-09-05 8:10 ` [PATCH v2 6/6] drm/tegra: Use u64_to_user_ptr helper Mikko Perttunen
2017-09-05 12:41 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d577a4-687a-31d9-a6b6-3d9d3827aba1@gmail.com \
--to=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®