Re: [PATCH 1/2] drm/vc4: Run default client setup for all variants.

["Maíra Canal" <mcanal@igalia.com>]

Hi Dave,

On 10/2/24 12:06, Dave Stevenson wrote:
> Commit 45903624e9fc ("drm/vc4: Run DRM default client setup")
> only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver
> definition, which caused an issue on vc5 (Pi4) as there was no
> fbdev_probe function defined.
> 
> Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup")
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Reviewed-by: Maíra Canal <mcanal@igalia.com>

Best Regards,
- Maíra

> ---
>   drivers/gpu/drm/vc4/vc4_drv.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> index 13a1ecddbca3..a238f76a6073 100644
> --- a/drivers/gpu/drm/vc4/vc4_drv.c
> +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> @@ -238,6 +238,7 @@ const struct drm_driver vc5_drm_driver = {
>   #endif
>   
>   	DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc5_dumb_create),
> +	DRM_FBDEV_DMA_DRIVER_OPS,
>   
>   	.fops = &vc4_drm_fops,
>   
>