mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:VIRTIO GPU DRIVER" 
	<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 4/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d()
Date: Fri, 1 Feb 2019 10:31:23 +0100	[thread overview]
Message-ID: <b1d7b700-6d0f-fee1-bec9-3b4f9962a9f5@tronnes.org> (raw)
In-Reply-To: <20190201080113.mhlzpyek62cfc5qe@sirius.home.kraxel.org>



Den 01.02.2019 09.01, skrev Gerd Hoffmann:
> On Thu, Jan 31, 2019 at 11:47:38AM +0100, Noralf Trønnes wrote:
>>
>>
>> Den 30.01.2019 10.43, skrev Gerd Hoffmann:
>>> Add 3d resource parameters to virtio_gpu_object_params struct.  With
>>> that in place we can use it for virtio_gpu_cmd_resource_create_3d()
>>> calls.
>>>
>>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>> ---
>>
>> You don't remove the struct virtio_gpu_resource_create_3d definition,
>> but it looks like there's no users left?
> 
> virtio_gpu_cmd_resource_create_3d() still uses it (and has to, it is
> part of the guest <-> host protocol).
> 

Acked-by: Noralf Trønnes <noralf@tronnes.org>

  reply	other threads:[~2019-02-01  9:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190130094338.14203-1-kraxel@redhat.com>
2019-01-30  9:43 ` [PATCH v2 1/6] drm/virtio: move virtio_gpu_object_{attach,detach} calls Gerd Hoffmann
2019-01-31 10:34   ` [PATCH v2 1/6] drm/virtio: move virtio_gpu_object_{attach, detach} calls Noralf Trønnes
2019-01-30  9:43 ` [PATCH v2 2/6] drm/virtio: use struct to pass params to virtio_gpu_object_create() Gerd Hoffmann
2019-01-31 10:40   ` Noralf Trønnes
2019-02-01  8:10     ` Gerd Hoffmann
2019-01-30  9:43 ` [PATCH v2 3/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource() Gerd Hoffmann
2019-01-31 10:41   ` Noralf Trønnes
2019-01-30  9:43 ` [PATCH v2 4/6] drm/virtio: params struct for virtio_gpu_cmd_create_resource_3d() Gerd Hoffmann
2019-01-31 10:47   ` Noralf Trønnes
2019-02-01  8:01     ` Gerd Hoffmann
2019-02-01  9:31       ` Noralf Trønnes [this message]
2019-01-30  9:43 ` [PATCH v2 5/6] drm/virtio: drop fencing in virtio_gpu_resource_create_ioctl Gerd Hoffmann
2019-01-31 10:50   ` Noralf Trønnes
2019-01-31 19:04   ` Gurchetan Singh
2019-02-01  7:23     ` Gerd Hoffmann
2019-03-18 11:35     ` Gerd Hoffmann
2019-01-30  9:43 ` [PATCH v2 6/6] drm/virtio: move virtio_gpu_cmd_create_resource call into virtio_gpu_object_create Gerd Hoffmann
2019-01-31 10:53   ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1d7b700-6d0f-fee1-bec9-3b4f9962a9f5@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®