From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84CC1135A53 for ; Tue, 12 May 2026 07:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778571217; cv=none; b=qL9qNujKS+7ZEMZeaGAEtU8PWRZUCy86nZrOItDNUXNbDsiz02HRdTCxgfkKORS8uH9Ca7aq5EFCQ1+vxQN0GIABeARomIMueZM+IdfeLMAm2vx+d5VbaPhyvj5uuEBBaaBBA+LC5QBvyX/89CeCgyN6Fuf/AISIdmGhUuza564= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778571217; c=relaxed/simple; bh=QBQ38YtbIovx3IIfEd+k2QDsSXMDIpaD/PIPsMGP/eQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eaQMhUYitwUMWIZ55opfdvmYOQH784NPjLrfWVvLQUnUUDaN2eJj/Z7r4SL7SsKeSnMUNxv47JL68MwJTnkhHqRL82ig54xQ9LdLPpl4yRUE0Z5kOsGFwVPPE2bG14I6MbjTG7xABWB/Pca11dNk3u2xSt7HO8zXZ5SfDBzpXkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=J4EBpXvC; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="J4EBpXvC" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48e82c23840so15926245e9.3 for ; Tue, 12 May 2026 00:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1778571214; x=1779176014; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=xstN3lLqULmnNo7titfY517Jxb3RjkWAVc79aexWYro=; b=J4EBpXvCU4ixYDq4HYTTfZ3k+bWwZHUJIGDXgWBzlylyeY5wzu16dpZweovMAapchA qsBeSLJbbTQRB7ZcZdGpAR4xJ9dzRncZhdsMwpM8H1AmNx0iyBtMsK+Scdm6PR7Ja0IK aSFOKgigQ9tl3bqv7712Sgye+ET4YCeiFTkBvGXbmnWRJWhFHG9GbUof7zBzP2yHAWdq h4OKnFEUnRL5wAJ8cLDXv+cOql3X1ydWfqwnnXoCPQglw73E8xx7Mok5PHcD6FOfLHys J+/Y/KaCU3BA0cbZHWbiYpIm4wLw1pZ8rsyI+/bu7/Wff8w4dqdL+YPf6941oNQZ8cUa NkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778571214; x=1779176014; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xstN3lLqULmnNo7titfY517Jxb3RjkWAVc79aexWYro=; b=dTBhBAqbZEYRsY4gdl0kif1q8+TF9jyB0fyYJd/lj/4wLbUJgAvQDrn3byjKFNXqhh /Mt/1RR5+yPEFrGW6MwW1qYn6qQ5aDhvNI/uXpjuH8KKf8WS9gVslv+/27WWEUora8Md 8qf6LZzcNCcBVaVyirahwu/smPcUZiMu8+4k9OBAN4Zc/KzswyRG/it4BJXKE1NvMfRj IoZdh4N7EfDeaSP/Egu1SPZZgzz1C6j7myq/OlIzI/YhoLDD4XCMnt9v9cmBV48ono5T /ppED9ZblADyRHNH3L22Mm3osQKxxH2LsueYS5mVkL5qgoBB2vGhW10uNti6d8eNfMfq 8FWA== X-Forwarded-Encrypted: i=1; AFNElJ/jk2gLXO8uu9NpKR2ZN3MoggV7MFYGECz2X3a9A34epx+NlT+GfzMTI1KqMynew7OoF0l92kdsuqupIXE=@vger.kernel.org X-Gm-Message-State: AOJu0YxpIVApk49WZpWRbnZYC1d9vq2e4YgjfdxsOSSbThV1pVX7AVkU A77/Q9wA0W5tSouu/EWciL3F58vG1OOqUnWTD48GyhrV+xKyLHHmkd6NfakS2SosncELriL+fSr EglpNrx2wswx4mFLR+IsDwxYX/R8LXkrghQ9BP2VTCz6JkztGBzU8gg72DOM= X-Gm-Gg: Acq92OE+oXsGTjKVOBNs7dAspfrscmNCCgn9pJnhcpuCEGWMmdXU9mMFaLkSGmmevWa K0/6L68z8Esw3FTto2EqE9yM/Kv5cINPjocJ4RJWt32rN4tyVeRACfUWwBfjNGkBNRG3tywy85a IYi7U1NvB9Sgf3dT/ifpHLUYutYZGpZixUiGCbEds2J7YllYpmU7/mzgbEGl7KRjbPIePNVMj7c vy0OJgRlTsGT/2Xtfl2yZqUkhiGZfkXp7WPyGwLhnQVzgQe/bSR4p4lWKvA7fwaBfzfzTJLdzuT n8t0q5GOlIyXQL4saorSa9FMbFeiTAozdpUEuPBMyWGeAqYfQvOX9YSZ1Q9iopD6SwyXHY2fe5s XHfq2EwIjBnSilccaGC1QMSUXVbP5BpQtsx9Bcvfhr47vpgvGBJB95QlWoBOWCnmgzVTyo2+PLS 9CtH3sFETJFz9HQZ+2aFz/hcJQWck23xitfytEZ/ZR8YrP0IXmdTcseKnBv5LISA== X-Received: by 2002:a05:600c:3510:b0:48a:8b02:ae91 with SMTP id 5b1f17b1804b1-48e8fe50c53mr23084875e9.11.1778571213798; Tue, 12 May 2026 00:33:33 -0700 (PDT) Received: from ?IPV6:2001:67c:2fbc:1:7a81:9c57:657f:40cd? ([2001:67c:2fbc:1:7a81:9c57:657f:40cd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e8e5efe71sm14202915e9.1.2026.05.12.00.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 00:33:33 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 09:33:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 2/2] ovpn: respect peer refcount in CMD_NEW_PEER error path To: David Carlier , netdev@vger.kernel.org Cc: Sabrina Dubroca , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org References: <20260512042036.19870-1-devnexen@gmail.com> <20260512042036.19870-3-devnexen@gmail.com> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AYGGhrcHM6Ly9rZXlzLm9wZW5wZ3Aub3JnFiEEyr2hKCAXwmchmIXHSPDM to9Z0UwFAmj3PEoFCShLq0sACgkQSPDMto9Z0Uw7/BAAtMIP/wzpiYn+Di0TWwNAEqDUcGnv JQ0CrFu8WzdtNo1TvEh5oqSLyO0xWaiGeDcC5bQOAAumN+0Aa8NPqhCH5O0eKslzP69cz247 4Yfx/lpNejqDaeu0Gh3kybbT84M+yFJWwbjeT9zPwfSDyoyDfBHbSb46FGoTqXR+YBp9t/CV MuXryL/vn+RmH/R8+s1T/wF2cXpQr3uXuV3e0ccKw33CugxQJsS4pqbaCmYKilLmwNBSHNrD 77BnGkml15Hd6XFFvbmxIAJVnH9ZceLln1DpjVvg5pg4BRPeWiZwf5/7UwOw+tksSIoNllUH 4z/VgsIcRw/5QyjVpUQLPY5kdr57ywieSh0agJ160fP8s/okUqqn6UQV5fE8/HBIloIbf7yW LDE5mYqmcxDzTUqdstKZzIi91QRVLgXgoi7WOeLF2WjITCWd1YcrmX/SEPnOWkK0oNr5ykb0 4XuLLzK9l9MzFkwTOwOWiQNFcxXZ9CdW2sC7G+uxhQ+x8AQW+WoLkKJF2vbREMjLqctPU1A4 557A9xZBI2xg0xWVaaOWr4eyd4vpfKY3VFlxLT7zMy/IKtsm6N01ekXwui1Zb9oWtsP3OaRx gZ5bmW8qwhk5XnNgbSfjehOO7EphsyCBgKkQZtjFyQqQZaDdQ+GTo1t6xnfBB6/TwS7pNpf2 ZvLulFbOOARoRsrsEgorBgEEAZdVAQUBAQdAyD3gsxqcxX256G9lLJ+NFhi7BQpchUat6mSA Pb+1yCQDAQgHwsF8BBgBCAAmFiEEyr2hKCAXwmchmIXHSPDMto9Z0UwFAmhGyuwCGwwFCQHh M4AACgkQSPDMto9Z0UwymQ//Z1tIZaaJM7CH8npDlnbzrI938cE0Ry5acrw2EWd0aGGUaW+L +lu6N1kTOVZiU6rnkjib+9FXwW1LhAUiLYYn2OlVpVT1kBSniR00L3oE62UpFgZbD3hr5S/i o4+ZB8fffAfD6llKxbRWNED9UrfiVh02EgYYS2Jmy+V4BT8+KJGyxNFv0LFSJjwb8zQZ5vVZ 5FPYsSQ5JQdAzYNmA99cbLlNpyHbzbHr2bXr4t8b/ri04Swn+Kzpo+811W/rkq/mI1v+yM/6 o7+0586l1MQ9m0LMj6vLXrBDN0ioGa1/97GhP8LtLE4Hlh+S8jPSDn+8BkSB4+4IpijQKtrA qVTaiP4v3Y6faqJArPch5FHKgu+rn7bMqoipKjVzKGUXroGoUHwjzeaOnnnwYMvkDIwHiAW6 XgzE5ZREn2ffEsSnVPzA4QkjP+QX/5RZoH1983gb7eOXbP/KQhiH6SO1UBAmgPKSKQGRAYYt cJX1bHWYQHTtefBGoKrbkzksL5ZvTdNRcC44/Z5u4yhNmAsq4K6wDQu0JbADv69J56jPaCM+ gg9NWuSR3XNVOui/0JRVx4qd3SnsnwsuF5xy+fD0ocYBLuksVmHa4FsJq9113Or2fM+10t1m yBIZwIDEBLu9zxGUYLenla/gHde+UnSs+mycN0sya9ahOBTG/57k7w/aQLc= Organization: OpenVPN Inc. In-Reply-To: <20260512042036.19870-3-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 12/05/2026 06:19, David Carlier wrote: > diff --git a/drivers/net/ovpn/netlink.c b/drivers/net/ovpn/netlink.c > index 291e2e5bb450..4c66c1ec497e 100644 > --- a/drivers/net/ovpn/netlink.c > +++ b/drivers/net/ovpn/netlink.c > @@ -462,10 +462,12 @@ int ovpn_nl_peer_new_doit(struct sk_buff *skb, struct genl_info *info) > sock_release: > ovpn_socket_release(peer); > peer_release: > - /* release right away because peer was not yet hashed, thus it is not > - * used in any context > + /* For UDP, the peer is unreachable until added to the hashtables, so > + * dropping the initial reference is enough. For TCP, the peer may be > + * concurrently reachable via sk_user_data->peer until > + * ovpn_socket_release() detaches; rely on the refcount. > */ > - ovpn_peer_release(peer); > + ovpn_peer_put(peer); Thanks for this patch! Unless the CI Complains, I'm pulling this in my tree and staging it for the next PR to net. Regards, -- Antonio Quartulli OpenVPN Inc.