From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B8636494E for ; Sun, 22 Mar 2026 00:38:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774139885; cv=none; b=pgG0FI08M1vpbIAsJW+CEYhHY+RG93QYlepQLQI9OceQ/HHdrpEVdOiEJcKvUZSST+ymk+UcT28p6VAj2XRBc+fwd5JQ8XYgWQaF5dNQUBMwA0mpg0ZeK5jExkZ7LfkNdBaWOEDjucSIEhw3umcRlXQQU5Uxy+krpjfw1xCJGrQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774139885; c=relaxed/simple; bh=6dLhB2ydoQBAqJPB1raZlJyeJqk0XqP+WELLlaK0rKY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WWa9Ru48M6t3FnIpggBwNxQVmomWLEi46llyKTJWz6vRNJvr4kYF7fob1vSfhMwwmzuP4DvvB7cPdVHuTsiZhNjX1uBT0nMb/MjHmQbBhAnwyhHwhyxKcj77ffB6mGTSPT+YVvuK+PUzLuNSjQ5pzL5q2iBMiCccO1a/DQFzi1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=m20yiiym; arc=none smtp.client-ip=209.85.160.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="m20yiiym" Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-40ede943bf0so849588fac.2 for ; Sat, 21 Mar 2026 17:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1774139883; x=1774744683; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1ZkURIzaUVIDe1R8WHRcSdusVPoS3d/IbkclZRm0aAU=; b=m20yiiymSwTNb5PCtfbOHTPDJwyRUu81ZGCoAiLBlO9tP/GemtwbjWh4LJqIbMd5ps Hdbvf+8lZ79Bz1EC8BgOx1jhgAgyaPhYtUNhV/azDXqr85lbMpIDQPwMyPcHoHI1jrEQ I8gKyKiGeOF8Yr08ik45Vj6Bj2NTBsEHuEZuOVtwsa+/K/CrMiCDiFxaKW/ap0WOPemd 2wVBL7gbn/kaHkcy3ETvNdErTI2y9vMsXuDNzegwKepsSBVHFWsoBRLdVl30PmbkFfCT W6NMSDurky8EuPKCjOL8YwVUxrDMJDsz48gawrXQi2djNewXwhi3njA6TxsfnFBNvEnl KZDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774139883; x=1774744683; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1ZkURIzaUVIDe1R8WHRcSdusVPoS3d/IbkclZRm0aAU=; b=grqiFKrpEG6jYgQrpyCKWiw4QpZK12IiMYKR0N77ThFqRoOTiEZ7DYCV32UdQXekFB ynLXEiukiVyqDgI3A9jWuRSORbFpQFOO4yUAMxc+9jQr5Bpdb136UZkhI7eFr1jvcvFP P6noaIVDNYmVN7ctIJYoEnI3o1oV505+Q7LIUXLNpyXAAdxuicyXr79BoL9sQMyOvm+e FxVxYf0VD4b8lzlAwH/bKFeySq/GutxbW7RaR1xwVDgOyrJWQQl6cvwgQ0778rAOvGav /8uXlLdqsXExgRyTzw/0xuy5ujSryYv01SGoWh92P69fFdJMR0ZkV2yFqMNFhIj9fx3k XFOQ== X-Forwarded-Encrypted: i=1; AJvYcCW7R4sd20NSbVcMm+wUZKEMl4htxGDlOTpYzNZyHVmYC7Ry+7YsWPT0HGaJ1+++4Acrk33ZEHFcY4VQ/RU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy58zUHV0ZvH5/aHxdRmlXp7Eh6gONmPopU7ArAiozWa1/2ud9u mpGBrNh4rr4ys7ya8sy1OMVEb77hrJ/rgoHsD6Rekg8MpID53Ub3gN2swrnnSfO4CoI= X-Gm-Gg: ATEYQzzUYia9QxlHPMCkra2AQxfBVhKBCNNq3eFMlVQjN/C3tqaUsrh+1n+A9U+u8tT wRzH9PHvsKLKJT8H3j/68Xg5sO4Nb2NTtZo85i/jM9y/+/72lh6BTXfeCL/qNuZB9+oiCYZY6lI fxxLe7wo6S4HCwItnkUSJH9SZr88bfbm8oBSIame4C4zpTZ2sWHjUZQC/zoHV3u2weVCW9KwaXB fTvvFXguVOhdxsrLvHEUolDpBlmnRGniv3PRyZxRgx5TItWV9G3OB68G9e2dF6h7AItoLl20Gus NSGLU2KAECcbncSG67RZPCPbBVk/M5l4rGjAj+k8P+DZGDUu98X9aGMXqyst87TkbBLagO3N+U0 Hb1g7ZjXEpnejuzXs3ThMrlAd3gzxwh0eQk5Py9uhqpnVEi3wbMcmizCjywpWzkmSa5F8zH5z3i UzSayfPxqDycSL+xV31oJ3imxEMDwEjpjfifn1T2QRqC4/szwCGgszbZHfpBbOjqz9545ctPM= X-Received: by 2002:a05:6870:45a6:b0:3ec:4f31:42a with SMTP id 586e51a60fabf-41c10eff5ddmr5416367fac.7.1774139882771; Sat, 21 Mar 2026 17:38:02 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:fb84:df2:aafb:553d? ([2600:8803:e7e4:500:fb84:df2:aafb:553d]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-41c14d63aa9sm5915411fac.10.2026.03.21.17.37.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Mar 2026 17:38:01 -0700 (PDT) Message-ID: Date: Sat, 21 Mar 2026 19:37:58 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] iio: proximity: add driver for ST VL53L1X ToF sensor To: Sirat Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org References: <20260319190738.151614-1-email@sirat.me> <20260319190738.151614-3-email@sirat.me> <8502eb51-53c9-4f1b-92d0-21b06fa4802e@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/21/26 5:39 PM, Sirat wrote: > On Sat, Mar 21, 2026 at 11:09 PM David Lechner wrote: >> >> On 3/19/26 2:07 PM, Siratul Islam wrote: >>> Add support for the STMicroelectronics VL53L1X Time-of-Flight >>> ranging sensor with I2C interface. >>> ... >>> + >>> + ret = vl53l1x_start_ranging(data); >>> + if (ret) >>> + return ret; >> >> Why start ranging here? It looks like this is controlled during buffer >> enable/disable. >> > The VL53L1X (unlike L0X) does not have a single-shot mode. So every > measurement requires the device > to be running (Autonomous mode according to the datasheet). Starting > ranging once > in probe allows the direct read path to work without any additional > start/stop logic inside read_raw(). > This keeps that path simple and low-latency. The buffered/triggered > path independently controls > ranging via postenable/predisable, so there is no conflict. If you do a buffered read, which stop ranging when it is done, then how can the direct read work after that? Can we just start and stop ranging momentarily for a direct read? Otherwise, is seems like we would want to have ranging always enabled. >> >> > I will address the rest of your review in the next version. > > Thanks, > Sirat