From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdEUJvs (ORCPT ); Sun, 21 May 2017 05:51:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36244 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbdEUJvq (ORCPT ); Sun, 21 May 2017 05:51:46 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E416383F45 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E416383F45 Subject: Re: [PATCH v6] mfd: Add Cherry Trail Whiskey Cove PMIC driver To: Paul Gortmaker Cc: Lee Jones , LKML , Bin Gao , Felipe Balbi , Andy Shevchenko References: <20170515181743.2174-1-hdegoede@redhat.com> <053963da-a791-e95f-dcc3-31161c553bb2@redhat.com> From: Hans de Goede Message-ID: Date: Sun, 21 May 2017 11:51:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 21 May 2017 09:51:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 20-05-17 21:26, Paul Gortmaker wrote: > On Sat, May 20, 2017 at 3:21 PM, Paul Gortmaker > wrote: >> On Mon, May 15, 2017 at 2:20 PM, Hans de Goede wrote: >>> Hi, >>> >>> This is actually v7, with the following changes: >>> >>> Changes in v7: >>> -Add explanation why this is a bool and why it selects i2c-designwaree > > Gah -- I missed the explanation mentioned above: > > -Change Kconfig option from tristate to boolean and add a select for the > i2c-bus driver, this is necessary because the chtwc PMIC provides an ACPI > OPRegion handler, which must be available before other drivers using it > are loaded, which can only be ensured if the mfd, opregion and i2c-bus > drivers are built in > > Given that, can we get rid of the modular macros in the code now as well? Yes we can, to be clear you are talking about dropping: MODULE_DEVICE_TABLE(i2c, cht_wc_i2c_id); MODULE_DEVICE_TABLE(acpi, cht_wc_acpi_ids); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Hans de Goede "); And replacing: module_i2c_driver(cht_wc_driver); with: builtin_i2c_driver(cht_wc_driver); Right ? Anything I'm missing ? If not I will post a new version with these removed / replaced. Regards, Hans