From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>, Conor Dooley <conor@kernel.org>
Cc: conor.dooley@microchip.com, daire.mcnamara@microchip.com,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
stable@vger.kernel.org
Subject: Re: [PATCH] soc: microchip: mpfs: Fix flash leak in mpfs_sys_controller_probe()
Date: Sat, 7 Nov 2026 10:58:35 +0100 [thread overview]
Message-ID: <b1e6aa27-4a2b-43d2-91c1-2addb528dcab@kernel.org> (raw)
In-Reply-To: <179393668487.2060453.14381920142402581273@iscas.ac.cn>
On 06/11/2026 04:44, Wentao Liang wrote:
> Hi Krzysztof, Conor,
>
> Thank you both for the detailed review.
>
> Sorry for the late reply, and for the mess it caused.
>
> This is a v2 of the earlier patch, but I sent it without the v2 prefix,
> without a changelog, and without referring back to Conor's review from
> 8 October:
>
> https://lore.kernel.org/all/20261008-47741881fb032091ea3d7f0c@squawk/
>
> You are also right that the patches were sent in bulk across unrelated
> subsystems, without being grouped into patchsets, without running checkpatch
> on them, and without documenting what was and was not tested. I am sorry for
> the extra work this has caused you.
>
> In particular, thank you for pointing me to the kernel documentation on
> subsystem identification, patchset organization and testing, and for the
> guidance on how this work should be submitted. This is an important lesson
> for me, and from now on I will go through all the remaining feedback
> manually, one by one, and reply in a timely manner.
>
> Going forward, I will also not send patches in large batches, so that I do
> not exceed my own capacity to respond.
If it sends patches like a bot, if it ignored feeedback like a bot 100
times and then finally if it responds like a bot, it is probably a bot.
https://en.wikipedia.org/wiki/Duck_test
Best regards,
Krzysztof
prev parent reply other threads:[~2026-11-07 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 15:35 Wentao Liang
2026-10-02 17:48 ` Conor Dooley
2026-10-08 13:18 ` Conor Dooley
2026-11-06 3:44 ` Wentao Liang
2026-11-07 9:58 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e6aa27-4a2b-43d2-91c1-2addb528dcab@kernel.org \
--to=krzk@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=daire.mcnamara@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®