From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 095AFC43331 for ; Fri, 6 Sep 2019 21:42:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2FE32070C for ; Fri, 6 Sep 2019 21:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404528AbfIFVmp (ORCPT ); Fri, 6 Sep 2019 17:42:45 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:35967 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404330AbfIFVmp (ORCPT ); Fri, 6 Sep 2019 17:42:45 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 46Q9yV3rdlz1rBnG; Fri, 6 Sep 2019 23:42:42 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 46Q9yT6wDbz1qqkL; Fri, 6 Sep 2019 23:42:41 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id t9OQ9xgR4JfV; Fri, 6 Sep 2019 23:42:40 +0200 (CEST) X-Auth-Info: XI9LOAh4ifYqfsMPbJx/yTDhFQxMQ7fjF21BOqFvQ+A= Received: from [IPv6:::1] (unknown [195.140.253.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 6 Sep 2019 23:42:40 +0200 (CEST) From: Marek Vasut Subject: Re: [PATCH net-next 1/3] net: dsa: microchip: add KSZ9477 I2C driver To: George McCollister , netdev@vger.kernel.org Cc: Woojung Huh , Andrew Lunn , Florian Fainelli , Tristram Ha , "David S. Miller" , linux-kernel@vger.kernel.org References: <20190906213054.48908-1-george.mccollister@gmail.com> <20190906213054.48908-2-george.mccollister@gmail.com> Message-ID: Date: Fri, 6 Sep 2019 23:39:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190906213054.48908-2-george.mccollister@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/6/19 11:30 PM, George McCollister wrote: [...] > --- /dev/null > +++ b/drivers/net/dsa/microchip/ksz9477_i2c.c > @@ -0,0 +1,100 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Microchip KSZ9477 series register access through I2C > + * > + * Copyright (C) 2018-2019 Microchip Technology Inc. Doesn't the copyright need update ? > + */ > + > +#include > +#include > +#include > +#include Please keep the headers sorted. > +#include "ksz_common.h" > + > +KSZ_REGMAP_TABLE(ksz9477, not_used, 16, 0, 0); > + The rest looks good. [...] -- Best regards, Marek Vasut